Page MenuHomePhabricator

Deprecate methods accepting Revision objects as parameters
Closed, ResolvedPublic

Description

So that the class can be removed

Core methods tracked in P10916

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+27 -3
mediawiki/coremaster+32 -17
mediawiki/coremaster+5 -2
mediawiki/coremaster+35 -21
mediawiki/coremaster+10 -5
mediawiki/extensions/MobileFrontendmaster+5 -10
mediawiki/extensions/Wikibasemaster+2 -4
mediawiki/coremaster+12 -6
mediawiki/coremaster+49 -30
mediawiki/extensions/Wikibasemaster+8 -2
mediawiki/extensions/Videomaster+2 -3
mediawiki/coremaster+10 -3
mediawiki/extensions/Wikibasemaster+58 -34
mediawiki/coremaster+4 -0
mediawiki/coremaster+4 -0
mediawiki/coremaster+4 -2
mediawiki/coremaster+35 -10
mediawiki/coremaster+78 -43
mediawiki/extensions/FlaggedRevswmf/1.35.0-wmf.28+14 -7
mediawiki/extensions/FlaggedRevsmaster+14 -7
mediawiki/extensions/MobileFrontendmaster+14 -6
mediawiki/coremaster+6 -0
mediawiki/extensions/FlaggedRevsmaster+3 -3
mediawiki/coremaster+12 -8
mediawiki/coremaster+12 -4
mediawiki/coremaster+14 -12
mediawiki/extensions/Jademaster+83 -52
mediawiki/coremaster+30 -8
mediawiki/coremaster+11 -7
mediawiki/coremaster+28 -10
mediawiki/extensions/TwoColConflictmaster+7 -1
mediawiki/coremaster+118 -41
Show related patches Customize query in gerrit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 586459 merged by jenkins-bot:
[mediawiki/core@master] Accept RevisionRecord in Linker methods

https://gerrit.wikimedia.org/r/586459

Change 586484 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/TwoColConflict@master] Don't create a Revision object for Linker::revUserTools

https://gerrit.wikimedia.org/r/586484

Change 586484 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/TwoColConflict@master] Don't create a Revision object for Linker::revUserTools

https://gerrit.wikimedia.org/r/586484

Other than this replacement, the only deployed extension that will need to be updated before hard deprecation of Revision objects is Jade, which will be updated as part of https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Jade/+/586445/

Change 586484 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Don't create a Revision object for Linker::revUserTools in MW 1.35+

https://gerrit.wikimedia.org/r/586484

Change 587376 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Support RevisionRecord in WikiPage::hasDifferencesOutsideMainSlot

https://gerrit.wikimedia.org/r/587376

Change 587379 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Use RevisionRecord in WikiPage::setLastEdit, make private

https://gerrit.wikimedia.org/r/587379

Change 587376 merged by jenkins-bot:
[mediawiki/core@master] Support RevisionRecord in WikiPage::hasDifferencesOutsideMainSlot

https://gerrit.wikimedia.org/r/587376

Change 587379 merged by jenkins-bot:
[mediawiki/core@master] Use RevisionRecord in WikiPage::setLastEdit, make private

https://gerrit.wikimedia.org/r/587379

Change 587393 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Replace remaining uses and hard deprecate Title::getAuthorsBetween

https://gerrit.wikimedia.org/r/587393

Change 587395 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate Article::doDeleteUpdates, use RevisionRecord in WikiPage

https://gerrit.wikimedia.org/r/587395

Change 587571 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Use RevisionRecord in ResourceLoaderWikiModule::invalidateModuleCache

https://gerrit.wikimedia.org/r/587571

Change 587395 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate Article::doDeleteUpdates, use RevisionRecord in WikiPage

https://gerrit.wikimedia.org/r/587395

Change 586445 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Jade@master] Remove use of Revision::newFromId, use RevisionRecord in Linker methods

https://gerrit.wikimedia.org/r/586445

Change 586445 merged by jenkins-bot:
[mediawiki/extensions/Jade@master] Remove use of Revision::newFromId, use RevisionRecord in Linker methods

https://gerrit.wikimedia.org/r/586445

Change 587908 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] DifferenceEngine::getParserOutput - accept a RevisionRecord

https://gerrit.wikimedia.org/r/587908

Change 587910 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] WikiPage::onArticleEdit - accept a RevisionRecord

https://gerrit.wikimedia.org/r/587910

Change 587911 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Make HistoryPager methods private, use RevisionRecord

https://gerrit.wikimedia.org/r/587911

Change 587912 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Wikibase@master] EntityContentDiffView::getParserOutput - don't require Revisions

https://gerrit.wikimedia.org/r/587912

Change 587911 merged by jenkins-bot:
[mediawiki/core@master] Make HistoryPager methods private, use RevisionRecord

https://gerrit.wikimedia.org/r/587911

Change 588199 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/FlaggedRevs@master] Remove use of WikiPage::getUndoContent in RevisionReviewForm::doSubmit

https://gerrit.wikimedia.org/r/588199

Change 587910 merged by jenkins-bot:
[mediawiki/core@master] WikiPage::onArticleEdit - accept a RevisionRecord

https://gerrit.wikimedia.org/r/587910

Change 588838 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate Article::updateRevisionOn

https://gerrit.wikimedia.org/r/588838

Change 588839 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Accept a RevisionRecord in WikiPage::updateRevisionOn

https://gerrit.wikimedia.org/r/588839

Change 588199 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Remove use of WikiPage::getUndoContent in RevisionReviewForm::doSubmit

https://gerrit.wikimedia.org/r/588199

Change 589137 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/FlaggedRevs@master] Pass a RevisionRecord to WikiPage::updateRevisionOn

https://gerrit.wikimedia.org/r/589137

Change 588839 merged by jenkins-bot:
[mediawiki/core@master] Accept a RevisionRecord in WikiPage::updateRevisionOn

https://gerrit.wikimedia.org/r/588839

Change 588838 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate Article::updateRevisionOn and ::updateIfNewerOn

https://gerrit.wikimedia.org/r/588838

Change 589137 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Pass a RevisionRecord to WikiPage::updateRevisionOn

https://gerrit.wikimedia.org/r/589137

Change 589171 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Replace NewRevisionFromEditComplete with RevisionFromEditComplete

https://gerrit.wikimedia.org/r/589171

Change 589407 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/MobileFrontend@master] SpecialMobileContributions::showContributionsRow - use RevisionRecord

https://gerrit.wikimedia.org/r/589407

Change 589407 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] SpecialMobileContributions::showContributionsRow - use RevisionRecord

https://gerrit.wikimedia.org/r/589407

Change 589431 had a related patch set uploaded (by Jforrester; owner: DannyS712):
[mediawiki/extensions/FlaggedRevs@wmf/1.35.0-wmf.28] Remove use of WikiPage::getUndoContent in RevisionReviewForm::doSubmit

https://gerrit.wikimedia.org/r/589431

Change 589431 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@wmf/1.35.0-wmf.28] Remove use of WikiPage::getUndoContent in RevisionReviewForm::doSubmit

https://gerrit.wikimedia.org/r/589431

Change 589766 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Pass RevisionRecord to Linker methods

https://gerrit.wikimedia.org/r/589766

Change 589766 merged by jenkins-bot:
[mediawiki/core@master] Pass RevisionRecord to Linker methods

https://gerrit.wikimedia.org/r/589766

Change 589791 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate using Revision objects for Linker methods

https://gerrit.wikimedia.org/r/589791

Change 589794 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate Article::doEditUpdates

https://gerrit.wikimedia.org/r/589794

Change 587393 merged by jenkins-bot:
[mediawiki/core@master] Fix remaining uses and hard deprecate Title::(get|count)AuthorsBetween

https://gerrit.wikimedia.org/r/587393

Change 589791 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate using Revision objects for Linker methods

https://gerrit.wikimedia.org/r/589791

Change 589794 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate Article::doEditUpdates

https://gerrit.wikimedia.org/r/589794

Change 589881 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate Article::prepareContentForEdit

https://gerrit.wikimedia.org/r/589881

Change 589882 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate Article::getUndoContent

https://gerrit.wikimedia.org/r/589882

Change 589881 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate Article::prepareContentForEdit

https://gerrit.wikimedia.org/r/589881

Change 589882 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate Article::getUndoContent

https://gerrit.wikimedia.org/r/589882

Change 591021 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Wikibase@master] ChangeNotifier::notifyOnPageUndeleted - use RevisionRecord

https://gerrit.wikimedia.org/r/591021

Change 591021 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] ChangeNotifier - use RevisionRecord

https://gerrit.wikimedia.org/r/591021

cscott added a subscriber: cscott.Apr 20 2020, 9:09 PM

https://gerrit.wikimedia.org/r/589791 / 82657a347a7f3daa9de5ef7454603c803073cbb5 seems to be causing jenkins to fail for [[mw:Extension::Video]], cf https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-docker/62765/console where the failure is reported as:

16:55:24 INFO:backend.DevWebServer:[Mon Apr 20 20:55:24 2020] PHP Deprecated:  Use of Linker::revUserTools with a Revision object was deprecated in MediaWiki 1.35. [Called from SpecialUndeleteWithVideoSupport::formatRevisionRow in /workspace/src/extensions/Video/includes/specials/SpecialUndeleteWithVideoSupport.php at line 1020] in /workspace/src/includes/debug/MWDebug.php on line 333
16:55:24 INFO:backend.DevWebServer:[Mon Apr 20 20:55:24 2020] PHP Deprecated:  Use of Linker::revComment with a Revision object was deprecated in MediaWiki 1.35. [Called from SpecialUndeleteWithVideoSupport::formatRevisionRow in /workspace/src/extensions/Video/includes/specials/SpecialUndeleteWithVideoSupport.php at line 1032] in /workspace/src/includes/debug/MWDebug.php on line 333

Change 591182 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/Video@master] Use RevisionRecord instead of Revision

https://gerrit.wikimedia.org/r/591182

I haven't updated non-deployed extensions yet, but can send patches for them if you want

Change 591182 merged by jenkins-bot:
[mediawiki/extensions/Video@master] Use RevisionRecord instead of Revision

https://gerrit.wikimedia.org/r/591182

Change 591524 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] SpecialUndelete: Make showDiff private, use RevisionRecord

https://gerrit.wikimedia.org/r/591524

Change 591531 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] MediaWikiIntegrationTestCase: Remove use of Revision objects

https://gerrit.wikimedia.org/r/591531

Change 587912 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] EntityContentDiffView::getParserOutput - don't require Revisions

https://gerrit.wikimedia.org/r/587912

Change 592321 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] WikiPage::updateRevisionOn - replace uses, hard deprecate Revision use

https://gerrit.wikimedia.org/r/592321

Change 591524 merged by jenkins-bot:
[mediawiki/core@master] SpecialUndelete: Make showDiff private, use RevisionRecord

https://gerrit.wikimedia.org/r/591524

Change 592740 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Pass RevisionRecord to DifferenceEngine::getRevisionHeader

https://gerrit.wikimedia.org/r/592740

Change 592758 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Wikibase@master] Deprecate Revision in DifferenceEngine::getRevisionHeader

https://gerrit.wikimedia.org/r/592758

Change 592740 merged by jenkins-bot:
[mediawiki/core@master] Pass RevisionRecord to DifferenceEngine::getRevisionHeader

https://gerrit.wikimedia.org/r/592740

Change 592758 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Deprecate Revision in EntityContentDiffView::getRevisionHeader

https://gerrit.wikimedia.org/r/592758

Change 592801 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/MobileFrontend@master] Only RevisionRecord in MobileSpecialPageFeed::getRevisionCommentHTML

https://gerrit.wikimedia.org/r/592801

DannyS712 updated the task description. (Show Details)Apr 28 2020, 2:01 AM

Change 592801 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Only RevisionRecord in MobileSpecialPageFeed::getRevisionCommentHTML

https://gerrit.wikimedia.org/r/592801

Change 591531 merged by jenkins-bot:
[mediawiki/core@master] MediaWikiIntegrationTestCase: Remove use of Revision objects

https://gerrit.wikimedia.org/r/591531

Change 592321 merged by jenkins-bot:
[mediawiki/core@master] WikiPage::updateRevisionOn - replace uses, hard deprecate Revision use

https://gerrit.wikimedia.org/r/592321

Change 587908 abandoned by DannyS712:
DifferenceEngine::getParserOutput - accept a RevisionRecord

Reason:
Already done

https://gerrit.wikimedia.org/r/587908

Change 587571 merged by jenkins-bot:
[mediawiki/core@master] resourceloader: Use RevisionRecord in WikiModule::invalidateModuleCache

https://gerrit.wikimedia.org/r/587571

Change 607654 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] ApiQueryRevisions::getRollbackToken - pass RevisionRecord

https://gerrit.wikimedia.org/r/607654

Change 607654 merged by jenkins-bot:
[mediawiki/core@master] ApiQueryRevisions::getRollbackToken - pass RevisionRecord

https://gerrit.wikimedia.org/r/c/mediawiki/core/ /607654

DannyS712 closed this task as Resolved.Thu, Jul 2, 2:51 AM
DannyS712 claimed this task.
DannyS712 removed a project: Patch-For-Review.

Should be done