Page MenuHomePhabricator
Create Task
Maniphest T249599

DatabaseUpdater should not call hooks in the constructor
Closed, DuplicatePublic
Actions

Description

DatabaseUpdater modifies global variables and executes hooks in the constructor. This can be dangerous, see the major outage cause by T157651.

The initialization currently done in DatabaseUpdater's constructor should be done later, in doUpdates() or a separate initialization method.

Related Objects
Search...

Event Timeline

daniel created this task.Apr 7 2020, 9:57 AM
daniel moved this task from Inbox to Doing(WIP:5) on the Platform Team Workboards (Clinic Duty Team) board.
gerritbot added a comment.Apr 7 2020, 10:18 AM

Change 587223 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] DatabaseUpdater: don't call hook in constructor

https://gerrit.wikimedia.org/r/587223

gerritbot added a project: Patch-For-Review.Apr 7 2020, 10:19 AM
daniel renamed this task from DatabaseUpdater should not do work in the constructor to DatabaseUpdater should not call hooks in the constructor.Apr 7 2020, 10:19 AM
daniel triaged this task as High priority.
daniel moved this task from Doing(WIP:5) to Waiting for Review on the Platform Team Workboards (Clinic Duty Team) board.
daniel mentioned this in T157651: sql.php must not run LoadExtensionSchemaUpdates.Apr 7 2020, 10:22 AM
gerritbot added a comment.Apr 7 2020, 1:14 PM

Change 587223 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] DatabaseUpdater: don't call hook in constructor

https://gerrit.wikimedia.org/r/587223

daniel closed this task as a duplicate of T249584: Call LoadExtensionSchemaUpdates later.Apr 7 2020, 3:05 PM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:40 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits