Page MenuHomePhabricator

Article pull to refresh is jittery
Closed, ResolvedPublicBUG REPORT

Description

How many times were you able to reproduce it?

Every time

Steps to reproduce

  1. Go to an article with a header image (easier to see this way)
  2. Pull to refresh

Expected results

Article smoothly bounces

Actual results

Header jumps to the top for a split second while it's refreshing.

Environments observed

App version: 6.6.0 (1734)
OS versions: 13.3.1
Device model: iPhone X
Device language: EN

Event Timeline

@Tsevener Do you a recall a build/release where this seemed to work as expected, or to your knowledge has it always exhibited this behavior?

@Dmantena Looking at Testflight, it seems like it was introduced between builds 6.6.0 (1728) and 6.6.0 (1729). So you might be able to checkout betas/1728 and betas/1729 and compare the differences in ArticleViewController.

Initial incremental improvements that address the most obvious and egregious cases of this occurring have been merged for sake of including in the next TestFlight beta.

Continued work on this ticket includes:

  • Investigating cause for remaining article refresh glitches
  • Ensuring offline/saved article functionality
  • Investigating offline banner regression

Update on status of this: work has been merged that dramatically improves the pull to refresh experience and mitigates most cases of article scroll position jitteriness introduced in 6.6.0. As part of the resolution, there's now a temporary overlay that appears over the article view as content is being reloaded to prevent the user from manipulating the scroll position (which contributed to the problem.) Additionally, the toolbar items are temporarily disabled until a reload attempt (whether successful or unsuccessful) concludes.

While it's still possible a pull to refresh in this build can in some cases induce article scroll position jitter, that same behavior is also possible to reproduce in 6.5.1. There is definitely continued work that needs to be done here to improve the experience, but in favor of not introducing any unintended bugs to our most critical feature (reading articles) as we approach code freeze for this release, moving the existing merged work to design review and saving continued refinements for the future.

cmadeo subscribed.

Thanks for this great work @Dmantena! Looking good!

Tsevener added a subscriber: Dmantena.
JMinor claimed this task.