Page MenuHomePhabricator

mediawiki.action.delete.js and mediawiki.action.delete.file.js are identical
Closed, ResolvedPublic


The only differences between the two files are:

  • The comment at the top
  • The comment at line 12 (// Should be built the same as in Article::delete() vs in SpecialRevisionDelete::submit())
  • The presence of an extra blank line in file.js

I suggest that the two be combined

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Indeed, mediawiki.action.delete.file could simply be deleted and mediawiki.action.delete added to the page where mediawiki.action.delete.file currently is.

Change 588492 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Combine mediawiki.action.delete.js and mediawiki.action.delete.file.js

Krinkle triaged this task as Medium priority.May 21 2020, 12:25 AM
Krinkle moved this task from Limbo to Perf recommendation on the Performance-Team (Radar) board.

@Krinkle can you take a look at the pending patch?

Krinkle removed a project: good first task.

I cannot. I've tagged Growth Team as documented steward for this, but it's not likely to be a priority in the near future.

Change 588492 merged by jenkins-bot:
[mediawiki/core@master] Combine mediawiki.action.delete.js and mediawiki.action.delete.file.js

When these files were added, one of the pages was using OOUI and the other was not, so they were actually different. Now they both use OOUI and it makes sense to merge them. Thanks!