Page MenuHomePhabricator

Extract header out of App
Closed, ResolvedPublic

Description

The templating for the Bridge header should move out of App into a dedicated component. It’s not decided yet whether that component will directly use ProcessDialogHeader, or whether it will switch (depending on whether there may be a “back” button or not) between two other components, each of which then uses ProcessDialogHeader, but in either case, the component that is mounted by App will look at the store and make that decision. (The “back”/“close” toggle is then made via CSS, both buttons are always present in the DOM if the current status + errors call for a “back” option.) But in any case, actually introducing that distinction is subject of a separate task.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 8 2020, 1:27 PM
Michael claimed this task.Apr 9 2020, 12:57 PM
Michael moved this task from To do to Doing on the Wikidata-Bridge-Sprint-18 board.
Restricted Application added a project: User-Michael. · View Herald TranscriptApr 9 2020, 12:57 PM

Change 587798 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] bridge: Extract header to improve encapsulation and SRP

https://gerrit.wikimedia.org/r/587798

Change 587798 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: Extract header to improve encapsulation and SRP

https://gerrit.wikimedia.org/r/587798

Anything left to do?

It’s not decided yet whether that component will directly use ProcessDialogHeader, or whether it will switch (depending on whether there may be a “back” button or not) between two other components, each of which then uses ProcessDialogHeader

Has that decision been made now or is it still open?

Anything left to do?

It’s not decided yet whether that component will directly use ProcessDialogHeader, or whether it will switch (depending on whether there may be a “back” button or not) between two other components, each of which then uses ProcessDialogHeader

Has that decision been made now or is it still open?

If that is to be done, then it might be a better idea to it when integrating that button. I currently don't see a clear line where things would lend themselves to extracting exactly two more components.