Move Item and Property prefetching-term-lookup-callback service wiring into WikibaseRepo.entitytypes.php
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Addshore
	Apr 9 2020, 8:22 AM

Description

Currently the service wiring for prefetching-term-lookup-callback service is in SingleEntitySourceServices for items and properties.
This is confusing and this wiring should instead be created in the WikibaseRepo.entitytypes.php file as with all other wirings.

See SingleEntitySourceServices::getPrefetchingTermLookup

Details

	Subject	Repo	Branch	Lines +/-
	Move prefetching-term-lookup-callback service wiring	mediawiki/extensions/Wikibase	master	+127 -79

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		None	T246606 [EPIC] Display statements made with federated properties on item page
		Resolved		None	T249796 Move Item and Property prefetching-term-lookup-callback service wiring into WikibaseRepo.entitytypes.php

Event Timeline

Addshore created this task.Apr 9 2020, 8:22 AM

Addshore mentioned this in T246606: [EPIC] Display statements made with federated properties on item page.Apr 9 2020, 8:29 AM

• Samantha_Alipio_WMDE moved this task from Backlog to Prioritized backlog (aka Ready to pick up) on the Wikibase - Federated Properties board.Apr 9 2020, 10:13 AM

• Samantha_Alipio_WMDE edited projects, added Wikibase - Federated Properties (Sprint 4/6 (Hike 1)); removed Wikibase - Federated Properties.Apr 21 2020, 10:17 AM

Change 591323 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)):
[mediawiki/extensions/Wikibase@master] Move item prefetching-term-lookup-callback service wiring into WikibaseRepo.entitytypes.php

https://gerrit.wikimedia.org/r/591323

gerritbot added a project: Patch-For-Review.Apr 21 2020, 11:55 AM

Addshore moved this task from To do to Doing on the Wikibase - Federated Properties (Sprint 4/6 (Hike 1)) board.Apr 21 2020, 12:28 PM

Jakob_WMDE moved this task from Doing to Peer Review on the Wikibase - Federated Properties (Sprint 4/6 (Hike 1)) board.Apr 22 2020, 7:58 AM

Change 591323 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Move prefetching-term-lookup-callback service wiring

https://gerrit.wikimedia.org/r/591323

Maintenance_bot removed a project: Patch-For-Review.Apr 29 2020, 2:10 PM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.31; 2020-05-05).Apr 29 2020, 3:00 PM

Addshore moved this task from Peer Review to Product Verification on the Wikibase - Federated Properties (Sprint 4/6 (Hike 1)) board.Apr 29 2020, 3:22 PM

Jakob_WMDE moved this task from Product Verification to Done on the Wikibase - Federated Properties (Sprint 4/6 (Hike 1)) board.Apr 30 2020, 9:02 AM

• Samantha_Alipio_WMDE closed this task as Resolved.May 4 2020, 2:11 PM