Page MenuHomePhabricator

maps: whitelist/reduce ratelimit from requests with toolforge.org referrer
Closed, ResolvedPublic

Description

The Toolforge service is changing the domain for webservices hosted in that platform. More rationale can be found here: https://wikitech.wikimedia.org/wiki/News/Toolforge.org

Previous domain and tool name: tools.wmflabs.org/<tool>
New domain and tool name: <tool>.toolforge.org

Testing this change with @Urbanecm we noticed that the maps server (maps.wikimedia.org) applies some ratelimiting to requests based on the referrer.
The old domain works while the new one gets HTTP 429 "Too many requests".

Example:
https://wikinity.toolforge.org/s/1568

This might be related to the changes applied in T244278: Document 2020-02-04 kartotherian incident

Event Timeline

Change 587730 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[operations/puppet@production] whitelist ratelimit from requests with toolforge.org referrer

https://gerrit.wikimedia.org/r/587730

Change 587731 had a related patch set uploaded (by Arturo Borrero Gonzalez; owner: Arturo Borrero Gonzalez):
[operations/puppet@production] maps block: allow toolforge.org

https://gerrit.wikimedia.org/r/587731

Change 587730 abandoned by Urbanecm:
whitelist ratelimit from requests with toolforge.org referrer

Reason:
dupe

https://gerrit.wikimedia.org/r/587730

Change 587731 abandoned by Arturo Borrero Gonzalez:
maps block: allow toolforge.org

Reason:
Using https://gerrit.wikimedia.org/r/c/operations/puppet/ /587730 instead

https://gerrit.wikimedia.org/r/587731

Change 587730 restored by Urbanecm:
whitelist ratelimit from requests with toolforge.org referrer

https://gerrit.wikimedia.org/r/587730

I made a note on the proposed gerrit patch about adding wmcloud.org to the allow list now too.

Change 587730 merged by CDanis:
[operations/puppet@production] maps: allow requests with toolforge.org and wmcloud.org as referrer

https://gerrit.wikimedia.org/r/587730

bd808 moved this task from Inbox to Doing on the cloud-services-team (Kanban) board.

@Urbanecm Is this all fixed up now or is there more followup needed?

@Urbanecm Is this all fixed up now or is there more followup needed?

I think this is all done!