Fix WikibaseLexeme UnsupportedObjectExceptions in Wikibase CI builds
Closed, ResolvedPublic
Actions

Description

The quibble-vendor-mysql-php72-noselenium-docker job currently produces some MediaWiki errors when run for Wikibase:

2020-04-09 15:50:12 d6590ce0293f wikidb-unittest_: [af39f22aabeec81d24dc8904] [no req] Serializers\Exceptions\UnsupportedObjectException from line 109 of /workspace/src/extensions/WikibaseLexeme/src/Serialization/StorageLexemeSerializer.php: Can not serialize incomplete Lexeme
2020-04-09 15:50:12 d6590ce0293f wikidb-unittest_: [af39f22aabeec81d24dc8904] [no req] Serializers\Exceptions\UnsupportedObjectException from line 109 of /workspace/src/extensions/WikibaseLexeme/src/Serialization/StorageLexemeSerializer.php: Can not serialize incomplete Lexeme
2020-04-09 15:50:13 d6590ce0293f wikidb-unittest_: [af39f22aabeec81d24dc8904] [no req] Serializers\Exceptions\UnsupportedObjectException from line 109 of /workspace/src/extensions/WikibaseLexeme/src/Serialization/StorageLexemeSerializer.php: Can not serialize incomplete Lexeme

Details can be found in the full mw-error.log. That file is supposed to be empty, and the build is supposed to fail if it isn’t (T246358) – but before that can happen, we need to ensure Wikibase CI builds don’t produce MediaWiki server errors.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Revert "Disable exception logger for a test"	mediawiki/extensions/WikibaseLexeme	master	+0 -3
	Disable exception logger for a test	mediawiki/extensions/WikibaseLexeme	master	+3 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Krinkle	T246358 Jenkins no longer fails build if mw-error.log or mw-dberror.log are non-empty
		Resolved		Lucas_Werkmeister_WMDE	T249838 Fix WikibaseLexeme UnsupportedObjectExceptions in Wikibase CI builds

Event Timeline

Lucas_Werkmeister_WMDE created this task.Apr 9 2020, 4:13 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 9 2020, 4:13 PM

Lucas_Werkmeister_WMDE mentioned this in T246358: Jenkins no longer fails build if mw-error.log or mw-dberror.log are non-empty.Apr 9 2020, 4:14 PM

• Pablo-WMDE subscribed.Apr 14 2020, 11:06 AM

WMDE-leszek subscribed.May 14 2020, 7:33 AM

Addshore moved this task from Incoming to Needs Tech Work on the Wikidata-Campsite board.May 18 2020, 9:34 PM

Tarrow subscribed.May 28 2020, 8:16 AM

Marking as high to reflect the parent / blocked ticket

If these tests aren't important, could they be temporarily disabled?

Change 605818 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Disable exception logger for a test

https://gerrit.wikimedia.org/r/605818

gerritbot added a project: Patch-For-Review.Jun 16 2020, 7:26 AM

I looked into this a bit. I can reproduce the error (by putting an echo or similar in StorageLexemeSerializer where the exception is thrown) when AbuseFilter is also installed. The execution happens roughly like this:

the WikibaseLexeme test asks the Wikibase API to save an incomplete Lexeme
the Wikibase API creates the Content and runs the EditFilterMergedContent hook
AbuseFilter gets the text of that Content
WikibaseLexeme throws an error when trying to serialize the incomplete Lexeme (language and/or lexical category missing)
(fuzzy)
the API returns an error
the WikibaseLexeme test asserts that the error looks as expected

The exception thrown by StorageLexemeSerializer is caught and logged in Wikibase’s EntityContentDataCodec::encodeEntity(), but I haven’t yet been able to figure out what’s supposed to happen instead – since it seems that at some point, this test was able to complete without emitting anything to mw-error.log.

That said, the above change seems to fix the issue by completely disabling the “exception” log channel – in the artifacts for that build, I no longer see an mw-error.log file. This might not be the best solution (after all, Wikibase also has tests for EditEntity behavior with bad lexemes, and those tests don’t seem to disable any log channel), but it should be good enough to unblock the parent task, and better than disabling the tests.

Lucas_Werkmeister_WMDE claimed this task.Jun 16 2020, 7:46 AM

Lucas_Werkmeister_WMDE edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.

Lucas_Werkmeister_WMDE moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Jun 16 2020, 8:15 AM

Michael mentioned this in T255566: [LEX] [TECH] Figure out why LexemeEditEntityTest::testGivenInvalidDataInClearRequest_errorIsReported is throwing an Exception/logging an error with AbuseFilter enabled.Jun 16 2020, 2:27 PM

Change 605818 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Disable exception logger for a test

https://gerrit.wikimedia.org/r/605818

Maintenance_bot removed a project: Patch-For-Review.Jun 17 2020, 9:11 AM

Michael moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jun 17 2020, 9:12 AM