Page MenuHomePhabricator

Move service-runner legacy rate limiter into hyperswitch
Closed, DeclinedPublic

Description

The legacy DHT-based rate-limiter, currently available in service-runner, doesn't work in k8s environment and is supposed to be removed once all usages have been eliminated. So far, the only user of the feature is RESTBase. We need to move the feature from service-runner into hyperswithch to stop confusing people.

Also, DHT packages are fairly old and not well supported, so moving the feature will decrease the blast radius in case there is a vulnerability - way less software uses hyper switch then service-runner.

Event Timeline

Pchelolo created this task.Apr 10 2020, 2:45 PM
Restricted Application added projects: Operations, Services. · View Herald TranscriptApr 10 2020, 2:45 PM
Pchelolo triaged this task as Medium priority.Apr 10 2020, 3:11 PM
Pchelolo moved this task from Inbox to Ready on the Platform Team Workboards (Clinic Duty Team) board.
Pchelolo closed this task as Declined.Apr 10 2020, 4:39 PM

Actually, after reviewing the code once more, this doesn't seem to be feasible. rate limiter in service runner needs to know about master/worker relationship, thus it has to reside inside service runner until we can eliminate it