Page MenuHomePhabricator
Create Task
Maniphest T249938

Special:Investigate filter button should be destructive
Closed, ResolvedPublic
Actions

Description

Split out from T249255.

The filter button should have a red icon, and the outline should be red on hover.

See ButtonWidget "destructive" examples at https://doc.wikimedia.org/oojs-ui/master/demos/?page=widgets&theme=wikimediaui&direction=ltr&platform=desktop

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Give filter button on Special:Investigate destructive flagmediawiki/extensions/CheckUsermaster+2 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Tchanders created this task.Apr 10 2020, 5:10 PM
Tchanders added a subtask: T249853: Add 'destructive' funnel icon in OOUI.
Tchanders removed a parent task: T249255: Minor design fixes for Special:Investigate [5*XSmall].
Tchanders mentioned this in T249255: Minor design fixes for Special:Investigate [5*XSmall].Apr 10 2020, 5:12 PM
gerritbot added a comment.Apr 10 2020, 5:22 PM

Change 588020 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/CheckUser@master] Give filter button on Special:Investigate destructive flag

https://gerrit.wikimedia.org/r/588020

gerritbot added a project: Patch-For-Review.Apr 10 2020, 5:22 PM
Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment-Team (The Letter Song) board.Apr 10 2020, 5:24 PM
gerritbot added a comment.Apr 10 2020, 5:47 PM

Change 588020 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Give filter button on Special:Investigate destructive flag

https://gerrit.wikimedia.org/r/588020

Tchanders moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment-Team (The Letter Song) board.Apr 10 2020, 5:49 PM
Tchanders updated the task description. (Show Details)Apr 10 2020, 5:51 PM

@dom_walden This won't look as described in the task until the OOUI version has been updated in mediawiki.

Maintenance_bot removed a project: Patch-For-Review.Apr 10 2020, 6:10 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.28; 2020-04-14).Apr 11 2020, 10:00 AM
• Prtksxna mentioned this in T250051: Buttons in table cells are cluttered and cause a jump on hover.Apr 13 2020, 5:02 AM
Volker_E closed subtask T249853: Add 'destructive' funnel icon in OOUI as Resolved.Apr 15 2020, 5:44 AM
Tchanders closed this task as Resolved.Apr 30 2020, 5:39 PM
Tchanders moved this task from QA/Testing 🐞 to Done: Q4 (2019-20) on the Anti-Harassment-Team (The Letter Song) board.

Moving this on, because it is superseded by T250051: Buttons in table cells are cluttered and cause a jump on hover.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits