Page MenuHomePhabricator
Create Task
Maniphest T250020

Refactor logic for doing and logging unblock out of SpecialUnblock so it can be easily reused elsewhere
Closed, ResolvedPublic
Actions

Description

T248640 is a hot candidate for this class.

Details

SubjectRepoBranchLines +/-
[tests] Remove SpecialUnblock::processUnblock calls in SpecialUnblockTestmediawiki/coremaster+15 -28
Hard deprecate SpecialUnblock::processUnblockmediawiki/coremaster+2 -0
Introduce backend class for unblocking usersmediawiki/coremaster+582 -118
Customize query in gerrit

Related Objects
Search...

Event Timeline

Urbanecm created this task.Apr 11 2020, 10:11 PM
Restricted Application added a project: User-Urbanecm. · View Herald TranscriptApr 11 2020, 10:11 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Urbanecm added a subtask: T248640: Make blockUsers.php script capable of unblocking.Apr 11 2020, 10:11 PM
gerritbot added a comment.Apr 12 2020, 11:39 PM

Change 588104 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/core@master] Introduce backend classes for (un)blocking users

https://gerrit.wikimedia.org/r/588104

gerritbot added a project: Patch-For-Review.Apr 12 2020, 11:39 PM
Urbanecm added a project: Platform Team Workboards (Clinic Duty Team).Apr 12 2020, 11:40 PM
Urbanecm moved this task from Inbox to External Code Review Needed on the Platform Team Workboards (Clinic Duty Team) board.
Urbanecm moved this task from Backlog to Waiting on review on the User-Urbanecm board.
dbarratt added a project: Anti-Harassment.Apr 13 2020, 1:10 PM
Niharika moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment board.Apr 14 2020, 6:14 AM
Niharika edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.Apr 14 2020, 3:38 PM
Niharika moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.
DannyS712 moved this task from Backlog to User blocking on the MediaWiki-User-management board.Apr 16 2020, 7:00 PM
Tchanders mentioned this in T249871: Investigate how to make Special:InvestigateBlock page [8 hours].Apr 17 2020, 12:41 AM
Tchanders mentioned this in T250737: Special:Block should not play the role of a central blocking service/utility.Apr 20 2020, 6:30 PM
daniel moved this task from External Code Review Needed to External Code Review In Progress on the Platform Team Workboards (Clinic Duty Team) board.Apr 21 2020, 9:31 AM
Tchanders mentioned this in T250790: Ensure test coverage for SpecialBlock::processForm and SpecialUnblock::processUnblock is as full as possible.Apr 21 2020, 11:44 AM
Tchanders added a parent task: T250737: Special:Block should not play the role of a central blocking service/utility.Apr 21 2020, 1:58 PM
gerritbot added a comment.Apr 23 2020, 7:35 PM

Change 592287 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/core@master] [WIP] Introduce BlockValidator service for validating block targets

https://gerrit.wikimedia.org/r/592287

gerritbot added a comment.Apr 23 2020, 9:14 PM

Change 592288 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/core@master] WIP: Introduce backend class for unblocking users

https://gerrit.wikimedia.org/r/592288

DannyS712 subscribed.Apr 23 2020, 9:27 PM
DannyS712 edited projects, added MediaWiki-Blocks; removed MediaWiki-User-management.Apr 25 2020, 12:09 AM
Restricted Application added a project: MediaWiki-User-management. · View Herald TranscriptApr 25 2020, 12:09 AM
Aklapper removed a project: MediaWiki-User-management.Apr 25 2020, 12:23 PM
Tchanders added a subtask: T251861: Move SpecialBlock::checkUnblockSelf to a block permissions service.May 5 2020, 8:09 AM
Niharika closed subtask T251861: Move SpecialBlock::checkUnblockSelf to a block permissions service as Resolved.Jul 28 2020, 9:41 PM
CCicalese_WMF removed a project: Platform Team Workboards (Clinic Duty Team).Jul 31 2020, 4:43 PM
CCicalese_WMF subscribed.

It doesn't look like Platform Engineering is currently actively involved in code review for this task. If code review is needed, please feel free to re-tag with Platform Engineering.

Tchanders mentioned this in T261016: Remove unnecessary call to static method on User from UnblockUser::unblockUnsafe.Aug 21 2020, 8:13 PM
gerritbot added a comment.Aug 25 2020, 1:18 PM

Change 592288 merged by jenkins-bot:
[mediawiki/core@master] Introduce backend class for unblocking users

https://gerrit.wikimedia.org/r/592288

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.8; 2020-09-08).Aug 25 2020, 2:00 PM
Tchanders moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (The Letter Song) board.Aug 25 2020, 2:06 PM
dom_walden moved this task from QA/Testing 🐞 to Done: Q1 (2020-21) 💯 on the Anti-Harassment (The Letter Song) board.Aug 28 2020, 2:46 PM
dom_walden subscribed.

Tested unblocking various types of blocks with Special:Unblock and API:Unblock. Checked the database to see that the block (and its restrictions) get removed correctly.

Tested that permissions block, unblockself and hideuser were correctly applied for Special:Unblock and API:Unblock.

The only difference I could see is that previously if you tried to unblock a hidden user without the hideuser right, the error message was: You cannot unblock this user, as their username has been hidden.

After this change, it is: You are not allowed to execute the action you have requested.

Tested some form validation, including trying to unblock a user who wasn't blocked and a non-existent user.

Checked that the unblocking events were correctly recorded in Special:Log.

Test environments:

Tchanders mentioned this in T261761: Restore error message for attempting to unblock a hidden user without the right to do so.Sep 1 2020, 3:45 PM
Tchanders subscribed.

The only difference I could see is that previously if you tried to unblock a hidden user without the hideuser right, the error message was: You cannot unblock this user, as their username has been hidden.

After this change, it is: You are not allowed to execute the action you have requested.

Filed as T261761

gerritbot added a comment.Sep 17 2020, 3:41 PM

Change 628126 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/core@master] Hard deprecate SpecialUnblock::processUnblock

https://gerrit.wikimedia.org/r/628126

gerritbot added a comment.Sep 17 2020, 4:18 PM

Change 628136 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/core@master] [tests] Remove SpecialUnblock::processUnblock calls in SpecialUnblockTest

https://gerrit.wikimedia.org/r/628136

gerritbot added a comment.Sep 20 2020, 8:59 PM

Change 628136 merged by jenkins-bot:
[mediawiki/core@master] [tests] Remove SpecialUnblock::processUnblock calls in SpecialUnblockTest

https://gerrit.wikimedia.org/r/628136

gerritbot added a comment.Sep 20 2020, 8:59 PM

Change 628126 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate SpecialUnblock::processUnblock

https://gerrit.wikimedia.org/r/628126

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.10; 2020-09-22); removed MW-1.36-notes (1.36.0-wmf.8; 2020-09-08).Sep 20 2020, 9:00 PM
Urbanecm closed this task as Resolved.Sep 20 2020, 9:01 PM

Boldly closing, as there shouldn't be anything else to do.

Urbanecm closed subtask T248640: Make blockUsers.php script capable of unblocking as Resolved.Oct 6 2020, 9:23 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits