Page MenuHomePhabricator
Create Task
Maniphest T250040

Update DeprecatedGlobalVariablesSniff re wgVersion deprecation
Closed, ResolvedPublic
Actions

Description

In T212738: Deprecate $wgVersion and move to a constant $wgVersion was deprecated, but DeprecatedGlobalVariablesSniff wasn't updated

Details

SubjectRepoBranchLines +/-
Update DeprecatedGlobalVariablesSniff for deprecation of $wgVersionmediawiki/tools/codesniffermaster+2 -2
Customize query in gerrit

Related Objects

Event Timeline

DannyS712 created this task.Apr 12 2020, 7:47 PM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptApr 12 2020, 7:47 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Apr 12 2020, 7:48 PM

Change 588167 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/tools/codesniffer@master] Update DeprecatedGlobalVariablesSniff for deprecation of $wgVersion

https://gerrit.wikimedia.org/r/588167

gerritbot added a project: Patch-For-Review.Apr 12 2020, 7:48 PM
DannyS712 moved this task from Unsorted to Awaiting review and deployment on the User-DannyS712 board.Apr 12 2020, 7:48 PM
gerritbot added a comment.Apr 20 2020, 5:30 PM

Change 588167 merged by jenkins-bot:
[mediawiki/tools/codesniffer@master] Update DeprecatedGlobalVariablesSniff for deprecation of $wgVersion

https://gerrit.wikimedia.org/r/588167

DannyS712 closed this task as Resolved.Apr 20 2020, 5:30 PM
DannyS712 removed a project: Patch-For-Review.
DannyS712 moved this task from Awaiting review and deployment to Merged on the User-DannyS712 board.May 27 2020, 8:31 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL