Page MenuHomePhabricator
Create Task
Maniphest T250093

Add title attribute to opt-out link
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Description

The newly added opt-out link in the sidebar (T243281) is currently missing a title attribute. Title attributes allow people (and possibly screen readers?) to learn more about a link when hovering over it.

Suggested text: Change your settings to go back to the old look of the skin (legacy Vector)"

QA

  1. Visit https://en.wikipedia.beta.wmflabs.org/wiki/Main_Page?useskinversion=2 while logged in.
  2. Hover cursor over "Switch to old look" link in sidebar
  3. Verify that tooltip appears with text that says "Change your settings to go back to the old look of the skin (legacy Vector)"

QA Results - Beta

ACStatusDetails
1✅T250093#6113774

Details

SubjectRepoBranchLines +/-
Add title attribute to opt-out linkmediawiki/skins/Vectormaster+7 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

• alexhollender_WMF created this task.Apr 13 2020, 4:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 13 2020, 4:00 PM
• alexhollender_WMF mentioned this in T243281: Build opt-out link for logged-in users with new vector on.Apr 13 2020, 4:01 PM
ovasileva triaged this task as High priority.Apr 13 2020, 4:12 PM
ovasileva edited projects, added Web-Team-Backlog (Kanbanana-2019-20-Q4); removed Web-Team-Backlog.
ovasileva updated the task description. (Show Details)
Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-2019-20-Q4) board.Apr 13 2020, 5:03 PM
• Demian added a parent task: T243281: Build opt-out link for logged-in users with new vector on.Apr 13 2020, 5:12 PM
ovasileva set the point value for this task to 2.Apr 13 2020, 5:33 PM
ovasileva moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-2019-20-Q4) board.Apr 14 2020, 12:52 PM
ovasileva moved this task from Incoming to Q4 2020 on the Desktop Improvements (Vector 2022) board.Apr 14 2020, 2:43 PM
Volker_E subscribed.Apr 15 2020, 8:50 PM

I'd propose to use a simpler language, “legacy Vector” is a jargon, that's not clearly translated (translatable) and we already see this in some translations. Maybe add the year?
“Change your settings to go back to the old look of the skin (Vector 2015)"
Or
“Change your settings to go back to the old look of Vector skin"

Edtadros added a project: RW-Feature-DI-Opt-out-Toggle.Apr 21 2020, 10:56 PM
ovasileva subscribed.Apr 28 2020, 4:59 PM
In T250093#6060348, @Volker_E wrote:

I'd propose to use a simpler language, “legacy Vector” is a jargon, that's not clearly translated (translatable) and we already see this in some translations. Maybe add the year?
“Change your settings to go back to the old look of the skin (Vector 2015)"
Or
“Change your settings to go back to the old look of Vector skin"

Legacy vector here since the setting itself is known as "legacy vector" - how about "Suggested text: Change your settings to go back to the old look of the skin (now known as legacy Vector)" - a bit long but it should be fine

• nray claimed this task.May 4 2020, 5:32 PM
• nray moved this task from Ready for Development to Doing on the Web-Team-Backlog (Kanbanana-2019-20-Q4) board.
gerritbot added a comment.May 4 2020, 11:40 PM

Change 594331 had a related patch set uploaded (by Nray; owner: Nray):
[mediawiki/skins/Vector@master] Add title attribute to opt-out link

https://gerrit.wikimedia.org/r/594331

gerritbot added a project: Patch-For-Review.May 4 2020, 11:40 PM
• nray added a comment.May 4 2020, 11:42 PM

The patch for this is ready I'm just not sure I have the right text for the tooltip. @ovasileva @Volker_E did we finalize what the tooltip text should be?

Volker_E added a comment.May 5 2020, 12:11 AM

@nray What you did on the patch is a bit shorter works well for me: “Change your settings to go back to the old look of the skin (legacy Vector)”

Volker_E moved this task from Doing to Needs Code Review on the Web-Team-Backlog (Kanbanana-2019-20-Q4) board.May 5 2020, 3:37 AM
Jdlrobson reassigned this task from • nray to Edtadros.May 5 2020, 5:31 PM
Jdlrobson moved this task from Needs Code Review to Needs QA on the Web-Team-Backlog (Kanbanana-2019-20-Q4) board.
Jdlrobson added a subscriber: • nray.
gerritbot added a comment.May 5 2020, 5:47 PM

Change 594331 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Add title attribute to opt-out link

https://gerrit.wikimedia.org/r/594331

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.32; 2020-05-12).May 5 2020, 6:00 PM
• nray updated the task description. (Show Details)May 5 2020, 6:08 PM
Maintenance_bot removed a project: Patch-For-Review.May 5 2020, 6:10 PM
Edtadros reassigned this task from Edtadros to ovasileva.May 6 2020, 5:42 PM
Edtadros moved this task from Needs QA to Ready for Signoff on the Web-Team-Backlog (Kanbanana-2019-20-Q4) board.
Edtadros subscribed.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Catalina
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA steps

Visit https://en.wikipedia.beta.wmflabs.org/wiki/Main_Page?useskinversion=2 while logged in.
Hover cursor over "Switch to old look" link in sidebar
✅ AC1: Verify that tooltip appears with text that says "Change your settings to go back to the old look of the skin (legacy Vector)"

Screen Shot 2020-05-06 at 10.40.46 AM.png (860×779 px, 273 KB)

Edtadros updated the task description. (Show Details)May 6 2020, 5:43 PM
Volker_E closed this task as Resolved.May 6 2020, 6:23 PM
Volker_E reassigned this task from ovasileva to • nray.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits