Page MenuHomePhabricator

Backward compatibility broken with MediaWiki 1.31 in CommentStreams
Closed, ResolvedPublic

Description

Patch 583190 to CommentStreams converted from use of Revision::getTimestampFromId() to RevisionStore()->getTimestampFromId() with a comment:

Extension requires MW 1.31+, and the RevisionStore service was added in 1.31 and so is always available

However, what the patch failed to take into account is that the signature of RevisionStore()->getTimestampFromId() changed in the interim. The function no longer requires a title as the first parameter in 1.34, but it did in 1.31. So, an additional yet-to-be-determined check will be required to restore backward compatibility.

Pinging @DannyS712 for help determining the appropriate check. Also, if this change was made to other extensions, they made need a fix as well.

Event Timeline

cicalese updated the task description. (Show Details)

Other extensions checked:

  • ArticleFeedbackv5 - requires 1.35 or later, safe
  • FlaggedRevs - requires 1.35 or later, safe
  • MinervaNeue (skin) - requires 1.34 or later, safe

Change 588476 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CommentStreams@master] Change RevisionStore::getTimestampFromId call in MW < 1.34

https://gerrit.wikimedia.org/r/588476

Change 588476 merged by jenkins-bot:
[mediawiki/extensions/CommentStreams@master] Change RevisionStore::getTimestampFromId call in MW < 1.34

https://gerrit.wikimedia.org/r/588476