Page MenuHomePhabricator
Create Task
Maniphest T250171

Custom main page of Translatewiki uses default fonts
Closed, ResolvedPublic
Actions

Description

Somewhere along the line, Translatewiki main page lost a font declaration, which makes it display in serif font (Times New Roman on Windows) for almost everyone. This happens both logged in and logged out.

Screenshot:

image.png (666×1 px, 985 KB)

Previously reported in Support:
https://translatewiki.net/wiki/Thread:Support/Bugs_on_translatewiki.net

Details

SubjectRepoBranchLines +/-
Fix font stylesmediawiki/extensions/TwnMainPagemaster+1 -0
Customize query in gerrit

Related Objects

Event Timeline

stjn created this task.Apr 14 2020, 1:16 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 14 2020, 1:16 PM
Nikerabbit edited projects, added MediaWiki-extensions-TwnMainPage; removed translatewiki.net.Apr 15 2020, 5:00 PM
Nikerabbit subscribed.

I guess the cause is same as T243286: Some visual styles affecting fonts are lost and fix will be same or similar.

Nikerabbit added a comment.Apr 16 2020, 2:13 PM

This was reported on IRC too.

gerritbot added a comment.Apr 16 2020, 2:29 PM

Change 589316 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/TwnMainPage@master] Fix font styles

https://gerrit.wikimedia.org/r/589316

gerritbot added a project: Patch-For-Review.Apr 16 2020, 2:29 PM
Nikerabbit claimed this task.Apr 16 2020, 2:29 PM
Nikerabbit added a project: Language-Team (Language-2020-Focus-Sprint).
Nikerabbit moved this task from Priority Backlog to In Review on the Language-Team (Language-2020-Focus-Sprint) board.
gerritbot added a comment.Apr 17 2020, 9:42 AM

Change 589316 merged by jenkins-bot:
[mediawiki/extensions/TwnMainPage@master] Fix font styles

https://gerrit.wikimedia.org/r/589316

abi_ triaged this task as Medium priority.Apr 17 2020, 10:04 AM
abi_ moved this task from In Review to Recheck after deployment on the Language-Team (Language-2020-Focus-Sprint) board.
Maintenance_bot removed a project: Patch-For-Review.Apr 17 2020, 10:10 AM
Kizule merged a task: T247825: Some visual styles affecting fonts are lost.Apr 17 2020, 12:27 PM
Kizule subscribed.
In T250171#6059629, @Nikerabbit wrote:

I guess the cause is same as T243286: Some visual styles affecting fonts are lost and fix will be same or similar.

@Nikerabbit This task is same as my T243286: Some visual styles affecting fonts are lost, so I closed it as duplicate of this.

Kizule added a comment.Apr 17 2020, 2:35 PM

Ups, wrong task number. I mean on T247825: Some visual styles affecting fonts are lost.

Nikerabbit added a comment.May 7 2020, 8:10 AM

Hmm, I still see Serif fonts on the main page:

image.png (1×1 px, 618 KB)

Nikerabbit moved this task from Recheck after deployment to Done on the Language-Team (Language-2020-Focus-Sprint) board.May 7 2020, 8:12 AM

Ah, I was testing in Timeless, where it is expected (also likely the reason I did not notice this myself). Looks good in Vector:

image.png (1×1 px, 337 KB)

Pginer-WMF closed this task as Resolved.May 7 2020, 1:15 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL