Page MenuHomePhabricator

test.wikidata.org - term store not updating
Closed, ResolvedPublic

Description

In the concrete example, the title of a revision history maintains its outdated title long after the item's label was changed.

Specimen https://test.wikidata.org/w/index.php?title=Q187712&action=history


Related Objects

Event Timeline

This may be due to a problem with "old"(?) cookies in Firefox. These are the ones with which the problem occurs. A Chromium browser opened in parallel shows the correct page

{
  "GeoIP": "DE:BE:Berlin:52.50:13.37:v4",
  "testwikidatawikimwuser-sessionId": "89ebd2bc04a866f80fbe",
  "testwikidatawikiwikibase-entitytermsview-showEntitytermslistview": "true",
  "WMF-Last-Access": "14-Apr-2020",
  "WMF-Last-Access-Global": "14-Apr-2020"
}

headers:

{
  "Response Headers (1.938 KB)": {
    "headers": [
      {
        "name": "accept-ranges",
        "value": "bytes"
      },
      {
        "name": "age",
        "value": "11328"
      },
      {
        "name": "cache-control",
        "value": "private, s-maxage=0, max-age=0, must-revalidate"
      },
      {
        "name": "content-encoding",
        "value": "gzip"
      },
      {
        "name": "content-language",
        "value": "en"
      },
      {
        "name": "content-length",
        "value": "6371"
      },
      {
        "name": "content-security-policy-report-only",
        "value": "script-src 'unsafe-eval' blob: 'self' meta.wikimedia.org *.wikimedia.org *.wikipedia.org *.wikinews.org *.wiktionary.org *.wikibooks.org *.wikiversity.org *.wikisource.org wikisource.org *.wikiquote.org *.wikidata.org *.wikivoyage.org *.mediawiki.org 'unsafe-inline' login.wikimedia.org; default-src 'self' data: blob: upload.wikimedia.org https://commons.wikimedia.org meta.wikimedia.org *.wikimedia.org *.wikipedia.org *.wikinews.org *.wiktionary.org *.wikibooks.org *.wikiversity.org *.wikisource.org wikisource.org *.wikiquote.org *.wikidata.org *.wikivoyage.org *.mediawiki.org wikimedia.org en.wikipedia.org en.wiktionary.org en.wikibooks.org en.wikiquote.org en.wikisource.org commons.wikimedia.org en.wikinews.org en.wikiversity.org www.mediawiki.org www.wikidata.org species.wikimedia.org incubator.wikimedia.org en.wikivoyage.org login.wikimedia.org; style-src 'self' data: blob: upload.wikimedia.org https://commons.wikimedia.org meta.wikimedia.org *.wikimedia.org *.wikipedia.org *.wikinews.org *.wiktionary.org *.wikibooks.org *.wikiversity.org *.wikisource.org wikisource.org *.wikiquote.org *.wikidata.org *.wikivoyage.org *.mediawiki.org wikimedia.org 'unsafe-inline'; object-src 'none'; report-uri /w/api.php?action=cspreport&format=json&reportonly=1"
      },
      {
        "name": "content-type",
        "value": "text/html; charset=UTF-8"
      },
      {
        "name": "date",
        "value": "Tue, 14 Apr 2020 12:13:13 GMT"
      },
      {
        "name": "p3p",
        "value": "CP=\"See https://test.wikidata.org/wiki/Special:CentralAutoLogin/P3P for more info.\""
      },
      {
        "name": "server",
        "value": "mw1372.eqiad.wmnet"
      },
      {
        "name": "server-timing",
        "value": "cache;desc=\"hit-front\""
      },
      {
        "name": "strict-transport-security",
        "value": "max-age=106384710; includeSubDomains; preload"
      },
      {
        "name": "vary",
        "value": "Accept-Encoding,Cookie,Authorization"
      },
      {
        "name": "x-cache",
        "value": "cp3056 miss, cp3062 hit/26"
      },
      {
        "name": "x-cache-status",
        "value": "hit-front"
      },
      {
        "name": "x-client-ip",
        "value": "redacted"
      },
      {
        "name": "x-content-type-options",
        "value": "nosniff"
      },
      {
        "name": "X-Firefox-Spdy",
        "value": "h2"
      }
    ]
  },
  "Request Headers (706 B)": {
    "headers": [
      {
        "name": "Accept",
        "value": "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,*/*;q=0.8"
      },
      {
        "name": "Accept-Encoding",
        "value": "gzip, deflate, br"
      },
      {
        "name": "Accept-Language",
        "value": "en-US,en;q=0.5"
      },
      {
        "name": "Cache-Control",
        "value": "no-cache"
      },
      {
        "name": "Connection",
        "value": "keep-alive"
      },
      {
        "name": "Cookie",
        "value": "testwikidatawikiwikibase-entitytermsview-showEntitytermslistview=true; WMF-Last-Access=14-Apr-2020; WMF-Last-Access-Global=14-Apr-2020; GeoIP=DE:BE:Berlin:52.50:13.37:v4; testwikidatawikimwuser-sessionId=89ebd2bc04a866f80fbe"
      },
      {
        "name": "DNT",
        "value": "1"
      },
      {
        "name": "Host",
        "value": "test.wikidata.org"
      },
      {
        "name": "Pragma",
        "value": "no-cache"
      },
      {
        "name": "Referer",
        "value": "https://test.wikidata.org/w/index.php?title=Q187712&action=history"
      },
      {
        "name": "TE",
        "value": "Trailers"
      },
      {
        "name": "Upgrade-Insecure-Requests",
        "value": "1"
      },
      {
        "name": "User-Agent",
        "value": "Mozilla/5.0 (X11; Linux x86_64; rv:75.0) Gecko/20100101 Firefox/75.0"
      }
    ]
  }
}

Adding wb_terms experts to see if that resonates with them.

The error in logstash is this: https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-deploy-2020.04.15/mediawiki?id=AXF9RUB8Tj5268w_J67D&_g=h@44136fa

This implementation cannot be used with remote entity sources!

I think I know what's going on, let me make a patch.

Oh - I saw those but attributed them to T250183. Same root cause, multiple effects?

Oh - I saw those but attributed them to T250183. Same root cause, multiple effects?

Yup, exact same problem:

First occurrence in Logstash is on 2020-04-08T10:37:49; I don’t see any relevant-looking SAL entries around that time, but 1.35.0-wmf.27 was deployed to group0 the previous evening (2020-04-07, around 20:00, see T247774).

Note that the WikibaseQualityConstraints change to not cache results from federated sources was way back in wmf.20. Maybe wmf.27 contained a Wikibase change that caused testwikidatawiki to report its source database name as "testwikidatawiki" rather than false, though.

and, the codebase:

	private function shouldWriteToItems() : bool {
		return $this->entitySource->getDatabaseName() === false;
	}

Oooooohh! Amazing, I never would’ve expected that :D

Change 589019 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[operations/mediawiki-config@master] Wikibase: Use false instead of database names for "local" entity sources on test wikis

https://gerrit.wikimedia.org/r/589019

Change 589019 merged by jenkins-bot:
[operations/mediawiki-config@master] Wikibase: Use false instead of database names for "local" entity sources on test wikis

https://gerrit.wikimedia.org/r/589019

Fix/band aid (I am still not sure what would be the right tm behaviour) https://gerrit.wikimedia.org/r/589019 helped with the problem, as far as I can tell.

I'm observing a behavior I perceive as intuitive for https://test.wikidata.org/w/index.php?title=Q187712&action=history
@Michael Agree?

Yes, that now behaves as expected, thank you!

It seems that the cache (varnish?) is still slow to update, because curl -v https://test.wikidata.org/wiki/Q187712 still seems to yield an old version from two days ago, but that is probably a different problem and out of scope for this ticket.

Pablo-WMDE claimed this task.
curl -v https://test.wikidata.org/wiki/Q187712|grep -C2 h1
...
< age: 84662
< x-cache: cp3056 hit, cp3050 hit/3
< x-cache-status: hit-front
< server-timing: cache;desc="hit-front"
...
Accessibility Testitem

i.e. rev 528472

I tried the same for Q187713 but could not reproduce it.