- Includes feature to edit an image caption. Leads to the established image caption edit flow.
- Ideally includes the option to edit image tags (if possible)
- Will need to make separate API call for tags
- Image zoomable - no gallery view - same pinch logic as for SE add tags screen
Description
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | scblr | T247993 [EPIC] Suggested edits V5 (enhanced user contribution history) | |||
Resolved | cooltey | T250192 Commons filepage for enhanced user contribs history |
Event Timeline
@cooltey Here is some info to help you along:
Firstly, adding the imagelabels parameter does not actually cause an error, but only a warning.
For example, the following API call works just fine, but notice the "warning" at the top:
In the app we basically ignore this warning. (Otherwise the app wouldn't have worked this whole time)
But this also means that if we actually want to get imagelabels we will need to make a second call to Commons (with the same parameters) to see if the image has labels.
I've made a small PR that lets you determine whether the image exists in Commons or not. If it exists in Commons, we should make a separate call to Commons and use the imagelabels from that response.
Technically I think it's a bug in the API that it doesn't "forward" the imagelabels request to Commons in the first place, but anyway.
Hi @schoenbaechler, I noticed that the text style and section headings are different from the bottom sheet dialog in SE, would it mean that we do not need to keep the consistency with the bottom sheet dialog?
It would be great to keep it consistent @cooltey. So the bottom sheet looks the same as the dedicated file page. Thx!
Hi @schoenbaechler, I noticed that the screen title and the other text size are slightly large than before, not sure if it is an expected design. Please see the screenshot below.
@cooltey, yes this is intended (type hierarchy!), thx for checking back. Could we remove the blue underlines on the links and use a bigger icon for external links? Thx.
@schoenbaechler Thanks for the confirmation and of course we can remove the blue underlines :)
Nice one @cooltey ... the page already looks pretty good in all themes. AND the implementation of our great zoom behavior really shines on the file page.
01) Type hierarchy is suboptimal. Remove “File page” label → Back button is enough...
Check out Zeplin for the specs
02) Increase “File name” label to 16sp
03) Increase file name size to 24sp with 32sp line height
04) Is it possible to strip weird characters like this 👇
Also, meta info like “Credit”, “Photo Date” and “Source” seems redundant as it’s already available in the fields label. Can we remove it?
05) Edit icon is hard to tap, is it at least 48dp x 48dp ?
06) Formatting seems off here. Can we reduce the boldness of these subtitles to “Medium”?
@schoenbaechler
02) Increase “File name” label to 16sp
When I looked at the Zeplin design, I noticed that the other item labels were decreased to 14sp, so I made that change as well.
04) Is it possible to strip weird characters like this 👇
Also, meta info like “Credit”, “Photo Date” and “Source” seems redundant as it’s already available in the fields label. Can we remove it?
I revisited the file page and did not see the issue anymore. However, the content was created by the users and it is not recommended to manipulate it.
06) Formatting seems off here. Can we reduce the boldness of these subtitles to “Medium”?
Same reason as above.
(https://commons.wikimedia.org/wiki/File:Man_en_een_slapende_vrouw_op_een_tuinbank_,_een_ander_paar_kijkt_toe,_RP-F-F09957.jpg)
thx for the clarifications @cooltey ... makes sense. looks good now... moving it to qa signoff.
Hi @ABorbaWMF, We don't have an individual page for adding image tags for a certain file at this time and that's why we don't show edit pencil on the page.
@schoenbaechler and @Charlotte, should we support the option of adding image tags for a certain file?
@cooltey I was going off the screenshot in the description. I'm fine with it either way.
Yes, eventually, but I will file a separate ticket. For now I'll send this to sign-off.