Page MenuHomePhabricator
Create Task
Maniphest T250215

Watchlist Expiry: Display remaining watch period via star [small]
Closed, ResolvedPublic
Actions

Assigned To
Scardenasmolinar
Authored By
ifried
Apr 14 2020, 5:42 PM
Tags
Referenced Files
F31955868: Screen Shot 2020-07-31 at 2.10.47 PM.png
Jul 31 2020, 6:11 PM
F31945603: watchlist_tooltip.png
Jul 23 2020, 9:29 AM
F31770622: tooltip.png
Apr 21 2020, 5:32 PM
F31552963: not watchlisted tooltip.png
Apr 14 2020, 5:42 PM
F31552968: temp watchlisted tooltip.png
Apr 14 2020, 5:42 PM
Subscribers
Aklapper
dom_walden
ifried
• Prtksxna
Samwilson

Description

As a Watchlist Expiry user, I want to be able to identify the expiration date directly on the page, so that I can see the status of the watch period and determine if any modifications must be made.

Acceptance Criteria:

  • Display the remaining watch period via star in the following manner:
    • When user hovers over half star, a tooltip should appear
    • The tooltip text should read: "XX days left. Click to remove this page from your watchlist [ctrl-opt-w]."
    • Include keyboard shortcut
  • Keep remaining tooltip behavior for pages that are watched permanently

Visual Examples:

tooltip.png (300×600 px, 73 KB)

Details

SubjectRepoBranchLines +/-
Display remaining watch period in watchstarmediawiki/coremaster+121 -20
Display remaining watch period in watchstarmediawiki/coreREL1_35+121 -20
Customize query in gerrit

Related Objects

Event Timeline

ifried created this task.Apr 14 2020, 5:42 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 14 2020, 5:42 PM
ifried updated the task description. (Show Details)Apr 14 2020, 5:48 PM
ifried added a project: Expiring-Watchlist-Items.Apr 14 2020, 8:29 PM
ifried updated the task description. (Show Details)
ifried added a subscriber: • Prtksxna.
Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptApr 14 2020, 8:29 PM
ifried updated the task description. (Show Details)Apr 14 2020, 8:30 PM
ARamirez_WMF renamed this task from Watchlist Expiry: Display remaining watch period via star to Watchlist Expiry: Display remaining watch period via star [small].Apr 14 2020, 11:44 PM
ARamirez_WMF moved this task from Needs Discussion to Up Next on the Community-Tech board.
ifried updated the task description. (Show Details)Apr 14 2020, 11:46 PM
ifried moved this task from Up Next to Kanban-2019-20-Q4 on the Community-Tech board.Apr 15 2020, 12:06 AM
ifried edited projects, added Community-Tech (Kanban-2019-20-Q4); removed Community-Tech.
• Prtksxna updated the task description. (Show Details)Apr 21 2020, 5:32 PM
Scardenasmolinar claimed this task.May 4 2020, 10:57 PM
Scardenasmolinar moved this task from Ready to In Development on the Community-Tech (Kanban-2019-20-Q4) board.
Scardenasmolinar added a comment.May 15 2020, 1:42 AM

Question about the number that goes in the message: is it the total number of days a user will be watching the page (e.g. if a user selects 3 months, 90 will be the number always displayed), or the number of days a page has been watched (e.g. if a user temporarily watched a page for 3 months 2 days ago, the number will be 2). Maybe the phrasing of the sentence can be changed for better clarity?

Samwilson subscribed.May 15 2020, 3:13 AM

We're going to have a similar tooltip in Special:Watchlist (T250212), where the phrase is "expires in XX days". Maybe that could be used here too?

ifried updated the task description. (Show Details)May 15 2020, 8:42 PM
ifried updated the task description. (Show Details)May 15 2020, 11:04 PM
gerritbot added a comment.May 18 2020, 8:03 PM

Change 597145 had a related patch set uploaded (by Scardenasmolinar; owner: Scardenasmolinar):
[mediawiki/core@master] Display remaining watch period in watchstar

https://gerrit.wikimedia.org/r/597145

gerritbot added a project: Patch-For-Review.May 18 2020, 8:03 PM
Scardenasmolinar moved this task from In Development to Needs Review/Feedback on the Community-Tech (Kanban-2019-20-Q4) board.May 18 2020, 8:10 PM
ifried added a comment.May 19 2020, 5:29 PM

Note: @Prtksxna and I have discussed the question of language standardization (XX days left vs. Expires in XX days). We want the language to be standardized, clear, translatable, and friendly-sounding (rather than more removed or corporate). For this reason, we're proposing potentially updating the language to be "XX days left in your watchlist." This can be tackled in a separate ticket (T253135). Thanks!

Scardenasmolinar moved this task from Needs Review/Feedback to In Development on the Community-Tech (Kanban-2019-20-Q4) board.May 21 2020, 7:22 PM
Scardenasmolinar moved this task from In Development to Needs Review/Feedback on the Community-Tech (Kanban-2019-20-Q4) board.Jun 22 2020, 11:24 PM
MBinder_WMF edited projects, added Community-Tech (Kanban-2020-21-Q1); removed Community-Tech (Kanban-2019-20-Q4).Jul 14 2020, 7:21 PM
Restricted Application edited projects, added Community-Tech; removed Community-Tech (Kanban-2020-21-Q1). · View Herald TranscriptJul 14 2020, 7:21 PM
MBinder_WMF edited projects, added Community-Tech (Kanban-2020-21-Q1); removed Community-Tech.Jul 14 2020, 7:23 PM
ARamirez_WMF moved this task from Ready 🎬 to Review/Feedback 💬 on the Community-Tech (Kanban-2020-21-Q1) board.Jul 14 2020, 7:26 PM
gerritbot added a comment.Jul 18 2020, 2:48 AM

Change 597145 merged by jenkins-bot:
[mediawiki/core@master] Display remaining watch period in watchstar

https://gerrit.wikimedia.org/r/597145

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.1; 2020-07-21).Jul 18 2020, 3:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jul 18 2020, 3:10 AM
MusikAnimal moved this task from Review/Feedback 💬 to QA 🐛 on the Community-Tech (Kanban-2020-21-Q1) board.Jul 18 2020, 4:07 AM
dom_walden moved this task from QA 🐛 to Product sign-off 🤘🏻 on the Community-Tech (Kanban-2020-21-Q1) board.EditedJul 23 2020, 9:29 AM
dom_walden subscribed.
  • Display the remaining watch period via star in the following manner:
    • When user hovers over half star, a tooltip should appear
    • The tooltip text should read: "XX days left. Click to remove this page from your watchlist [ctrl-opt-w]."
    • Include keyboard shortcut

Yep.

  • Keep remaining tooltip behavior for pages that are watched permanently

Tooltip is:

  • unwatched: Add this page to your watchlist [<shortcut>]
  • permanently watched: Remove this page from your watchlist [<shortcut>]

This change also adds the same tooltip to Special:Watchlist. To enable, go to Special:Preferences, click the "Watchlist" tab, and turn on the preference Add direct unwatch/watch markers (×/+) to watched pages with changes.

Then, temporarily watched pages in Special:Watchlist will have the same tooltip as the watch star when hovering over the unwatch marker.

watchlist_tooltip.png (559×1 px, 67 KB)

I mainly tested on legacy Vector, but briefly looked at Timeless and Monobook.

Test environment: test.wikipedia.org MediaWiki 1.36.0-wmf.1 (rMW652572fd47fb) 18:24, 22 July 2020

FYI: Sometimes the tooltip is not immediately updated after submitting ?action=watch or editing a page. I am guessing for the same reasons as T253937.

gerritbot added a comment.Jul 29 2020, 2:42 AM

Change 616966 had a related patch set uploaded (by Samwilson; owner: Scardenasmolinar):
[mediawiki/core@REL1_35] Display remaining watch period in watchstar

https://gerrit.wikimedia.org/r/616966

gerritbot added a project: Patch-For-Review.Jul 29 2020, 2:42 AM
gerritbot added a comment.Jul 29 2020, 2:59 AM

Change 616966 merged by jenkins-bot:
[mediawiki/core@REL1_35] Display remaining watch period in watchstar

https://gerrit.wikimedia.org/r/616966

ReleaseTaggerBot added a project: MW-1.35-notes.Jul 29 2020, 3:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jul 29 2020, 3:10 AM
ifried closed this task as Resolved.Jul 31 2020, 6:11 PM
ifried moved this task from Product sign-off 🤘🏻 to Done 🏁 on the Community-Tech (Kanban-2020-21-Q1) board.

I have tested, and this behavior is on testwiki (see screenshot example below). For this reason, I am marking it as Done.

Screen Shot 2020-07-31 at 2.10.47 PM.png (82×268 px, 28 KB)

dmaza mentioned this in T257396: Sort out state of Watchlist Expiry for 1.35.Sep 30 2020, 10:32 PM
Krinkle mentioned this in T270141: Watchlist Expiry: Perf follow-up 2020.Dec 14 2020, 11:04 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL