Make BagOStuff key encoding more consistent
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	aaron
	Apr 14 2020, 10:55 PM

Description

Right now I see a few problems:

The default encoding can make things with " " and "_" collide
The proxy classes (ReplicatedBagOStuff, MultiWriteBagOStuff,...) assume that the backing stores use the same key encoding
The proxy classes do not have their keyspace respected (the backend store ones are used)
Checking if a key is global or not should be easy, though there is not enough of a contract to make proper assumptions (this will be useful for "coalesceKeys" in WANObjectCache)

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	objectcache: make BagOStuff key encoding more consistent	mediawiki/core	master	+756 -285

Customize query in gerrit

Event Timeline

aaron created this task.Apr 14 2020, 10:55 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 14 2020, 10:55 PM

Krinkle moved this task from General to libs/objectcache on the MediaWiki-libs-BagOStuff board.Apr 14 2020, 11:15 PM

aaron updated the task description. (Show Details)Apr 15 2020, 1:33 AM

Change 589465 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/core@master] objectcache: make BagOStuff key encoding more consistent

https://gerrit.wikimedia.org/r/589465

gerritbot added a project: Patch-For-Review.Apr 17 2020, 5:38 AM

• Gilles moved this task from Inbox, needs triage to Doing (old) on the Performance-Team board.Apr 20 2020, 11:59 AM

Krinkle triaged this task as Low priority.May 13 2020, 11:49 PM

Krinkle moved this task from Doing (old) to Blocked (old) on the Performance-Team board.

Change 589465 merged by jenkins-bot:
[mediawiki/core@master] objectcache: make BagOStuff key encoding more consistent

https://gerrit.wikimedia.org/r/589465

Maintenance_bot removed a project: Patch-For-Review.Dec 11 2020, 9:10 PM

aaron closed this task as Resolved.Dec 12 2020, 2:17 AM