Page MenuHomePhabricator

History page "Filter revisions" icon obscured by text label on some wikis
Closed, ResolvedPublic

Description

See mai.wikipedia.org for example.

Screenshot 2020-04-15 at 01.52.19.png (341×1 px, 57 KB)
Screenshot 2020-04-15 at 01.52.24.png (407×1 px, 108 KB)

I've noticed this on several other wikis in the past week as well. Presumably it is breakage due to the OOUI conversion conflicting with a common site customsation that various wikis have.

I don't think we need to support this override, but it would be a big help if we e.g. announce in Tech News what site admins can do to unbreak this as it's probably not obvious to them what to do about it, or even to know that it's a bug on their end, given that afaik these sites's aren't (intentionally) customising the filter itself (it's a newly added widget).

Event Timeline

The problem is caused by this code from https://mai.wikipedia.org/wiki/मेडियाविकि:Common.css:

/* Styling for JQuery makeCollapsible, matching that of collapseButton */
.mw-collapsible-toggle {
    font-weight: normal;
    /* @noflip */
    text-align: right;
}

OOUI uses text-indent: -9999px; to hide the text, and text-align: right; means that doesn't work as expected.

That snippet appears to be copied from https://en.wikipedia.org/wiki/MediaWiki:Common.css, where the current version reads:

/* Styling for JQuery makeCollapsible, matching that of collapseButton */
.mw-parser-output .mw-collapsible-toggle {
	font-weight: normal;
	/* @noflip */
	text-align: right;
	padding-right: 0.2em;
	padding-left: 0.2em;
}

Changing the selector to .mw-parser-output .mw-collapsible-toggle avoids the issue. This change was done in 2017 in this edit, unfortunately with no explanation: https://en.wikipedia.org/w/index.php?title=mediawiki%3ACommon.css&diff=prev&oldid=785569552

Actually here's a discussion related to that edit, the rule was apparently also causing problems with enhanced RC: https://en.wikipedia.org/w/index.php?title=MediaWiki_talk:Common.css&oldid=785569933#Mw-collapsible_change

I've fixed the issue across all wikis (hopefully).

I used the following script that I wrote, and copy-pasted into browser console on mediawiki.org. It edits other wikis using mw.ForeignApi and the results from https://global-search.toolforge.org/?q="mw-collapsible-toggle"&namespaces=8&title=%28Gadgets-definition%7C.*%5C.%28css%29%29.

I made the following edits: (per https://guc.toolforge.org/?src=hr&by=date&user=Matma+Rex)

  1. https://af.wiktionary.org/w/index.php?title=MediaWiki:Common.css&diff=prev&oldid=211327
  2. https://af.wiktionary.org/w/index.php?title=MediaWiki:Common.css&diff=prev&oldid=211328
  3. https://ar.wikipedia.org/w/index.php?title=%D9%85%D9%8A%D8%AF%D9%8A%D8%A7%D9%88%D9%8A%D9%83%D9%8A:Navbox.css&diff=prev&oldid=54210506
  4. https://ar.wikiquote.org/w/index.php?title=%D9%85%D9%8A%D8%AF%D9%8A%D8%A7%D9%88%D9%8A%D9%83%D9%8A:Navbox.css&diff=prev&oldid=178295
  5. https://af.wiktionary.org/w/index.php?title=MediaWiki:Common.css&diff=prev&oldid=211329
  6. https://as.wikipedia.org/w/index.php?title=%E0%A6%AE%E0%A6%BF%E0%A6%A1%E0%A6%BF%E0%A6%AF%E0%A6%BC%E0%A6%BE%E0%A7%B1%E0%A6%BF%E0%A6%95%E0%A6%BF:Common.css&diff=prev&oldid=283045
  7. https://as.wikisource.org/w/index.php?title=%E0%A6%AE%E0%A6%BF%E0%A6%A1%E0%A6%BF%E0%A6%AF%E0%A6%BC%E0%A6%BE%E0%A7%B1%E0%A6%BF%E0%A6%95%E0%A6%BF:Common.css/Boxes.css&diff=prev&oldid=120401
  8. https://az.wiktionary.org/w/index.php?title=MediaViki:Common.css&diff=prev&oldid=364007
  9. https://bcl.wikipedia.org/w/index.php?title=MediaWiki:Common.css&diff=prev&oldid=207643
  10. https://be-tarask.wikipedia.org/w/index.php?title=MediaWiki:Common.css&diff=prev&oldid=2229856
  11. https://beta.wikiversity.org/w/index.php?title=MediaWiki:Common.css/Navigation_templates.css&diff=prev&oldid=339307
  12. https://bg.wikipedia.org/w/index.php?title=%D0%9C%D0%B5%D0%B4%D0%B8%D1%8F%D0%A3%D0%B8%D0%BA%D0%B8:Common.css&diff=prev&oldid=11034235
  13. https://bjn.wikipedia.org/w/index.php?title=MediaWiki:Common.css&diff=prev&oldid=71616
  14. https://bxr.wikipedia.org/w/index.php?title=MediaWiki:Common.css&diff=prev&oldid=56898
  15. https://ceb.wikipedia.org/w/index.php?title=MediaWiki:Common.css&diff=prev&oldid=31895465
  16. https://cy.wikipedia.org/w/index.php?title=MediaWici:Common.css&diff=prev&oldid=10947932
  17. https://de.wikivoyage.org/w/index.php?title=MediaWiki:Mobile.css&diff=prev&oldid=1391331
  18. https://dv.wiktionary.org/w/index.php?title=%DE%89%DE%A9%DE%91%DE%A8%DE%87%DE%A7%DE%88%DE%A8%DE%86%DE%A9:Common.css&diff=prev&oldid=8950
  19. https://fo.wikipedia.org/w/index.php?title=MediaWiki:Common.css&diff=prev&oldid=365411
  20. https://gl.wikiquote.org/w/index.php?title=MediaWiki:Common.css&diff=prev&oldid=21493
  21. https://gl.wikisource.org/w/index.php?title=MediaWiki:Common.css&diff=prev&oldid=20843
  22. https://gom.wikipedia.org/w/index.php?title=%E0%A4%AE%E0%A4%BF%E0%A4%A1%E0%A4%BF%E0%A4%AF%E0%A4%BE%E0%A4%B5%E0%A4%BF%E0%A4%95%E0%A5%80:Common.css&diff=prev&oldid=205213
  23. https://gor.wikipedia.org/w/index.php?title=MediaWiki:Common.css&diff=prev&oldid=45581
  24. https://gu.wikipedia.org/w/index.php?title=%E0%AA%AE%E0%AB%80%E0%AA%A1%E0%AA%BF%E0%AA%AF%E0%AA%BE%E0%AA%B5%E0%AA%BF%E0%AA%95%E0%AA%BF:Common.css&diff=prev&oldid=772683
  25. https://gu.wikiquote.org/w/index.php?title=%E0%AA%AE%E0%AB%80%E0%AA%A1%E0%AA%BF%E0%AA%AF%E0%AA%BE%E0%AA%B5%E0%AA%BF%E0%AA%95%E0%AA%BF:Common.css&diff=prev&oldid=17782
  26. https://gu.wikisource.org/w/index.php?title=%E0%AA%AE%E0%AB%80%E0%AA%A1%E0%AA%BF%E0%AA%AF%E0%AA%BE%E0%AA%B5%E0%AA%BF%E0%AA%95%E0%AA%BF:Common.css/Boxes.css&diff=prev&oldid=150759
  27. https://hi.wikipedia.org/w/index.php?title=%E0%A4%AE%E0%A5%80%E0%A4%A1%E0%A4%BF%E0%A4%AF%E0%A4%BE%E0%A4%B5%E0%A4%BF%E0%A4%95%E0%A4%BF:Common.css&diff=prev&oldid=5226190
  28. https://hi.wikiquote.org/w/index.php?title=%E0%A4%AE%E0%A5%80%E0%A4%A1%E0%A4%BF%E0%A4%AF%E0%A4%BE%E0%A4%B5%E0%A4%BF%E0%A4%95%E0%A4%BF:Common.css&diff=prev&oldid=22375
  29. https://ia.wikipedia.org/w/index.php?title=MediaWiki:Common.css&diff=prev&oldid=639371
  30. https://id.wikipedia.org/w/index.php?title=MediaWiki:Common.css&diff=prev&oldid=18539390
  31. https://id.wikibooks.org/w/index.php?title=MediaWiki:Common.css&diff=prev&oldid=77971
  32. https://id.wiktionary.org/w/index.php?title=MediaWiki:Common.css&diff=prev&oldid=970689
  33. https://incubator.wikimedia.org/w/index.php?title=MediaWiki:Wp/ksw/Common.css&diff=prev&oldid=5161341
  34. https://incubator.wikimedia.org/w/index.php?title=MediaWiki:Wp/kjp/Common.css&diff=prev&oldid=5161342
  35. https://io.wikipedia.org/w/index.php?title=MediaWiki:Common.css&diff=prev&oldid=970584
  36. https://is.wikipedia.org/w/index.php?title=Melding:Common.css&diff=prev&oldid=1722805
  37. https://kab.wikipedia.org/w/index.php?title=MediaWiki:Common.css&diff=prev&oldid=104111
  38. https://km.wikipedia.org/w/index.php?title=%E1%9E%98%E1%9F%81%E1%9E%8C%E1%9E%B6%E1%9E%9C%E1%9E%B7%E1%9E%82%E1%9E%B8:Common.css&diff=prev&oldid=258714
  39. https://mai.wikipedia.org/w/index.php?title=%E0%A4%AE%E0%A5%87%E0%A4%A1%E0%A4%BF%E0%A4%AF%E0%A4%BE%E0%A4%B5%E0%A4%BF%E0%A4%95%E0%A4%BF:Common.css&diff=prev&oldid=228827
  40. https://min.wikipedia.org/w/index.php?title=MediaWiki:Common.css&diff=prev&oldid=2056233
  41. https://mi.wikipedia.org/w/index.php?title=MediaWiki:Common.css&diff=prev&oldid=151150
  42. https://mk.wikipedia.org/w/index.php?title=%D0%9C%D0%B5%D0%B4%D0%B8%D1%98%D0%B0%D0%92%D0%B8%D0%BA%D0%B8:Common.css&diff=prev&oldid=4548955
  43. https://ml.wikipedia.org/w/index.php?title=%E0%B4%AE%E0%B5%80%E0%B4%A1%E0%B4%BF%E0%B4%AF%E0%B4%B5%E0%B4%BF%E0%B4%95%E0%B5%8D%E0%B4%95%E0%B4%BF:Common.css&diff=prev&oldid=3590404
  44. https://ml.wikiquote.org/w/index.php?title=%E0%B4%AE%E0%B5%80%E0%B4%A1%E0%B4%BF%E0%B4%AF%E0%B4%B5%E0%B4%BF%E0%B4%95%E0%B5%8D%E0%B4%95%E0%B4%BF:Common.css&diff=prev&oldid=21384
  45. https://mnw.wikipedia.org/w/index.php?title=%E1%80%99%E1%80%B3%E1%80%92%E1%80%B3%E1%80%9A%E1%80%AC%E1%80%9D%E1%80%B3%E1%80%80%E1%80%B3:Common.css&diff=prev&oldid=28979
  46. https://mr.wikisource.org/w/index.php?title=%E0%A4%AE%E0%A4%BF%E0%A4%A1%E0%A4%BF%E0%A4%AF%E0%A4%BE%E0%A4%B5%E0%A4%BF%E0%A4%95%E0%A5%80:Common.css&diff=prev&oldid=125848
  47. https://mwl.wikipedia.org/w/index.php?title=Biqui:Common.css&diff=prev&oldid=98123
  48. https://ne.wikipedia.org/w/index.php?title=%E0%A4%AE%E0%A5%80%E0%A4%A1%E0%A4%BF%E0%A4%AF%E0%A4%BE%E0%A4%B5%E0%A4%BF%E0%A4%95%E0%A4%BF:Common.css&diff=prev&oldid=1019810
  49. https://new.wikipedia.org/w/index.php?title=%E0%A4%AE%E0%A4%BF%E0%A4%A1%E0%A4%BF%E0%A4%AF%E0%A4%BE%E0%A4%B5%E0%A4%BF%E0%A4%95%E0%A4%BF:Common.css&diff=prev&oldid=848609
  50. https://nia.wikipedia.org/w/index.php?title=MediaWiki:Common.css&diff=prev&oldid=11214
  51. https://nn.wikipedia.org/w/index.php?title=MediaWiki:Common.css&diff=prev&oldid=3316307
  52. https://or.wikipedia.org/w/index.php?title=%E0%AC%AE%E0%AC%BF%E0%AC%A1%E0%AC%BC%E0%AC%BF%E0%AC%86%E0%AC%89%E0%AC%87%E0%AC%95%E0%AC%BF:Common.css&diff=prev&oldid=430202
  53. https://pam.wikipedia.org/w/index.php?title=MediaWiki:Common.css&diff=prev&oldid=295096
  54. https://pa.wikipedia.org/w/index.php?title=%E0%A8%AE%E0%A9%80%E0%A8%A1%E0%A9%80%E0%A8%86%E0%A8%B5%E0%A8%BF%E0%A8%95%E0%A9%80:Common.css&diff=prev&oldid=567487
  55. https://pnb.wikipedia.org/w/index.php?title=%D9%85%DB%8C%DA%88%DB%8C%D8%A7_%D9%88%DA%A9%DB%8C:Common.css&diff=prev&oldid=590294
  56. https://pt.wikisource.org/w/index.php?title=MediaWiki:Gadget-Site.css&diff=prev&oldid=457844
  57. https://sa.wikisource.org/w/index.php?title=%E0%A4%AE%E0%A5%80%E0%A4%A1%E0%A4%BF%E0%A4%AF%E0%A4%BE%E0%A4%B5%E0%A4%BF%E0%A4%95%E0%A4%BF:Common.css&diff=prev&oldid=312795
  58. https://sd.wikipedia.org/w/index.php?title=%D8%B0%D8%B1%D9%8A%D8%B9%D8%A7%D8%AA_%D9%88%DA%AA%D9%8A:Common.css&diff=prev&oldid=223436
  59. https://sh.wikipedia.org/w/index.php?title=MediaWiki:Common.css&diff=prev&oldid=41061371
  60. https://si.wikipedia.org/w/index.php?title=%E0%B6%B8%E0%B7%8F%E0%B6%B0%E0%B7%8A%E2%80%8D%E0%B6%BA%E0%B7%80%E0%B7%92%E0%B6%9A%E0%B7%92:Common.css&diff=prev&oldid=484930
  61. https://sl.wikiquote.org/w/index.php?title=MediaWiki:Common.css&diff=prev&oldid=41506
  62. https://sl.wikisource.org/w/index.php?title=MediaWiki:Common.css&diff=prev&oldid=200848
  63. https://so.wikipedia.org/w/index.php?title=MediaWiki:Common.css&diff=prev&oldid=212628
  64. https://su.wikipedia.org/w/index.php?title=M%C3%A9diaWiki:Common.css&diff=prev&oldid=615444
  65. https://su.wikiquote.org/w/index.php?title=M%C3%A9diaWiki:Common.css&diff=prev&oldid=9671
  66. https://su.wiktionary.org/w/index.php?title=M%C3%A9diaWiki:Common.css&diff=prev&oldid=14396
  67. https://sw.wikipedia.org/w/index.php?title=MediaWiki:Common.css&diff=prev&oldid=1174641
  68. https://ta.wikipedia.org/w/index.php?title=%E0%AE%AE%E0%AF%80%E0%AE%9F%E0%AE%BF%E0%AE%AF%E0%AE%BE%E0%AE%B5%E0%AE%BF%E0%AE%95%E0%AF%8D%E0%AE%95%E0%AE%BF:Common.css&diff=prev&oldid=3175912
  69. https://ta.wikisource.org/w/index.php?title=%E0%AE%AE%E0%AF%80%E0%AE%9F%E0%AE%BF%E0%AE%AF%E0%AE%BE%E0%AE%B5%E0%AE%BF%E0%AE%95%E0%AF%8D%E0%AE%95%E0%AE%BF:Common.css/Boxes.css&diff=prev&oldid=1323555
  70. https://tcy.wikipedia.org/w/index.php?title=%E0%B2%AE%E0%B2%BE%E0%B2%A6%E0%B3%8D%E0%B2%AF%E0%B2%AE%E0%B3%8A_%E0%B2%B5%E0%B2%BF%E0%B2%95%E0%B2%BF:Common.css&diff=prev&oldid=136469
  71. https://test.wikidata.org/w/index.php?title=MediaWiki:Common.css&diff=prev&oldid=541610
  72. https://th.wikipedia.org/w/index.php?title=%E0%B8%A1%E0%B8%B5%E0%B9%80%E0%B8%94%E0%B8%B5%E0%B8%A2%E0%B8%A7%E0%B8%B4%E0%B8%81%E0%B8%B4:Common.css/navbox.css&diff=prev&oldid=9471622
  73. https://th.wikipedia.org/w/index.php?title=%E0%B8%A1%E0%B8%B5%E0%B9%80%E0%B8%94%E0%B8%B5%E0%B8%A2%E0%B8%A7%E0%B8%B4%E0%B8%81%E0%B8%B4:Common.css&diff=prev&oldid=9471623
  74. https://tl.wikipedia.org/w/index.php?title=MediaWiki:Common.css&diff=prev&oldid=1867211
  75. https://tpi.wikipedia.org/w/index.php?title=MediaWiki:Common.css&diff=prev&oldid=85738
  76. https://tr.wikibooks.org/w/index.php?title=MediaWiki:Common.css&diff=prev&oldid=52081
  77. https://ts.wikipedia.org/w/index.php?title=MediaWiki:Common.css&diff=prev&oldid=36152
  78. https://uk.wikisource.org/w/index.php?title=MediaWiki:Common.css&diff=prev&oldid=366201
  79. https://ur.wikibooks.org/w/index.php?title=%D9%85%DB%8C%DA%88%DB%8C%D8%A7%D9%88%DB%8C%DA%A9%DB%8C:Common.css&diff=prev&oldid=8739
  80. https://ur.wikiquote.org/w/index.php?title=%D9%85%DB%8C%DA%88%DB%8C%D8%A7%D9%88%DB%8C%DA%A9%DB%8C:Common.css&diff=prev&oldid=11303
  81. https://uz.wikipedia.org/w/index.php?title=MediaWiki:Common.css&diff=prev&oldid=2196796
  82. https://vi.wikiquote.org/w/index.php?title=MediaWiki:Common.css&diff=prev&oldid=52574
  83. https://vi.wiktionary.org/w/index.php?title=MediaWiki:Common.css&diff=prev&oldid=2017310
  84. https://war.wikipedia.org/w/index.php?title=MedyaWiki:Common.css&diff=prev&oldid=6283306
  85. https://xh.wikipedia.org/w/index.php?title=MediaWiki:Common.css&diff=prev&oldid=32760
  86. https://yo.wikipedia.org/w/index.php?title=MediaWiki:Common.css&diff=prev&oldid=545106
  87. https://zh-min-nan.wikipedia.org/w/index.php?title=MediaWiki:Common.css&diff=prev&oldid=3096536
  88. https://zu.wikipedia.org/w/index.php?title=MediaWiki:Common.css&diff=prev&oldid=86939
matmarex claimed this task.
matmarex updated the task description. (Show Details)