Page MenuHomePhabricator

Investigate CiteThisPage's use of untidy parser output
Closed, ResolvedPublic

Description

The CiteThisPage extension contains a TODO commend and attempts to explicitly turn off tidy:
https://gerrit.wikimedia.org/g/mediawiki/extensions/CiteThisPage/+/d26be29cbbb4e3e3a873a28267ee2ca25798474a/includes/SpecialCiteThisPage.php#171

This should have been generating hard-deprecation warnings in the logs since 1.33:
https://gerrit.wikimedia.org/g/mediawiki/core/+/c4305332d7aebe95c4a32e64d875d19ef7180128/includes/parser/ParserOptions.php#307

It's possible the wrapping issues discussed were fixed by the Remex tidy migration. But this should be investigated, since setTidy(false) was made a no-op in
83a22b7fcde35954461356d4e3859647f45f9cba.

Event Timeline

cscott created this task.Apr 15 2020, 6:30 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 15 2020, 6:30 PM

Change 589142 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/CiteThisPage@master] Remove ParserOptions::setTidy(false), deprecated in MW 1.33

https://gerrit.wikimedia.org/r/589142

Change 589142 merged by jenkins-bot:
[mediawiki/extensions/CiteThisPage@master] Remove ParserOptions::setTidy(false), deprecated in MW 1.33

https://gerrit.wikimedia.org/r/589142

cscott closed this task as Resolved.Apr 16 2020, 12:20 AM
cscott claimed this task.

There were some anomalous <p> tags around <citation> when tidy was enabled.

The above patch seems to have fixed the rendering issues, at least on https://en.wikipedia.beta.wmflabs.org/wiki/Special:CiteThisPage?page=Main+Page&wpFormIdentifier=titleform

I'm going to resolve for now; I'll reopen if other rendering issues turn up.