Page MenuHomePhabricator

Investigate CiteThisPage's use of untidy parser output
Closed, ResolvedPublic


The CiteThisPage extension contains a TODO commend and attempts to explicitly turn off tidy:

This should have been generating hard-deprecation warnings in the logs since 1.33:

It's possible the wrapping issues discussed were fixed by the Remex tidy migration. But this should be investigated, since setTidy(false) was made a no-op in

Event Timeline

cscott created this task.Apr 15 2020, 6:30 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 15 2020, 6:30 PM

Change 589142 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/CiteThisPage@master] Remove ParserOptions::setTidy(false), deprecated in MW 1.33

Change 589142 merged by jenkins-bot:
[mediawiki/extensions/CiteThisPage@master] Remove ParserOptions::setTidy(false), deprecated in MW 1.33

cscott closed this task as Resolved.Apr 16 2020, 12:20 AM
cscott claimed this task.

There were some anomalous <p> tags around <citation> when tidy was enabled.

The above patch seems to have fixed the rendering issues, at least on

I'm going to resolve for now; I'll reopen if other rendering issues turn up.