Investigate CiteThisPage's use of untidy parser output
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	cscott
	Apr 15 2020, 6:30 PM

Description

The CiteThisPage extension contains a TODO commend and attempts to explicitly turn off tidy:
https://gerrit.wikimedia.org/g/mediawiki/extensions/CiteThisPage/+/d26be29cbbb4e3e3a873a28267ee2ca25798474a/includes/SpecialCiteThisPage.php#171

This should have been generating hard-deprecation warnings in the logs since 1.33:
https://gerrit.wikimedia.org/g/mediawiki/core/+/c4305332d7aebe95c4a32e64d875d19ef7180128/includes/parser/ParserOptions.php#307

It's possible the wrapping issues discussed were fixed by the Remex tidy migration. But this should be investigated, since setTidy(false) was made a no-op in
83a22b7fcde35954461356d4e3859647f45f9cba.

Details

	Subject	Repo	Branch	Lines +/-
	Remove `ParserOptions::setTidy(false)`, deprecated in MW 1.33	mediawiki/extensions/CiteThisPage	master	+3 -8

Customize query in gerrit

Related Objects

Mentioned In: T250807: Dates in citations on Special:CiteThisPage are in <p> and hence create unneeded and ugly linebreaks
Mentioned Here: rMW83a22b7fcde3: Remove codepaths which ran parser in 'untidy' mode

Event Timeline

cscott created this task.Apr 15 2020, 6:30 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 15 2020, 6:30 PM

Change 589142 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/CiteThisPage@master] Remove ParserOptions::setTidy(false), deprecated in MW 1.33

https://gerrit.wikimedia.org/r/589142

gerritbot added a project: Patch-For-Review.Apr 15 2020, 9:58 PM

Change 589142 merged by jenkins-bot:
[mediawiki/extensions/CiteThisPage@master] Remove ParserOptions::setTidy(false), deprecated in MW 1.33

https://gerrit.wikimedia.org/r/589142

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.30; 2020-04-28).Apr 15 2020, 11:00 PM

Maintenance_bot removed a project: Patch-For-Review.Apr 15 2020, 11:10 PM