Page MenuHomePhabricator

Deprecate global function wfIncrStats
Open, Needs TriagePublic

Description

The global function wfIncrStats could go through the deprecation process.

  • Needs soft deprecation
  • one release later hard deprecation
  • and removed a release later

Event Timeline

DannyS712 added a subscriber: DannyS712.

@Umherirrender the method is still in use:
Core:

  • DifferenceEngine
  • WikiPage
  • ParserCache

Extensions:

  • MobileFrontend - MobileContext
  • MobileFrontend - ApiMobileView
  • DumpHTML
  • FanBoxes
  • ParsoidBatchAPI - ApiParsoidBatch
  • Video

What is the reason for the deprecation and removal?

The global function is only a proxy to a service. The service should be used directly

I have uploaded patches for replacement:
https://gerrit.wikimedia.org/r/#/q/status:open+branch:master+topic:statsddata

The only remaining use is in ParsoidBatchAPI which may be archived sometimes in the future (T252744). I'll upload a patch to soft deprecate.

Change 652404 had a related patch set uploaded (by Majavah; owner: Majavah):
[mediawiki/core@master] Soft deprecate wfIncrStats()

https://gerrit.wikimedia.org/r/652404

Change 652404 merged by jenkins-bot:
[mediawiki/core@master] Soft deprecate wfIncrStats()

https://gerrit.wikimedia.org/r/652404

Change 678400 had a related patch set uploaded (by Majavah; author: Majavah):

[mediawiki/core@master] Hard deprecate wfIncrStats

https://gerrit.wikimedia.org/r/678400

Change 678400 merged by jenkins-bot:

[mediawiki/core@master] Hard deprecate wfIncrStats

https://gerrit.wikimedia.org/r/678400