Page MenuHomePhabricator
Create Task
Maniphest T250316

Deprecate global function wfIncrStats
Open, Needs TriagePublic
Actions

Description

The global function wfIncrStats could go through the deprecation process.

  • Needs soft deprecation
  • one release later hard deprecation
  • and removed a release later

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+5 -1Hard deprecate wfIncrStats
mediawiki/coremaster+4 -0Soft deprecate wfIncrStats()
Customize query in gerrit

Related Objects

Event Timeline

Umherirrender created this task.Apr 15 2020, 7:48 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 15 2020, 7:48 PM
DannyS712 moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.Apr 15 2020, 7:57 PM
DannyS712 added a subscriber: DannyS712.

@Umherirrender the method is still in use:
Core:

  • DifferenceEngine
  • WikiPage
  • ParserCache

Extensions:

  • MobileFrontend - MobileContext
  • MobileFrontend - ApiMobileView
  • DumpHTML
  • FanBoxes
  • ParsoidBatchAPI - ApiParsoidBatch
  • Video

What is the reason for the deprecation and removal?

Umherirrender added a comment.Apr 15 2020, 8:32 PM

The global function is only a proxy to a service. The service should be used directly

I have uploaded patches for replacement:
https://gerrit.wikimedia.org/r/#/q/status:open+branch:master+topic:statsddata

Majavah added a subscriber: Majavah.Dec 29 2020, 2:15 PM

The only remaining use is in ParsoidBatchAPI which may be archived sometimes in the future (T252744). I'll upload a patch to soft deprecate.

gerritbot added a comment.Dec 29 2020, 2:15 PM

Change 652404 had a related patch set uploaded (by Majavah; owner: Majavah):
[mediawiki/core@master] Soft deprecate wfIncrStats()

https://gerrit.wikimedia.org/r/652404

gerritbot added a project: Patch-For-Review.Dec 29 2020, 2:15 PM
Majavah merged a task: T264977: Consider removing wfIncrStats.Dec 29 2020, 5:12 PM
gerritbot added a comment.Dec 30 2020, 4:15 PM

Change 652404 merged by jenkins-bot:
[mediawiki/core@master] Soft deprecate wfIncrStats()

https://gerrit.wikimedia.org/r/652404

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.25; 2021-01-05).Dec 30 2020, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 30 2020, 5:10 PM
Majavah claimed this task.Jan 2 2021, 9:06 AM
Restricted Application added a project: User-Majavah. · View Herald TranscriptJan 2 2021, 9:06 AM
Majavah moved this task from Unsorted to Blocked on release cycle on the User-Majavah board.Jan 2 2021, 9:06 AM
Majavah updated the task description. (Show Details)
Majavah moved this task from 2020 | MW 1.35 to 2021 | MW 1.36 / 1.37 on the Technical-Debt (Deprecation process) board.Jan 16 2021, 8:11 PM
gerritbot added a comment.Sun, Apr 11, 3:56 PM

Change 678400 had a related patch set uploaded (by Majavah; author: Majavah):

[mediawiki/core@master] Hard deprecate wfIncrStats

https://gerrit.wikimedia.org/r/678400

gerritbot added a project: Patch-For-Review.Sun, Apr 11, 3:56 PM
gerritbot added a comment.Tue, Apr 20, 6:32 PM

Change 678400 merged by jenkins-bot:

[mediawiki/core@master] Hard deprecate wfIncrStats

https://gerrit.wikimedia.org/r/678400

Majavah updated the task description. (Show Details)Tue, Apr 20, 6:35 PM
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Tue, Apr 20, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Tue, Apr 20, 7:10 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL