Page MenuHomePhabricator

Flow OOUI icons not appearing on mobile domain
Closed, ResolvedPublic

Description

listBullet (standard OOUI) and newestTopics (Flow extension) icons are missing.
URL: Mobile Minerva
URL 2: Mobile Vector

Event Timeline

Volker_E created this task.Apr 15 2020, 9:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 15 2020, 9:03 PM

Where is listBullet added in Flow? https://github.com/wikimedia/mediawiki-extensions-Flow/search?q=listBullet&unscoped_q=listBullet
My guess is it's using a module defined elsewhere when is not setting targets on its ResourceLoaderModule.

Restricted Application added a project: Growth-Team. · View Herald TranscriptApr 15 2020, 10:05 PM
Jdlrobson renamed this task from MF/MN miss Flow OOUI icons to Flow OOUI icons not appearing on mobile domain.Apr 15 2020, 10:06 PM
Jdlrobson updated the task description. (Show Details)
Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptApr 15 2020, 10:06 PM

After looking at this some more targets is indirectly the problem since VisualEditor loads different code on mobile and Flow is making assumptions about those being present.

The following dependencies need to be made explicit:

mw.loader.using(['ext.flow.visualEditor.icons', 'oojs-ui.styles.icons-editing-list' ]);

Change 589169 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/Flow@master] Add appropriate icon dependencies for mobile

https://gerrit.wikimedia.org/r/589169

kostajh moved this task from Incoming to Code Review on the Growth-Team (Current Sprint) board.
kostajh moved this task from Code Review to QA on the Growth-Team (Current Sprint) board.

Change 589169 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Add appropriate icon dependencies for mobile

https://gerrit.wikimedia.org/r/589169

Etonkovidova closed this task as Resolved.Apr 20 2020, 9:17 PM
Etonkovidova claimed this task.
Etonkovidova added a subscriber: Etonkovidova.

Checked in betalabs - the icons are in place. Added the task to the list to be checked after deployment.

Volker_E claimed this task.Apr 20 2020, 9:48 PM
Volker_E removed a project: Patch-For-Review.