Page MenuHomePhabricator

Show aliases in username completion list
Open, Needs TriagePublic

Description

T232601 implemented the fundamental components that make in-surface autocomplete [for @ mentioning] possible.

This task is about building off that work to make the username completion list [1] work in the following ways described in "Expected behavior."

Expected behavior

When someone types @, they will see...

  • The username completion list, populated with the usernames of the people who have already commented anywhere on the talk page they are viewing.
  • The usernames in the completion list will be sorted alphabetically.
  • The usernames shown in the username completion list will appear in the username results list exactly as they appear on the page. Meaning, if someone has a custom signature such that the username that is appended to the comments they post on talk pages [2] is different from the username that appears in the link to their user page [3], their alias will show up in the username results list.

When someone selects an alias from the username completion list, they can expect the following to happen:

  • The Reply text input will show @ + alias (read: the same as what is shown in the username completion list).

When someone publishes a comment containing a ping to someone with an alias set, they can expect the following to happen:

  • A ping will be sent in the same way it would be to a person who does not have an alias set.

Open questions

  • For people who have aliases set, is it customary for people wanting to @-mention them to refer to them by alias or by their registered username?
  • What if a custom signature and a real username collide?
  • What if multiple people on a page have the same alias?
  • Will it confuse the user if they pick @alias in the dropdown and what's output in the wikitext is [[User:RealName]]?
  • Do we indicate alias-status in the completion dropdown?
  • Will it confuse the user that completion of some names only works on some pages for inscrutable reasons?
  • Do we assume everything that links to a user-page is intended as an alias?

Done

  • The "Open questions" have been answered
  • The functionality described in "Expected behavior" has been implemented

  1. This list contains the usernames people can select to ping.
  2. Notice how this person's signature renders on this talk page as קיפודנחש (aka kipod)
  3. Notice how the username that appears in the link to their user page is קיפודנחש

Event Timeline

ppelberg updated the task description. (Show Details)Apr 15 2020, 11:47 PM
ppelberg updated the task description. (Show Details)

Here's my list-of-open-questions from T232601:

  • What if a custom signature and a real username collide?
  • What if multiple people on a page have the same alias?
  • Will it confuse the user if they pick @alias in the dropdown and what's output in the wikitext is [[User:RealName]]?
  • Do we indicate alias-status in the completion dropdown?
  • Will it confuse the user that completion of some names only works on some pages for inscrutable reasons?
  • Do we assume everything that links to a user-page is intended as an alias?

For people who have aliases set, is it customary for people wanting to @-mention them to refer to them by alias or by their registered username?

If people are mentioning them in ways that don't use their username, they're not getting pinged by Echo notifications.

ppelberg updated the task description. (Show Details)Apr 16 2020, 1:44 AM

Here's my list-of-open-questions from T232601:

Thank you for bringing these over here, @DLynch; I've added them to the task description's "Open questions."

As for timing/prioritization, per the quick chat David and I just had: we are going to wait on implementing the functionality this task is describing until we've answered the "Open questions" above.

ppelberg claimed this task.Apr 16 2020, 1:46 AM
ppelberg updated the task description. (Show Details)
Pelagic added a subscriber: Pelagic.Wed, May 6, 9:39 PM

To remove the ambiguity, you could display both names in a 2-column drop-down. SD post vkpxssh1ty6lue6t

To remove the ambiguity, you could display both names in a 2-column drop-down. SD post vkpxssh1ty6lue6t

Thank you for adding these comments here, @Pelagic. I'm doing the same now for the follow up responses provided in that same discussion: https://w.wiki/Rbp.

Helpful context @Whatamidoing-WMF shared here:

If you're not familiar with MediaWiki, then you would probably try to ping someone by the displayed name instead of the real username.