Page MenuHomePhabricator

Change from source code editing to visual editing: minor edit property not kept
Closed, ResolvedPublic

Description

  1. Start editing an article through source code editing
  2. Fill an edit summary in the source code editing view, and mark edit as a "minor edit"
  3. Change to visual editor before saving
  4. Click "publish"
  5. The summary dialog will show the previously defined edit summary, but the "minor edit" tick box will be unselected

Expected behaviour: "minor edit" tick box will be in a selected state in stage 5

Event Timeline

tomert created this task.Apr 16 2020, 1:53 PM
Restricted Application added a project: Machine Learning Platform. · View Herald TranscriptApr 16 2020, 1:53 PM
JTannerWMF moved this task from To Triage to Triaged on the VisualEditor board.
JTannerWMF added a subscriber: JTannerWMF.

We will take a look at this

I wrote a patch for this, was easy enough. But that only generated more questions and problems:

Change 598873 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] When switching from wikitext to visual, preserve the edit checkboxes

https://gerrit.wikimedia.org/r/598873

Let's keep this one simple, I filed T253696 about the additional changes I'm thinking of.

Esanders added a project: Editing QA.
Esanders moved this task from Inbox to Low Priority on the Editing QA board.

Change 598873 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] When switching from wikitext to visual, preserve the edit checkboxes

https://gerrit.wikimedia.org/r/598873

Ryasmeen added a subscriber: Ryasmeen.

This doesn't seem to be resolved. Still happening on Beta.

This works now for OWE but it doesn't for NWE. Separate task has been filed for that: T254830

ppelberg closed this task as Resolved.Jun 9 2020, 12:27 AM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJun 9 2020, 12:27 AM