Page MenuHomePhabricator
Create Task
Maniphest T250407

Deprecate wfForeignMemcKey() and BagOStuff::getKeyInternal()
Closed, ResolvedPublic
Actions

Description

The last few callers should be moved away from these old methods.

Details

SubjectRepoBranchLines +/-
Remove deprecated wfForeignMemcKey()mediawiki/coremaster+1 -29
Avoid use of wfForeignMemcKey()mediawiki/extensions/Flowmaster+37 -13
Deprecate wfForeignMemcKey() and remove the last callmediawiki/coremaster+6 -1
Customize query in gerrit

Event Timeline

aaron created this task.Apr 16 2020, 4:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 16 2020, 4:43 PM
Krinkle added a project: Technical-Debt (Deprecation process).Apr 16 2020, 5:27 PM
Krinkle moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.
Krinkle moved this task from General to libs/objectcache on the MediaWiki-libs-BagOStuff board.
gerritbot added a comment.Apr 17 2020, 9:57 AM

Change 589545 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/core@master] Deprecate wfForeignMemcKey() and remove the last call

https://gerrit.wikimedia.org/r/589545

gerritbot added a project: Patch-For-Review.Apr 17 2020, 9:57 AM

Change 589536 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/extensions/Flow@master] Avoid use of wfForeignMemcKey()

https://gerrit.wikimedia.org/r/589536

gerritbot added a comment.Apr 18 2020, 8:03 PM

Change 589545 merged by jenkins-bot:
[mediawiki/core@master] Deprecate wfForeignMemcKey() and remove the last call

https://gerrit.wikimedia.org/r/589545

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.30; 2020-04-28).Apr 18 2020, 9:00 PM
• Gilles moved this task from Inbox, needs triage to Doing (old) on the Performance-Team board.Apr 20 2020, 11:59 AM
Krinkle triaged this task as Low priority.Apr 21 2020, 5:53 PM
gerritbot added a comment.May 12 2020, 12:30 AM

Change 589536 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Avoid use of wfForeignMemcKey()

https://gerrit.wikimedia.org/r/589536

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.32; 2020-05-12); removed MW-1.35-notes (1.35.0-wmf.30; 2020-04-28).May 12 2020, 1:00 AM
Maintenance_bot removed a project: Patch-For-Review.May 12 2020, 1:10 AM
Krinkle removed aaron as the assignee of this task.May 13 2020, 11:41 PM
Krinkle moved this task from Doing (old) to Blocked (old) on the Performance-Team board.
Krinkle subscribed.

Awaiting the MW 1.36 cycle for the next step.

Krinkle removed a project: MW-1.35-notes (1.35.0-wmf.32; 2020-05-12).May 13 2020, 11:41 PM
aaron claimed this task.Oct 26 2020, 6:37 PM
aaron moved this task from Blocked (old) to Doing (old) on the Performance-Team board.
gerritbot added a comment.Oct 26 2020, 7:07 PM

Change 636479 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/core@master] Remove deprecated wfForeignMemcKey()

https://gerrit.wikimedia.org/r/636479

gerritbot added a project: Patch-For-Review.Oct 26 2020, 7:07 PM
gerritbot added a comment.Oct 26 2020, 9:24 PM

Change 636479 merged by jenkins-bot:
[mediawiki/core@master] Remove deprecated wfForeignMemcKey()

https://gerrit.wikimedia.org/r/636479

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.16; 2020-11-03).Oct 26 2020, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 26 2020, 10:10 PM
aaron closed this task as Resolved.Oct 30 2020, 9:41 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL