Description

It needs to be replaced with something that returns RevisionRecord (or null) instead of Revision (or null)

Add core replacement, soft deprecate
Update MobileFrontend
Hard deprecate

Details

Subject	Repo	Branch	Lines +/-
Hard deprecate ContribsPager::tryToCreateValidRevision	mediawiki/core	master	+4 -1
SpecialMobileContributions: remove all uses of Revision objects	mediawiki/extensions/MobileFrontend	master	+12 -11
Add ContribsPager::tryCreatingRevisionRecord	mediawiki/core	master	+80 -15

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T11968 Reduce use of global and public variables
Open	None	T159283 Deprecate non-configuration globals
Open	DannyS712	T159299 Deprecate and remove $wgUser
Resolved	DannyS712	T267861 [GOAL] Emit deprecation warnings reading from $wgUser
Open	DannyS712	T243708 Mediawiki core needs uses of global $wgUser removed
Resolved	DannyS712	T246284 Hard deprecate the Revision class
Resolved	DannyS712	T249393 Deprecate methods returning Revision objects
Resolved	DannyS712	T250431 ContribsPager::tryToCreateValidRevision returns Revision objects

Event Timeline

DannyS712 triaged this task as Medium priority.Apr 16 2020, 7:36 PM

DannyS712 created this task.

DannyS712 moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.

DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.

Only use is in core's ContribsPager itself and MobileFrontend's SpecialMobileContributions

DannyS712 mentioned this in T250980: Hard deprecate Revision::getParentId.Apr 24 2020, 3:50 AM

Change 592513 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Add ContribsPager::tryCreatingRevisionRecord

https://gerrit.wikimedia.org/r/592513

gerritbot added a project: Patch-For-Review.Apr 27 2020, 4:57 AM

DannyS712 moved this task from Next to In progress on the User-DannyS712 board.Apr 27 2020, 7:13 AM

Change 592785 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/MobileFrontend@master] SpecialMobileContributions: remove all uses of Revision objects

https://gerrit.wikimedia.org/r/592785

DannyS712 updated the task description. (Show Details)Apr 27 2020, 10:57 PM

Change 592513 merged by jenkins-bot:
[mediawiki/core@master] Add ContribsPager::tryCreatingRevisionRecord

https://gerrit.wikimedia.org/r/592513

DannyS712 updated the task description. (Show Details)Apr 27 2020, 11:17 PM

Change 592785 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] SpecialMobileContributions: remove all uses of Revision objects

https://gerrit.wikimedia.org/r/592785

DannyS712 updated the task description. (Show Details)Apr 29 2020, 3:39 PM

Change 593261 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate ContribsPager::tryToCreateValidRevision

https://gerrit.wikimedia.org/r/593261

DannyS712 moved this task from In progress to Awaiting review and deployment on the User-DannyS712 board.Apr 29 2020, 3:42 PM

Change 593261 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate ContribsPager::tryToCreateValidRevision

https://gerrit.wikimedia.org/r/593261

Maintenance_bot removed a project: Patch-For-Review.May 1 2020, 7:10 PM

DannyS712 closed this task as Resolved.May 1 2020, 7:43 PM

DannyS712 updated the task description. (Show Details)

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.31; 2020-05-05).May 1 2020, 9:00 PM

DannyS712 moved this task from Awaiting review and deployment to Resolved (deprecation) on the User-DannyS712 board.May 27 2020, 8:30 AM

DannyS712 claimed this task.Jun 24 2020, 3:21 AM