Page MenuHomePhabricator
Create Task
Maniphest T250446

CheckUser internal API error
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

I just checked a bunch of users using the API, but today it was impossible to fetch CU data about the user "Schweiz41" (on frwiki). However the special page worked as expected
It already happend to me in the past with other user. And back then, when an error occured a first time on a user, retrying on the same user always gave me the same error .

Steps to Reproduce:

HTTP Post request on frwiki:

{
    "action": "query",
    "format": "json",
    "list": "checkuser",
    "curequest": "edits",
    "cutarget": "Schweiz41",
    "cureason": "Schweiz41,+SwissArmy26+-+16+avril",
    "culimit": "max",
    "cutimecond": "-3+months",
    "cutoken": "....."
}

Actual Results:

{
    "error": {
        "code": "internal_api_error_Exception",
        "info": "[7e078238-da6a-49e5-a771-51d13d9c252c] Caught exception of type Exception",
        "errorclass": "Exception"
    },
    "servedby": "mw1280"
}

Expected Results:
JSON-formated edits of the user "Schweiz41" with CU informations.

Details

Stack Trace
2020-04-16 21:58:35 [7e078238-da6a-49e5-a771-51d13d9c252c] mw1280 frwiki 1.35.0-wmf.28 exception ERROR: [7e078238-da6a-49e5-a771-51d13d9c252c] /w/api.php   Exception from line 159 of /srv/mediawiki/php-1.35.0-wmf.28/extensions/CheckUser/includes/api/ApiQueryCheckUser.php: Couldn't fetch revision cu_changes table links to (cuc_this_oldid 0) {"exception_id":"7e078238-da6a-49e5-a771-51d13d9c252c","exception_url":"/w/api.php","caught_by":"mwe_handler"} 
[Exception Exception] (/srv/mediawiki/php-1.35.0-wmf.28/extensions/CheckUser/includes/api/ApiQueryCheckUser.php:159) Couldn't fetch revision cu_changes table links to (cuc_this_oldid 0)
  #0 /srv/mediawiki/php-1.35.0-wmf.28/includes/api/ApiQuery.php(263): ApiQueryCheckUser->execute()
  #1 /srv/mediawiki/php-1.35.0-wmf.28/includes/api/ApiMain.php(1580): ApiQuery->execute()
  #2 /srv/mediawiki/php-1.35.0-wmf.28/includes/api/ApiMain.php(523): ApiMain->executeAction()
  #3 /srv/mediawiki/php-1.35.0-wmf.28/includes/api/ApiMain.php(494): ApiMain->executeActionWithErrorHandling()
  #4 /srv/mediawiki/php-1.35.0-wmf.28/api.php(84): ApiMain->execute()
  #5 /srv/mediawiki/w/api.php(3): require(string)
  #6 {main}
ProjectBranchLines +/-Subject
mediawiki/extensions/CheckUsermaster+41 -37Fix api error when fetching a revisions with invalid id
Customize query in gerrit

Related Objects

Event Timeline

0x010C created this task.Apr 16 2020, 10:15 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 16 2020, 10:15 PM
Reedy added a project: Wikimedia-production-error.Apr 16 2020, 10:20 PM
Reedy changed the subtype of this task from "Bug Report" to "Production Error".
Reedy edited Stack Trace. (Show Details)
0x010C added a comment.Apr 16 2020, 10:25 PM

If it can help, it just happend again with another user "Navsenar" (always on frwiki).

{
    "error": {
        "code": "internal_api_error_Exception",
        "info": "[9cb64ab9-80ca-4c60-b9ff-3df26f4641d5] Caught exception of type Exception",
        "errorclass": "Exception"
    },
    "servedby": "mw1312"
}
Reedy added a project: Regression.Apr 16 2020, 10:32 PM
Reedy added subscribers: DannyS712, Reedy.

Possibly related to @DannyS712's patches for T249021: Hard deprecate Revision::newFromId

Reedy moved this task from Untriaged to Apr2020/1.35-wmf.26+ on the Wikimedia-production-error board.Apr 16 2020, 10:37 PM
DannyS712 added a subscriber: Urbanecm.Apr 16 2020, 10:44 PM

Nope, I don't think so
If cuc_this_oldid is 0, there is indeed no Revision that corresponds, either retrieved via Revision::newFromId or otherwise
The exception was added by @Urbanecm as part of T234862: Do not show oversighted edit summaries in CheckUser API (CVE-2019-18611), to find the corresponding revision and see if the user can view it rather than assuming they could; I just changed how the revision was fetched

thcipriani added a project: Anti-Harassment.Apr 29 2020, 6:19 PM
thcipriani added a subscriber: thcipriani.

Adding in Anti-Harassment folks to see if this is at all related to recent refactoring work on CheckUser.

Krinkle added a subscriber: Krinkle.Apr 29 2020, 6:20 PM

Based on searching Logstash/mediawiki-errors for Couldn't fetch revision cu_changes it seems this happens mainly on fr.wikipedia.org, which given the low frequency of CheckUser actions might just be a coincindence.

It has been observed there since at least 2020-02-09.

dmaza added a subscriber: dmaza.Apr 29 2020, 8:56 PM
In T250446#6094740, @thcipriani wrote:

Adding in Anti-Harassment folks to see if this is at all related to recent refactoring work on CheckUser.

Looking thru it but it doesn't seem related to our present work

gerritbot added a comment.Apr 30 2020, 4:52 AM

Change 593375 had a related patch set uploaded (by Dmaza; owner: Dmaza):
[mediawiki/extensions/CheckUser@master] Fix api error when fetching a revisions with invalid id

https://gerrit.wikimedia.org/r/593375

gerritbot added a project: Patch-For-Review.Apr 30 2020, 4:52 AM
Tchanders assigned this task to dmaza.Apr 30 2020, 1:40 PM
dbarratt edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.Apr 30 2020, 1:40 PM
dbarratt moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.
gerritbot added a comment.Apr 30 2020, 5:31 PM

Change 593375 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Fix api error when fetching a revisions with invalid id

https://gerrit.wikimedia.org/r/593375

Tchanders moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (The Letter Song) board.Apr 30 2020, 5:37 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.31; 2020-05-05).Apr 30 2020, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 30 2020, 6:10 PM
dom_walden moved this task from QA/Testing 🐞 to Done: Q4 (2019-20) on the Anti-Harassment (The Letter Song) board.May 6 2020, 1:24 PM
dom_walden added a subscriber: dom_walden.

Cannot reproduce on:

Niharika closed this task as Resolved.May 6 2020, 5:52 PM
Niharika added a subscriber: Niharika.

Thanks all.

0x010C reopened this task as Open.EditedMay 11 2020, 7:07 AM

Hi,

I'm reopening this task as it seems not completely fixed. Performing a check this morning on [[User:Karl Marx1844]] (frwiki), I still get an error (only through the API as previously):

{
    "error": {
        "code": "internal_api_error_Exception",
        "info": "[3bd3f313-2aea-4849-9746-b3d9c37a1ed6] Caught exception of type Exception",
        "errorclass": "Exception"
    },
    "servedby": "mw1400"
}
DannyS712 closed this task as Resolved.EditedMay 11 2020, 7:15 AM
In T250446#6123450, @0x010C wrote:

Hi,

I'm reopening this task as it seems not completely fixed. Performing a check this morning on [[User:Karl Marx1844]] (frwiki), I still get an error (only through the API as previously):

{
    "error": {
        "code": "internal_api_error_Exception",
        "info": "[3bd3f313-2aea-4849-9746-b3d9c37a1ed6] Caught exception of type Exception",
        "errorclass": "Exception"
    },
    "servedby": "mw1400"
}

That one is because of me - the fix was deployed, tested, and worked, and then was undeployed due to unrelated issues. See T249963: 1.35.0-wmf.31 deployment blockers. It should be deployed again at some point tomorrow/today (Monday).

0x010C added a comment.May 11 2020, 7:19 AM

Oh, ok that's fine then :). Thanks @DannyS712

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL