We shouldn't be cloning Parser objects any more, just create new ones. The main use of clone $parser seems to be in includes/cache/MessageCache.php (see https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/589396/1/includes/cache/MessageCache.php) -- and shortly that will probably be using a Parsoid parser while the main article parser remains the legacy parser.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| language: Inject ParserFactory into MessageCache | mediawiki/core | master | +24 -17 | |
| WIP: Deprecate Parser::__clone() | mediawiki/core | master | +2 -0 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T261329 Prepare Parsoid for MW | |||
| Open | None | T236809 Refactor Parser.php to allow alternate parser (Parsoid) | |||
| Open | None | T236812 Parser.php should be split into a base class and a parser implementation | |||
| Open | None | T236811 Parser creation should always use factory | |||
| Open | None | T250448 Deprecate and remove Parser::__clone() |
Event Timeline
Comment Actions
Code search: https://codesearch.wmflabs.org/search/?q=clone%20%5C%24%5BA-Za-z%5D*parser&i=nope&files=&repos=
Doesn't look too bad.
Comment Actions
Change 665202 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] WIP: Deprecate Parser::__clone()
Comment Actions
Change 942775 had a related patch set uploaded (by Umherirrender; author: Umherirrender):
[mediawiki/core@master] language: Inject ParserFactory into MessageCache
Comment Actions
Change 942775 merged by jenkins-bot:
[mediawiki/core@master] language: Inject ParserFactory into MessageCache