Page MenuHomePhabricator

Deprecate and remove ParserBeforeStrip
Open, Needs TriagePublic

Description

There is only one caller of ParserBeforeStrip: the translate extension.

However, we will likely have to introduce a new ParserBeforeReplaceVariables hook for use by Translate. See https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/446984/

That's probably still better than keeping Before/AfterStrip around, since those hooks are misnamed, redundant, and have lingering references in their signatures.

Event Timeline

cscott created this task.Apr 16 2020, 10:36 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 16 2020, 10:36 PM

Change 589458 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] WIP: Add ParserBeforePreprocess hook

https://gerrit.wikimedia.org/r/589458

Change 446984 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] WIP: Deprecate ParserBeforeStrip/ParserAfterStrip hooks

https://gerrit.wikimedia.org/r/446984

Change 446989 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/Translate@master] Avoid using deprecated ParserBeforeStrip hook

https://gerrit.wikimedia.org/r/446989

Change 589683 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/WhiteSpace@master] Don't use deprecated ParserBeforeStrip hook

https://gerrit.wikimedia.org/r/589683

Change 589685 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/DisplayTitle@master] Don't use deprecated ParserBeforeStrip hook

https://gerrit.wikimedia.org/r/589685

Change 589686 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/FanBoxes@master] Don't use deprecated ParserBeforeStrip hook

https://gerrit.wikimedia.org/r/589686

Change 589689 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/PerPageLicense@master] Don't use deprecated ParserBeforeStrip hook

https://gerrit.wikimedia.org/r/589689

Change 589690 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/RandomImage@master] Don't use deprecated ParserBeforeStrip hook

https://gerrit.wikimedia.org/r/589690

Change 589691 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/Video@master] Don't use deprecated ParserBeforeStrip hook

https://gerrit.wikimedia.org/r/589691

Change 589458 merged by jenkins-bot:
[mediawiki/core@master] Add ParserBeforePreprocess hook

https://gerrit.wikimedia.org/r/589458

Change 589683 merged by jenkins-bot:
[mediawiki/extensions/WhiteSpace@master] Don't use deprecated ParserBeforeStrip hook

https://gerrit.wikimedia.org/r/589683

Change 589686 merged by jenkins-bot:
[mediawiki/extensions/FanBoxes@master] Don't use deprecated ParserBeforeStrip hook

https://gerrit.wikimedia.org/r/589686

Change 589689 merged by jenkins-bot:
[mediawiki/extensions/PerPageLicense@master] Don't use deprecated ParserBeforeStrip hook

https://gerrit.wikimedia.org/r/589689

Change 589690 merged by jenkins-bot:
[mediawiki/extensions/RandomImage@master] Don't use deprecated ParserBeforeStrip hook

https://gerrit.wikimedia.org/r/589690

Change 589691 merged by jenkins-bot:
[mediawiki/extensions/Video@master] Don't use deprecated ParserBeforeStrip hook

https://gerrit.wikimedia.org/r/589691

Change 446989 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Avoid using deprecated ParserBeforeStrip hook

https://gerrit.wikimedia.org/r/446989