Page MenuHomePhabricator

Deprecate and remove ParserBeforeStrip
Open, Needs TriagePublic

Description

There is only one caller of ParserBeforeStrip: the translate extension.

However, we will likely have to introduce a new ParserBeforeReplaceVariables hook for use by Translate. See https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/446984/

That's probably still better than keeping Before/AfterStrip around, since those hooks are misnamed, redundant, and have lingering references in their signatures.

Event Timeline

Change 589458 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] WIP: Add ParserBeforePreprocess hook

https://gerrit.wikimedia.org/r/589458

Change 446984 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] WIP: Deprecate ParserBeforeStrip/ParserAfterStrip hooks

https://gerrit.wikimedia.org/r/446984

Change 446989 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/Translate@master] Avoid using deprecated ParserBeforeStrip hook

https://gerrit.wikimedia.org/r/446989

Change 589683 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/WhiteSpace@master] Don't use deprecated ParserBeforeStrip hook

https://gerrit.wikimedia.org/r/589683

Change 589685 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/DisplayTitle@master] Don't use deprecated ParserBeforeStrip hook

https://gerrit.wikimedia.org/r/589685

Change 589686 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/FanBoxes@master] Don't use deprecated ParserBeforeStrip hook

https://gerrit.wikimedia.org/r/589686

Change 589689 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/PerPageLicense@master] Don't use deprecated ParserBeforeStrip hook

https://gerrit.wikimedia.org/r/589689

Change 589690 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/RandomImage@master] Don't use deprecated ParserBeforeStrip hook

https://gerrit.wikimedia.org/r/589690

Change 589691 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/Video@master] Don't use deprecated ParserBeforeStrip hook

https://gerrit.wikimedia.org/r/589691

Change 589458 merged by jenkins-bot:
[mediawiki/core@master] Add ParserBeforePreprocess hook

https://gerrit.wikimedia.org/r/589458

Change 589683 merged by jenkins-bot:
[mediawiki/extensions/WhiteSpace@master] Don't use deprecated ParserBeforeStrip hook

https://gerrit.wikimedia.org/r/589683

Change 589686 merged by jenkins-bot:
[mediawiki/extensions/FanBoxes@master] Don't use deprecated ParserBeforeStrip hook

https://gerrit.wikimedia.org/r/589686

Change 589689 merged by jenkins-bot:
[mediawiki/extensions/PerPageLicense@master] Don't use deprecated ParserBeforeStrip hook

https://gerrit.wikimedia.org/r/589689

Change 589690 merged by jenkins-bot:
[mediawiki/extensions/RandomImage@master] Don't use deprecated ParserBeforeStrip hook

https://gerrit.wikimedia.org/r/589690

Change 589691 merged by jenkins-bot:
[mediawiki/extensions/Video@master] Don't use deprecated ParserBeforeStrip hook

https://gerrit.wikimedia.org/r/589691

Change 446989 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Avoid using deprecated ParserBeforeStrip hook

https://gerrit.wikimedia.org/r/446989

Change 622618 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Remove ParserBeforeStrip/ParserAfterStrip hooks, deprecated in 1.35

https://gerrit.wikimedia.org/r/622618

Change 589685 merged by jenkins-bot:
[mediawiki/extensions/DisplayTitle@master] Don't use deprecated ParserBeforeStrip hook

https://gerrit.wikimedia.org/r/589685

Change 628587 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Hard-deprecate the ParserBeforeStrip/ParserAfterStrip hooks

https://gerrit.wikimedia.org/r/628587

Change 446984 abandoned by Jforrester:
[mediawiki/core@master] Deprecate ParserBeforeStrip/ParserAfterStrip hooks

Reason:
New hook system meant that I did 4a77e850509b5f4b78b66ef9602577e1acc23245 instead.

https://gerrit.wikimedia.org/r/446984

Change 628587 merged by jenkins-bot:
[mediawiki/core@master] Hard-deprecate the ParserBeforeStrip/ParserAfterStrip hooks

https://gerrit.wikimedia.org/r/628587

Change 628557 had a related patch set uploaded (by Ammarpad; owner: Jforrester):
[mediawiki/core@REL1_35] Hard-deprecate the ParserBeforeStrip/ParserAfterStrip hooks

https://gerrit.wikimedia.org/r/628557

Change 628557 merged by jenkins-bot:
[mediawiki/core@REL1_35] Hard-deprecate the ParserBeforeStrip/ParserAfterStrip hooks

https://gerrit.wikimedia.org/r/628557

Change 622618 merged by jenkins-bot:
[mediawiki/core@master] Remove ParserBeforeStrip/ParserAfterStrip hooks, deprecated in 1.35

https://gerrit.wikimedia.org/r/622618

Change 674120 had a related patch set uploaded (by Cicalese; owner: C. Scott Ananian):
[mediawiki/extensions/DisplayTitle@REL1_35] Don't use deprecated ParserBeforeStrip hook

https://gerrit.wikimedia.org/r/674120

Change 674120 merged by jenkins-bot:
[mediawiki/extensions/DisplayTitle@REL1_35] Don't use deprecated ParserBeforeStrip hook

https://gerrit.wikimedia.org/r/674120