Page MenuHomePhabricator
Create Task
Maniphest T250454

Flow should use dependency injection instead of wfWikiID()
Open, Needs TriagePublic
Actions

Description

While testing an upgrade on my dev server, I began getting a bunch of errors from Flow like the following:

/wiki/Talk:Main_Page Flow\Exception\UnknownWorkflowIdException from line 127 of .../extensions/Flow/includes/WorkflowLoaderFactory.php: The requested workflow does not exist on this wiki.

This came from a mis-match between the results of wfWikiID() and what was stored in the database.

If we replace the calls to the global wfWikiID() with a wiki_id from Flow's dependency injection, it is easy to work-around this problem for testing scenarios like mine.

Details

SubjectRepoBranchLines +/-
Introduce dependency injection to replace calls to wfWikiID()mediawiki/extensions/Flowmaster+83 -56
Customize query in gerrit

Event Timeline

MarkAHershberger created this task.Apr 16 2020, 11:10 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 16 2020, 11:10 PM
gerritbot added a comment.Apr 16 2020, 11:13 PM

Change 589444 had a related patch set uploaded (by markahershberger; owner: markahershberger):
[mediawiki/extensions/Flow@master] Introduce dependency injection to replace calls to wfWikiID()

https://gerrit.wikimedia.org/r/589444

gerritbot added a project: Patch-For-Review.Apr 16 2020, 11:13 PM
Reedy added a project: StructuredDiscussions.Apr 16 2020, 11:14 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptApr 16 2020, 11:14 PM
MarkAHershberger added a subscriber: daniel.Apr 17 2020, 12:29 AM

Adding @daniel since I hear he knows a thing or two about DI.

MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:47 PM
Aklapper edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Aug 16 2022, 10:28 AM
Aklapper removed MarkAHershberger as the assignee of this task.Sep 26 2022, 10:22 AM

Removing task assignee due to inactivity as this open task has been assigned for more than two years. See the email sent to the task assignee on August 22nd, 2022.
Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome!
If this task has been resolved in the meantime, or should not be worked on ("declined"), please update its task status via "Add Action… 🡒 Change Status".
Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator. Thanks!

kostajh moved this task from Inbox to Triaged on the Growth-Team board.Sep 26 2022, 10:29 AM
kostajh removed a project: Growth-Team-Filtering.
gerritbot added a comment.Nov 12 2023, 12:55 AM

Change 589444 abandoned by MarkAHershberger:

[mediawiki/extensions/Flow@master] Introduce dependency injection to replace calls to wfWikiID()

Reason:

https://gerrit.wikimedia.org/r/589444

Pppery removed a project: Patch-Needs-Improvement.Nov 12 2023, 5:28 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL