Page MenuHomePhabricator

ReCaptchaNoCaptcha not working in VisualEditor
Closed, ResolvedPublic

Description

When both, the VisualEditor and ConfirmEdit extension, are installed and the ReCaptchaNoCaptcha module is used, then editors who require a Captcha check can not save their edit. The API module for ReCaptchaNoCaptcha is currently not handled by the VisualEditor integration in ConfirmEdit. Therefore, an edit that is aborted by the captcha module is recognized as a general, not handled error in VisualEditor.

It would be great if ReCaptcha would be supported in VisualEditor as well, so that the edit of users who need to solve a captcha is still being able to be saved.

Event Timeline

Florian created this task.Apr 17 2020, 1:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 17 2020, 1:45 PM

Change 589594 had a related patch set uploaded (by Florianschmidtwelzow; owner: Florianschmidtwelzow):
[mediawiki/extensions/ConfirmEdit@master] Support ReCaptchaNoCaptcha in VisualEditor

https://gerrit.wikimedia.org/r/589594

Change 589594 abandoned by Florianschmidtwelzow:
Support ReCaptchaNoCaptcha in VisualEditor

Reason:
Bullshit... There's already support for the ReCaptcha module. It's just broken and lives in the ReCaptcha module itself. I'll submit a patch to fix it.

https://gerrit.wikimedia.org/r/589594

Change 589623 had a related patch set uploaded (by Florianschmidtwelzow; owner: Florianschmidtwelzow):
[mediawiki/extensions/ConfirmEdit@master] [reCaptcha] FIx support for VisualEditor

https://gerrit.wikimedia.org/r/589623

Change 589623 merged by jenkins-bot:
[mediawiki/extensions/ConfirmEdit@master] [reCaptcha] Fix support for VisualEditor

https://gerrit.wikimedia.org/r/589623

matmarex edited projects, added Skipped QA; removed Patch-For-Review.
matmarex added a subscriber: matmarex.

(Note that we don't use ReCaptcha on Wikimedia wikis, so we don't have a convenient way for QA to test this.)

@matmarex I'm not that deep into how VE works, but is there a possibility to have a test from somewhere on this side? Something like a JavaScript testing module, which checks, that the plugin is registered? That would not check the functionality itself, sure, but at least we know, if the plugin is there and _would_ work?

ppelberg closed this task as Resolved.May 6 2020, 1:12 AM
ppelberg added a subscriber: ppelberg.

@Florian I'm going to close this task considering the functionality it is asking for seems, to me, to be implemented.

If this is not the case, please re-open the task... the question you posed in T250488#6067813 still being open led me to want to double check.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMay 6 2020, 1:12 AM

No, I think it's ok to close this task :-) If we find a good way to test this feature, we can still write a patch or a separate task for it :)