Page MenuHomePhabricator
Create Task
Maniphest T250497

equals sign in search seems to cause timeout
Closed, InvalidPublic
Actions

Description

In a search like "unapproved=" a string that can be seen in current spambot urls, it seems to overwhelm the search and a timeout results

https://tools.wmflabs.org/global-search/?q=%22unapproved=%22

similar search with a question mark "?unapproved" progresses fine
https://tools.wmflabs.org/global-search/?q=%22?unapproved%22

I am wondering whether there is a need for escaping or unicode converting this as it may think that it is active part of the url query rather than part of the search term.

Event Timeline

Billinghurst created this task.Apr 17 2020, 3:27 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 17 2020, 3:27 PM
QEDK subscribed.EditedApr 17 2020, 8:48 PM

@Billinghurst Can you check again? It works for me. The tool correctly escapes the "=" to https://tools.wmflabs.org/global-search/?q=%22unapproved%3D%22+&namespaces=

Billinghurst added a comment.Apr 18 2020, 6:09 AM

Well something quirky is happening. That was the url that the system delivered from the search at the time. Good now. MA knows that I have been having other time out issues with spambot urls, so I am just going to have to keep a watching brief.

QEDK closed this task as Invalid.Apr 18 2020, 7:23 AM

Closing this for now then, feel free to reopen if it happens again.

MusikAnimal moved this task from Backlog to Done on the Tool-global-search board.May 17 2020, 7:53 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL