Page MenuHomePhabricator
Create Task
Maniphest T250543

Replace `ArticleRollbackComplete` hook
Closed, ResolvedPublic
Actions

Assigned To
DannyS712
Authored By
DannyS712
Apr 18 2020, 1:48 AM
Tags
Referenced Files
None
Subscribers
Aklapper
DannyS712
• Mholloway
• Pchelolo
tstarling

Description

It uses Revision objects (twice)

Suggested replacement: RollbackComplete - all rollbacks are on articles

Deployed extensions that will need to be updated:

Details

SubjectRepoBranchLines +/-
Hooks: Hard deprecate 2 hooks using Revision objectsmediawiki/coremaster+4 -2
Replace use of deprecate `ArticleRollbackComplete` hookmediawiki/extensions/Jademaster+12 -9
Replace use of `ArticleRollbackComplete` hook with `RollbackComplete`mediawiki/extensions/Echomaster+14 -8
Replace use of `ArticleRollbackComplete` hook with `RollbackComplete`mediawiki/extensions/FlaggedRevsmaster+5 -4
Replace use of `ArticleRollbackComplete` hook with `RollbackComplete`mediawiki/extensions/MachineVisionmaster+10 -9
Replace use of `ArticleRollbackComplete` hook with `RollbackComplete`mediawiki/extensions/WikimediaEditorTasksmaster+22 -15
Replace `ArticleRollbackComplete` hook with `RollbackComplete`mediawiki/coremaster+13 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

DannyS712 created this task.Apr 18 2020, 1:48 AM
Restricted Application added projects: Growth-Team, Product-Infrastructure-Team-Backlog-Deprecated, Structured-Data-Backlog. · View Herald TranscriptApr 18 2020, 1:48 AM
DannyS712 triaged this task as Medium priority.Apr 18 2020, 1:49 AM
DannyS712 moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.
DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.
gerritbot added a comment.Apr 18 2020, 4:50 AM

Change 589823 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Replace ArticleRollbackComplete hook with RollbackComplete

https://gerrit.wikimedia.org/r/589823

gerritbot added a project: Patch-For-Review.Apr 18 2020, 4:50 AM
DannyS712 mentioned this in T249434: Replace hooks using Revision objects with RevisionRecord.Apr 18 2020, 5:16 AM
gerritbot added a comment.Apr 20 2020, 10:59 PM

Change 589823 merged by jenkins-bot:
[mediawiki/core@master] Replace ArticleRollbackComplete hook with RollbackComplete

https://gerrit.wikimedia.org/r/589823

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.30; 2020-04-28).Apr 20 2020, 11:00 PM
gerritbot added a comment.Apr 20 2020, 11:00 PM

Change 591213 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/FlaggedRevs@master] Replace use of ArticleRollbackComplete hook with RollbackComplete

https://gerrit.wikimedia.org/r/591213

gerritbot added a comment.Apr 20 2020, 11:03 PM

Change 591215 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Echo@master] Replace use of ArticleRollbackComplete hook with RollbackComplete

https://gerrit.wikimedia.org/r/591215

gerritbot added a comment.Apr 20 2020, 11:10 PM

Change 591219 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/MachineVision@master] Replace use of ArticleRollbackComplete hook with RollbackComplete

https://gerrit.wikimedia.org/r/591219

gerritbot added a comment.Apr 20 2020, 11:14 PM

Change 591222 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/WikimediaEditorTasks@master] Replace use of ArticleRollbackComplete hook with RollbackComplete

https://gerrit.wikimedia.org/r/591222

DannyS712 added a subscriber: • Mholloway.Apr 20 2020, 11:20 PM

@Mholloway for MachineVision and WikimediaEditorTasks is it okay to bump the required version? Currently they support 1.33 and 1.34 respectively, and in the patch they require 1.35+

• Mholloway added a comment.Apr 21 2020, 1:58 PM

That sounds fine to me.

gerritbot added a comment.Apr 21 2020, 2:28 PM

Change 591222 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEditorTasks@master] Replace use of ArticleRollbackComplete hook with RollbackComplete

https://gerrit.wikimedia.org/r/591222

DannyS712 mentioned this in rEWET257b71335379: Replace use of `ArticleRollbackComplete` hook with `RollbackComplete`.Apr 21 2020, 2:29 PM
gerritbot added a comment.Apr 21 2020, 2:38 PM

Change 591219 merged by jenkins-bot:
[mediawiki/extensions/MachineVision@master] Replace use of ArticleRollbackComplete hook with RollbackComplete

https://gerrit.wikimedia.org/r/591219

• Mholloway moved this task from Needs triage to Tracking on the Product-Infrastructure-Team-Backlog-Deprecated board.Apr 28 2020, 9:41 PM
CBogen moved this task from Triage to Tracking on the Structured-Data-Backlog board.May 5 2020, 3:39 PM
gerritbot added a comment.May 5 2020, 11:39 PM

Change 591213 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Replace use of ArticleRollbackComplete hook with RollbackComplete

https://gerrit.wikimedia.org/r/591213

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.32; 2020-05-12); removed MW-1.35-notes (1.35.0-wmf.30; 2020-04-28).May 6 2020, 12:00 AM
gerritbot added a comment.May 6 2020, 12:16 AM

Change 591215 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Replace use of ArticleRollbackComplete hook with RollbackComplete

https://gerrit.wikimedia.org/r/591215

DannyS712 changed the task status from Open to Stalled.May 6 2020, 12:18 AM
DannyS712 removed a project: Patch-For-Review.
DannyS712 added a subscriber: tstarling.

All deployed extensions updated. Waiting until @tstarling's current work on hooks is merged, to avoid merge conflicts and slowing that down.

gerritbot added a comment.May 27 2020, 5:31 AM

Change 598911 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Jade@master] Replace use of deprecate ArticleRollbackComplete hook

https://gerrit.wikimedia.org/r/598911

gerritbot added a project: Patch-For-Review.May 27 2020, 5:31 AM
gerritbot added a comment.May 27 2020, 9:00 PM

Change 598911 merged by jenkins-bot:
[mediawiki/extensions/Jade@master] Replace use of deprecate ArticleRollbackComplete hook

https://gerrit.wikimedia.org/r/598911

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.35; 2020-06-02); removed MW-1.35-notes (1.35.0-wmf.32; 2020-05-12).May 27 2020, 9:01 PM
Maintenance_bot removed a project: Patch-For-Review.May 27 2020, 9:10 PM
gerritbot added a comment.May 30 2020, 7:06 PM

Change 600401 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hooks: Hard deprecate 2 hooks using Revision objects

https://gerrit.wikimedia.org/r/600401

gerritbot added a project: Patch-For-Review.May 30 2020, 7:06 PM
DannyS712 changed the task status from Stalled to Open.May 30 2020, 7:08 PM
DannyS712 moved this task from In progress to Awaiting review and deployment on the User-DannyS712 board.
gerritbot added a comment.Jun 1 2020, 4:03 PM

Change 600401 merged by jenkins-bot:
[mediawiki/core@master] Hooks: Hard deprecate 2 hooks using Revision objects

https://gerrit.wikimedia.org/r/600401

Maintenance_bot removed a project: Patch-For-Review.Jun 1 2020, 4:10 PM
DannyS712 closed this task as Resolved.Jun 1 2020, 9:54 PM
DannyS712 moved this task from Awaiting review and deployment to Resolved (deprecation) on the User-DannyS712 board.Jul 9 2020, 11:15 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL