Page MenuHomePhabricator
Create Task
Maniphest T250579

Hard deprecate Revision::getUserText
Closed, ResolvedPublic
Actions

Description

The only remaining use outside of core is in AbuseFilter

  • Fix abusefilter
  • Replace core uses
  • Hard deprecate

Details

Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

DannyS712 created this task.Apr 18 2020, 9:09 PM
gerritbot added a comment.Apr 18 2020, 9:09 PM

Change 588793 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/AbuseFilter@master] Remove a remaining use of Revision objects

https://gerrit.wikimedia.org/r/588793

gerritbot added a project: Patch-For-Review.Apr 18 2020, 9:09 PM
DannyS712 triaged this task as Medium priority.Apr 18 2020, 9:09 PM
DannyS712 moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.
DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.
DannyS712 added a comment.Apr 23 2020, 6:02 PM

@Daimona can you take a look at the patch for AbuseFilter?

gerritbot added a comment.Apr 23 2020, 8:05 PM

Change 588793 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Remove a remaining use of Revision objects

https://gerrit.wikimedia.org/r/588793

DannyS712 updated the task description. (Show Details)Apr 23 2020, 8:05 PM
DannyS712 added a comment.EditedApr 23 2020, 8:09 PM

Unfortunately, a lot of the uses in core are in other components that will need more work to remove the Revision objects, some of which already have patches pending, eg T250680: Hard deprecate WikiPage::getUndoContent. I'll try to track down those not already covered elsewhere

Maintenance_bot removed a project: Patch-For-Review.Apr 23 2020, 8:10 PM
gerritbot added a comment.Apr 23 2020, 8:33 PM

Change 589702 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Replace uses and hard deprecate Parser::getRevisionObject

https://gerrit.wikimedia.org/r/589702

gerritbot added a project: Patch-For-Review.Apr 23 2020, 8:33 PM

Change 589705 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Have CoreParserFunctions::getCachedRevisionObject return RevisionRecord

https://gerrit.wikimedia.org/r/589705

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.30; 2020-04-28).Apr 23 2020, 9:00 PM
gerritbot added a comment.Apr 24 2020, 12:27 AM

Change 592318 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] RollbackAction: Reduce uses of Revision objects

https://gerrit.wikimedia.org/r/592318

gerritbot added a comment.Apr 24 2020, 12:36 AM

Change 592319 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Article::setOldSubtitle - reduce use of Revision objects

https://gerrit.wikimedia.org/r/592319

gerritbot added a comment.Apr 24 2020, 12:45 AM

Change 592320 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Convert WikiPage::$mLastRevision to RevisionRecord

https://gerrit.wikimedia.org/r/592320

DannyS712 mentioned this in T251067: Hard deprecate individual Revision class methods [tracking].Apr 26 2020, 11:37 PM
DannyS712 removed a parent task: T246284: Hard deprecate the Revision class.Apr 26 2020, 11:39 PM
DannyS712 added a parent task: T251067: Hard deprecate individual Revision class methods [tracking].
gerritbot added a comment.Apr 27 2020, 5:07 AM

Change 592513 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Add ContribsPager::tryCreatingRevisionRecord

https://gerrit.wikimedia.org/r/592513

gerritbot added a comment.Apr 27 2020, 11:01 PM

Change 592513 merged by jenkins-bot:
[mediawiki/core@master] Add ContribsPager::tryCreatingRevisionRecord

https://gerrit.wikimedia.org/r/592513

gerritbot added a comment.Apr 28 2020, 6:03 PM

Change 592320 merged by jenkins-bot:
[mediawiki/core@master] Convert WikiPage::$mLastRevision to RevisionRecord

https://gerrit.wikimedia.org/r/592320

gerritbot added a comment.Apr 28 2020, 9:34 PM

Change 589702 merged by jenkins-bot:
[mediawiki/core@master] Replace uses and hard deprecate Parser::getRevisionObject

https://gerrit.wikimedia.org/r/589702

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.31; 2020-05-05); removed MW-1.35-notes (1.35.0-wmf.30; 2020-04-28).Apr 28 2020, 10:00 PM
gerritbot added a comment.Apr 30 2020, 8:16 PM

Change 589705 merged by jenkins-bot:
[mediawiki/core@master] Have CoreParserFunctions::getCachedRevisionObject return RevisionRecord

https://gerrit.wikimedia.org/r/589705

gerritbot added a comment.Apr 30 2020, 10:11 PM

Change 593620 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Replace various uses of Revision objects

https://gerrit.wikimedia.org/r/593620

gerritbot added a comment.May 1 2020, 5:55 PM

Change 593620 merged by jenkins-bot:
[mediawiki/core@master] Replace various uses of Revision objects

https://gerrit.wikimedia.org/r/593620

gerritbot added a comment.May 1 2020, 7:09 PM

Change 592319 merged by jenkins-bot:
[mediawiki/core@master] Article::setOldSubtitle - reduce use of Revision objects

https://gerrit.wikimedia.org/r/592319

DannyS712 added a comment.May 4 2020, 5:42 PM

Remaining core uses:

and tests

gerritbot added a comment.May 4 2020, 5:43 PM

Change 594253 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Remove use of Revision objects in SpecialNewpages::feedItemDesc

https://gerrit.wikimedia.org/r/594253

gerritbot added a comment.May 20 2020, 8:14 PM

Change 594253 merged by jenkins-bot:
[mediawiki/core@master] Remove use of Revision objects in SpecialNewpages::feedItemDesc

https://gerrit.wikimedia.org/r/594253

gerritbot added a comment.May 20 2020, 8:49 PM

Change 592318 merged by jenkins-bot:
[mediawiki/core@master] RollbackAction: Reduce uses of Revision objects

https://gerrit.wikimedia.org/r/592318

Maintenance_bot removed a project: Patch-For-Review.May 20 2020, 9:10 PM
gerritbot added a comment.May 20 2020, 9:12 PM

Change 593272 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Remove DifferenceEngine::$mNewRev and $mOldRev

https://gerrit.wikimedia.org/r/593272

gerritbot added a project: Patch-For-Review.May 20 2020, 9:12 PM
DannyS712 added a comment.May 20 2020, 9:12 PM
In T250579#6153822, @gerritbot wrote:

Change 593272 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Remove DifferenceEngine::$mNewRev and $mOldRev

https://gerrit.wikimedia.org/r/593272

Only remaining use before hard deprecation can proceed

gerritbot added a comment.May 26 2020, 9:58 PM

Change 593272 merged by jenkins-bot:
[mediawiki/core@master] Remove DifferenceEngine::$mNewRev and $mOldRev

https://gerrit.wikimedia.org/r/593272

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.35; 2020-06-02); removed MW-1.35-notes (1.35.0-wmf.31; 2020-05-05).May 26 2020, 10:00 PM
gerritbot added a comment.May 26 2020, 10:01 PM

Change 598865 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate Revision::getUserText

https://gerrit.wikimedia.org/r/598865

DannyS712 updated the task description. (Show Details)May 26 2020, 10:06 PM
DannyS712 moved this task from In progress to Awaiting review and deployment on the User-DannyS712 board.
gerritbot added a comment.May 27 2020, 6:29 PM

Change 598865 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate Revision::getUserText, ::isMinor, and ::isCurrent

https://gerrit.wikimedia.org/r/598865

DannyS712 closed this task as Resolved.May 27 2020, 6:35 PM
DannyS712 removed a project: Patch-For-Review.
DannyS712 moved this task from Awaiting review and deployment to Resolved (deprecation) on the User-DannyS712 board.Jul 9 2020, 11:16 PM
Zabe updated the task description. (Show Details)Mar 7 2021, 1:04 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL