⚓ T250580 Hard deprecate Revision::isMinor

Subject	Repo	Branch	Lines +/-
Hard deprecate Revision::getUserText, ::isMinor, and ::isCurrent	mediawiki/core	master	+37 -5
Replace various uses of Revision objects	mediawiki/core	master	+174 -115
Convert WikiPage::$mLastRevision to RevisionRecord	mediawiki/core	master	+13 -12
Add ContribsPager::tryCreatingRevisionRecord	mediawiki/core	master	+80 -15
Convert SpecialMobileHistory::showRow to use RevisionRecord	mediawiki/extensions/MobileFrontend	master	+19 -9

Status	Assigned	Task
Open	None	T11968 Reduce use of global and public variables
Open	None	T159283 Deprecate non-configuration globals
Open	DannyS712	T159299 Deprecate and remove $wgUser
Resolved	DannyS712	T267861 [GOAL] Emit deprecation warnings reading from $wgUser
Open	DannyS712	T243708 Mediawiki core needs uses of global $wgUser removed
Resolved	DannyS712	T246284 Hard deprecate the Revision class
Resolved	DannyS712	T251067 Hard deprecate individual Revision class methods [tracking]
Resolved	DannyS712	T250580 Hard deprecate Revision::isMinor

DannyS712 created this task.Apr 18 2020, 9:14 PM

DannyS712 triaged this task as Medium priority.

DannyS712 moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.

DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.

Change 589932 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/MobileFrontend@master] Convert SpecialMobileHistory::showRow to use RevisionRecord

https://gerrit.wikimedia.org/r/589932

gerritbot added a project: Patch-For-Review.Apr 18 2020, 9:16 PM

@Pchelolo I've addressed the issues you raised on the patch - can you take another look?

Change 592320 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Convert WikiPage::$mLastRevision to RevisionRecord

https://gerrit.wikimedia.org/r/592320

DannyS712 mentioned this in T251067: Hard deprecate individual Revision class methods [tracking].Apr 26 2020, 11:37 PM

DannyS712 removed a parent task: T246284: Hard deprecate the Revision class.Apr 26 2020, 11:39 PM

DannyS712 added a parent task: T251067: Hard deprecate individual Revision class methods [tracking].

Change 592513 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Add ContribsPager::tryCreatingRevisionRecord

https://gerrit.wikimedia.org/r/592513

Change 589932 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Convert SpecialMobileHistory::showRow to use RevisionRecord

https://gerrit.wikimedia.org/r/589932

DannyS712 updated the task description. (Show Details)Apr 27 2020, 10:19 PM

Change 592513 merged by jenkins-bot:
[mediawiki/core@master] Add ContribsPager::tryCreatingRevisionRecord

https://gerrit.wikimedia.org/r/592513

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.30; 2020-04-28).Apr 28 2020, 8:00 AM

Change 592320 merged by jenkins-bot:
[mediawiki/core@master] Convert WikiPage::$mLastRevision to RevisionRecord

https://gerrit.wikimedia.org/r/592320

Maintenance_bot removed a project: Patch-For-Review.Apr 28 2020, 6:11 PM

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.31; 2020-05-05); removed MW-1.35-notes (1.35.0-wmf.30; 2020-04-28).Apr 28 2020, 7:00 PM

Change 593620 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Replace various uses of Revision objects

https://gerrit.wikimedia.org/r/593620

gerritbot added a project: Patch-For-Review.Apr 30 2020, 10:11 PM

Change 593620 merged by jenkins-bot:
[mediawiki/core@master] Replace various uses of Revision objects

https://gerrit.wikimedia.org/r/593620

Maintenance_bot removed a project: Patch-For-Review.May 1 2020, 6:10 PM

Remaining uses in core:

DifferenceEngine - https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/593272/

Core tests: RevisionStoreDbTestBase, RevisionDbTest, RevisionTest

Stalling - cannot proceed until after T250761: DifferenceEngine $mNewRev and $mOldRev are Revision objects is merged

DannyS712 changed the task status from Open to Stalled.May 1 2020, 6:23 PM

Jdlrobson added a project: Web-Team-Backlog-Archived (Tracking).May 4 2020, 11:41 PM

Change 598865 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate Revision::getUserText and Revision::isMinor

https://gerrit.wikimedia.org/r/598865

gerritbot added a project: Patch-For-Review.May 26 2020, 10:13 PM

DannyS712 changed the task status from Stalled to Open.May 26 2020, 10:13 PM

DannyS712 moved this task from In progress to Awaiting review and deployment on the User-DannyS712 board.

Change 598865 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate Revision::getUserText, ::isMinor, and ::isCurrent

https://gerrit.wikimedia.org/r/598865

DannyS712 closed this task as Resolved.May 27 2020, 6:35 PM

DannyS712 removed a project: Patch-For-Review.

DannyS712 moved this task from Awaiting review and deployment to Resolved (deprecation) on the User-DannyS712 board.Jul 9 2020, 11:16 PM