Page MenuHomePhabricator

Delete locales kk-cn, kk-kz, kk-tr from the Kazakh language converter
Open, Needs TriagePublic

Description

Please update the Converter of the Kazakh language
https://meta.wikimedia.org/wiki/Wikipedias_in_multiple_writing_systems#Kazakh_Wikipedia

And can I specify a font for Perso-Arabic (Central Asian branch) since the style used in default fonts is not suitable for the style of writing?

Event Timeline

Hello! It's much easier for people to review your code if you can submit to it Gerrit (our version control system) - https://www.mediawiki.org/wiki/Gerrit/Tutorial

Hello! It's much easier for people to review your code if you can submit to it Gerrit (our version control system) - https://www.mediawiki.org/wiki/Gerrit/Tutorial

I don't have the option to do this in gerrit since I don't have a computer. Can anyone of the people involved in the update files to help with this problem.

Hello! It's much easier for people to review your code if you can submit to it Gerrit (our version control system) - https://www.mediawiki.org/wiki/Gerrit/Tutorial

I don't have the option to do this in gerrit since I don't have a computer. Can anyone of the people involved in the update files to help with this problem.

Other options include https://tools.wmflabs.org/gerrit-patch-uploader/ or just using the gerrit web interface dirctly...

Hello! It's much easier for people to review your code if you can submit to it Gerrit (our version control system) - https://www.mediawiki.org/wiki/Gerrit/Tutorial

I don't have the option to do this in gerrit since I don't have a computer. Can anyone of the people involved in the update files to help with this problem.

Other options include https://tools.wmflabs.org/gerrit-patch-uploader/ or just using the gerrit web interface dirctly...

I couldn't upload the file to gerrit patch uploader please can I do without all this? Is it possible to send the engineer to immediately make changes?

Which engineer?

If you make a patch from the diff on the git repo, you should be able to upload it

Which engineer?

If you make a patch from the diff on the git repo, you should be able to upload it

https://github.com/MuratKaribai/LangConvKk

Which engineer?

If you make a patch from the diff on the git repo, you should be able to upload it

https://github.com/MuratKaribai/LangConvKk

That's no more helpful than the patch (in fact, even less) you put originally

Which engineer?

If you make a patch from the diff on the git repo, you should be able to upload it

https://github.com/MuratKaribai/LangConvKk

That's no more helpful than the patch (in fact, even less) you put originally

Can you help me with this problem? Because I didn't work with git

Which engineer?

If you make a patch from the diff on the git repo, you should be able to upload it

https://github.com/MuratKaribai/LangConvKk

That's no more helpful than the patch (in fact, even less) you put originally

Can you help me with this problem? Because I didn't work with git

Well, in the same way you've just done it with GitHub you can do it with gerrit...

Aklapper changed the task status from Open to Stalled.May 20 2020, 1:22 PM

I tried to see the differences compared to the existing file named LanguageKk.php under mediawiki/core/languages/classes/LanguageKk.php. That seems to be the wrong file so I don't know why the attached file in this ticket is called LanguageKk.php? After finally finding /mediawiki-core/languages/converters/KkConverter.php and running diff to compare with the file attached here, there seem to be a lot of unneeded noisy changes like

-		if ( is_object( $nt ) ) {
+		if(is_object($nt)){

@MuratKaribay: Please create a clean version without unneeded changes and please follow https://www.mediawiki.org/wiki/Gerrit/Tutorial to upload it to Gerrit via https://tools.wmflabs.org/gerrit-patch-uploader/ , so someone could find and review your changes. Attaching a full file is very cumbersome for anyone who wants to try reviewing it. If there are problems with https://tools.wmflabs.org/gerrit-patch-uploader/ then please explain the exact problems so we can help. Thanks in advance!

Aklapper renamed this task from Kazakh language to Update Kazakh language converter.May 20 2020, 1:22 PM

@MuratKaribay: We need a patch. In Gerrit. Not a long file with some changes which nobody can easily find.
Furthermore, this is still quite unreadable. And many changes are unclear to me why they happened.
Please save some time and read and follow my complete previous comment, so we could in theory review this. Only make changes that are absolutely required. Please also see https://www.mediawiki.org/wiki/Gerrit/Code_review/Getting_reviews : "Write small commits". Thank you a lot!

Unfortunately closing this Phabricator task as no patch has been provided. @MuratKaribay: After you have provided a proper patch that can be reviewed (see all previous comments and links), please set the status of this task back to "Open" via the Add Action...Change Status dropdown. Thanks!

MuratKaribay updated the task description. (Show Details)

Change 617296 had a related patch set uploaded (by Murat Karibay; owner: Murat Karibay):
[mediawiki/core@master] Please update Kkconverter and delete the locale such as kk-cn, kk-kz, kk-tr since they are not used at all and they are simply not needed.

https://gerrit.wikimedia.org/r/617296

@Aklapper: Is it possible to speed up the process?
I replied to @VulpesVulpes825 that we are not using options such as kk-cn, kk-tr, kk-kz and that there are many problems due to errors in the converter.

@MuratKaribay: The feedback what to improve in the Gerrit patch needs to be incorporated in an amended patchset version.
For general info, see https://www.mediawiki.org/wiki/Gerrit/Code_review/Getting_reviews - thanks!

@Aklapper: If you are in doubt and do not want to delete locales, then you can ask the administrators of the Kazakh Wikipedia, etc.
I think that they also want to remove unused locales since no one is using them. Due to the use of two methods such as the Cyrl2Latn and Latn2Cyrl methods, in most cases the conversion results in incorrect.
For example, https://drive.google.com/drive/folders/15GWWHH5FkRBUFCA4ssiTQcV7jUhk5UJX?usp=sharing
look at two screenshots on one wikipedia user opened the article and the second unregistered user opened the same article. As you can see, we are in trouble with Latn2Cyrl.

P.S. Marked in red it is written in Latin, or rather in English.

@Aklapper: If you are in doubt and do not want to delete locales, then you can ask the administrators of the Kazakh Wikipedia, etc.

This was already discussed in the Gerrit patch, see the reply / comments there.

I think that they also want to remove unused locales since no one is using them.

You already wrote that in Gerrit, and it was replied that we don't know how you found out that literally nobody on this planet (also outside Wikimedia) is using them. Please see the Gerrit patch.

Inkedimage_2020-09-02_23-00-36_LI.jpg (656×1 px, 877 KB)

@Aklapper: Sometimes autoconverting leads to such problems.

The screenshot is written in English: Create awareness on sports and gender equality in sport inside your community.
Enjoy Wiki Loves Sport 2020!

But the screenshot shows auto-conversion: Цреате ауаренесс он спорт анд гендер еқұалітy ін спорт інсіде ёұр цоммұнітy.
Енжоy Уікі Ловес Спорт 2020!

Is it possible to replace the autoconverter with an offline Converter that will convert in violation of other languages?

Amire80 renamed this task from Update Kazakh language converter to Delete locales kk-cn, kk-kz, kk-tr from the Kazakh language converter.Nov 19 2020, 7:45 AM