Page MenuHomePhabricator

Remove deprecated RCFeedEngine support
Open, Needs TriagePublic

Description

In 2017 (MW 1.27, 39a6e3dc4d) support was added to register an RCFeed backend directly using a class option.

For this task:

  • Complety any unfinished parts of that migration.
  • Updating relevant documentation in code and on mediawiki.org to encourage this method.
  • Reduce the footprint of the old mechanism as much as possible, keeping only config-compat but nothing significant at run-time.
Configuration example
Old way
$wgRCEngines['eg-engine'] = ExampleRCFeed::class;

$wgRCFeeds['eg-feed'] = [
  'uri' => 'eg-engine://bogus',
  
];
New way
$wgRCFeeds['eg-feed'] = [
  'class' => ExampleRCFeed::class,
  
];

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 590684 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] rcfeed: Deprecate $wgRCEngines and RCFeedEngine

https://gerrit.wikimedia.org/r/590684

Change 590701 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/EventBus@master] tests: Remove use of deprecated wgRCEngines

https://gerrit.wikimedia.org/r/590701

@Milimetric The above finishes the deprecation we started as part of setting up the EventBus/EventStreams consumer of RCFeed. Afaik this area of MW is currently unstewarded and only used for EventStreams and irc.wm.o in prod. I could use a code reviewer - not sure who else to ask :)

It seems to me we should do this kind of thing via Kafka as opposed to bothering MediaWiki with it. If it was up to me, I'd remove this from core and let folks implement it as an extension if they're interested. And send out recent changes in whatever format people need via a simple stream processor.

Restricted Application edited projects, added Analytics; removed Analytics-Radar. · View Herald TranscriptJun 10 2020, 6:33 AM
Restricted Application edited projects, added Analytics; removed Analytics-Radar. · View Herald TranscriptJun 10 2020, 6:36 AM

Change 767851 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@master] rcfeed: Hard-deprecate $wgRCEngines entry without 'class'

https://gerrit.wikimedia.org/r/767851

Change 767851 merged by jenkins-bot:

[mediawiki/core@master] rcfeed: Allow easy mocking of RCFeed::factory objects

https://gerrit.wikimedia.org/r/767851

Change 590701 merged by jenkins-bot:

[mediawiki/extensions/EventBus@master] tests: Remove use of deprecated wgRCEngines

https://gerrit.wikimedia.org/r/590701

Change 590684 merged by jenkins-bot:

[mediawiki/core@master] rcfeed: Deprecate $wgRCEngines and RCFeedEngine

https://gerrit.wikimedia.org/r/590684