Page MenuHomePhabricator
Create Task
Maniphest T250638

Replace uses and hard deprecate WikiPage::doEditContent and PageUpdater::getStatus
Closed, DeclinedPublic
Actions

Description

Soft deprecated in favor of PageUpdater::saveRevision since 1.32
Returned status can include Revision objects
If a user isn't passed, falls back to $wgUser

Widely used: https://codesearch.wmflabs.org/deployed/?q=-%3EdoEditContent%5C(&i=nope&files=&repos=

The inclusion of Revision objects comes from the underlying call to PageUpdater::getStatus, which includes Revision objects. That method is tagged as @note This is here for compatibility with WikiPage::doEditContent. It may be deprecated soon.

Details

SubjectRepoBranchLines +/-
Un-deprecate `WikiPage::doEditContent`mediawiki/coremaster+4 -4
PageUpdater: Inject a permission manager, automatically apply autopatrolmediawiki/coremaster+55 -20
Replace deprecated WikiPage::doEditContent() with a PageUpdatermediawiki/extensions/FileImportermaster+25 -17
Remove use of WikiPage::doEditContent and the Revision object returnedmediawiki/extensions/CentralNoticemaster+17 -17
Replace use of WikiPage::doEditContent with PageUpdatermediawiki/extensions/NewUserMessagemaster+10 -7
Replace use of WikiPage::doEditContent with PageUpdatermediawiki/extensions/SecurePollmaster+55 -26
Replace use of WikiPage::doEditContent with PageUpdatermediawiki/extensions/GWToolsetmaster+11 -6
Replace use of WikiPage::doEditContent with PageUpdatermediawiki/extensions/CheckUsermaster+9 -2
Replace use of WikiPage::doEditContent with PageUpdatermediawiki/extensions/SpamBlacklistmaster+4 -4
Replace use of WikiPage::doEditContent with PageUpdatermediawiki/extensions/PageTriagemaster+17 -6
Introduce DeprecatablePropertyArray and use it for PageUpdatermediawiki/coremaster+210 -2
Remove use of WikiPage::doEditContentmediawiki/extensions/Thanksmaster+10 -26
Make MessageCacheTest::makePage private, return RevisionRecordmediawiki/coremaster+15 -7
TestStorageHelper: Replace saveJudgment with updateJudgementmediawiki/extensions/Jademaster+0 -0
TestStorageHelper: Replace createEntity with createNewEntitymediawiki/extensions/Jademaster+132 -92
Remove use of WikiPage::doEditContentmediawiki/extensions/WikimediaMaintenancemaster+23 -10
Remove use of WikiPage::doEditContentmediawiki/extensions/TemplateStylesmaster+13 -4
Remove use of WikiPage::doEditContentmediawiki/extensions/UploadWizardmaster+13 -7
Remove use of WikiPage::doEditContentmediawiki/extensions/Babelmaster+11 -8
Remove uses of WikiPage::doEditContentmediawiki/extensions/Translatemaster+217 -105
Show related patches Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT11968 Reduce use of global and public variables
 OpenNoneT159283 Deprecate non-configuration globals
 OpenDannyS712T159299 Deprecate and remove $wgUser
 ResolvedDannyS712T267861 [GOAL] Emit deprecation warnings reading from $wgUser
 OpenDannyS712T243708 Mediawiki core needs uses of global $wgUser removed
 ResolvedDannyS712T242935 Deprecate core fallbacks to $wgUser
 ResolvedDannyS712T246284 Hard deprecate the Revision class
 ResolvedDannyS712T248291 Hard deprecate not passing a user to Revision::get methods with Revision::FOR_THIS_USER
 ResolvedDannyS712T249393 Deprecate methods returning Revision objects
 Declined• PcheloloT250638 Replace uses and hard deprecate WikiPage::doEditContent and PageUpdater::getStatus
 ResolvedDannyS712T252179 Edits saved via PageUpdater need autopatrol status set
 ResolvedDannyS712T249434 Replace hooks using Revision objects with RevisionRecord
 ResolvedDannyS712T248727 Replace ArticleRevisionUndeleted with RevisionUndeleted
 ResolvedDannyS712T232877 The "RevisionInsertComplete" hook is listed in documentation as deprecated but doesn't emit deprecation warnings yet
 ResolvedDannyS712T250023 Replace TitleMoveComplet(e|ing) hooks
 ResolvedDannyS712T250338 Replace `NewRevisionFromEditComplete` with a new hook
 ResolvedDannyS712T250543 Replace `ArticleRollbackComplete` hook
 ResolvedDannyS712T250566 Replace PageContent(Insert|Save)Complete hooks
 ResolvedDannyS712T255494 Replace `HistoryRevisionTools` hook with `HistoryTools`
 ResolvedDannyS712T255495 Replace `DiffRevisionTools` hook with `DiffTools`
 ResolvedDannyS712T255769 Replace `DiffViewHeader` hook with one that doesn't use Revision objects
 ResolvedDannyS712T249561 Deprecate methods accepting Revision objects as parameters
 ResolvedDannyS712T249563 Hard deprecate Revision use in WikiPage::doEditUpdates
 ResolvedDannyS712T249397 Replace LinksUpdate Revision methods with RevisionRecord
 ResolvedDannyS712T250318 Hard deprecate WikiPage::updateIfNewerOn
 ResolvedDannyS712T250680 Hard deprecate WikiPage::getUndoContent
 ResolvedDannyS712T250773 Hard deprecate support for Revisions from ContentHandler::getUndoContent
 ResolvedDannyS712T255759 Hard deprecate passing a Revision to WikiPage::prepareContentForEdit
 ResolvedDannyS712T255909 DerivedPageDataUpdater::prepareUpdate $options array can include Revision objects
 ResolvedDannyS712T250761 DifferenceEngine $mNewRev and $mOldRev are Revision objects
 ResolvedDannyS712T250976 Deprecate access to Article::$mRevision
 ResolvedDannyS712T251067 Hard deprecate individual Revision class methods [tracking]
 ResolvedDannyS712T250981 Hard deprecate Revision::getContent(Model|Handler|Format)
 ResolvedDannyS712T250579 Hard deprecate Revision::getUserText
 ResolvedDannyS712T250580 Hard deprecate Revision::isMinor
 ResolvedDannyS712T250608 Hard deprecate Revision::isCurrent
 ResolvedDannyS712T249183 Hard deprecate Revision::newFromTitle
 ResolvedDannyS712T249979 Hard deprecate Revision::newNullRevision
 ResolvedDannyS712T248772 Hard deprecate Revision::newFromArchiveRow
 ResolvedDannyS712T249021 Hard deprecate Revision::newFromId
 ResolvedDannyS712T250980 Hard deprecate Revision::getParentId
 ResolvedDannyS712T250714 Hard deprecate Revision::getVisibility
 ResolvedDannyS712T247259 Remove remaining calls and hard deprecate Revision::userCan
 ResolvedDannyS712T246414 Audit all userCan calls
 ResolvedDannyS712T251073 Hard deprecate Revision::getPrevious
 ResolvedDannyS712T245958 Revision::userCanBitfield falls back to $wgUser
 ResolvedDannyS712T251233 Hard deprecate Revision::getSha1
 ResolvedDannyS712T251593 Hard deprecate Revision::isDeleted
 ResolvedDannyS712T251853 Hard deprecate Revision::getPage
 ResolvedDannyS712T251856 Hard deprecate Revision::insertOn
 ResolvedDannyS712T254703 Hard deprecate Revision::getContent
 ResolvedDannyS712T254960 Hard deprecate Revision::getComment
 ResolvedDannyS712T254964 Hard deprecate Revision::getSize
 ResolvedDannyS712T254966 Hard deprecate Revision::getTimestamp
 ResolvedDannyS712T257010 Replace deployed uses of Revision constants
 ResolvedDannyS712T257011 Audit and remove extension `use Revision;` declarations where possible
 ResolvedDannyS712T257531 Cleanup forgotten usages of Revision

Event Timeline

DannyS712 renamed this task from Hard deprecate WikiPage::doEditContent to Replace uses and hard deprecate WikiPage::doEditContent.Apr 19 2020, 11:38 PM
DannyS712 triaged this task as Medium priority.
DannyS712 created this task.
DannyS712 moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.
DannyS712 added a project: patch-welcome.
DannyS712 renamed this task from Replace uses and hard deprecate WikiPage::doEditContent to Replace uses and hard deprecate WikiPage::doEditContent and PageUpdater::getStatus.Apr 19 2020, 11:46 PM
DannyS712 updated the task description. (Show Details)
gerritbot added a comment.Apr 19 2020, 11:57 PM

Change 590749 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/WikimediaMaintenance@master] Remove use of WikiPage::doEditContent

https://gerrit.wikimedia.org/r/590749

gerritbot added a project: Patch-For-Review.Apr 19 2020, 11:57 PM
DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.Apr 20 2020, 12:07 AM
DannyS712 added a parent task: T242935: Deprecate core fallbacks to $wgUser.Apr 20 2020, 12:11 AM
DannyS712 updated the task description. (Show Details)
gerritbot added a comment.Apr 20 2020, 12:12 AM

Change 590757 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/UploadWizard@master] Remove use of WikiPage::doEditContent

https://gerrit.wikimedia.org/r/590757

gerritbot added a comment.Apr 20 2020, 12:22 AM

Change 590762 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/TemplateStyles@master] Remove use of WikiPage::doEditContent

https://gerrit.wikimedia.org/r/590762

gerritbot added a comment.Apr 20 2020, 7:05 PM

Change 590762 merged by jenkins-bot:
[mediawiki/extensions/TemplateStyles@master] Remove use of WikiPage::doEditContent

https://gerrit.wikimedia.org/r/590762

gerritbot added a comment.Apr 20 2020, 7:06 PM

Change 590757 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@master] Remove use of WikiPage::doEditContent

https://gerrit.wikimedia.org/r/590757

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.30; 2020-04-28).Apr 20 2020, 9:00 PM
gerritbot added a comment.Apr 24 2020, 6:27 AM

Change 592392 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Thanks@master] ApiCoreThankIntegrationTest: Remove use of WikiPage::doEditContent

https://gerrit.wikimedia.org/r/592392

gerritbot added a comment.Apr 27 2020, 8:56 PM

Change 592762 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/SpamBlacklist@master] Remove use of WikiPage::doEditContent

https://gerrit.wikimedia.org/r/592762

gerritbot added a comment.Apr 27 2020, 9:06 PM

Change 590749 merged by jenkins-bot:
[mediawiki/extensions/WikimediaMaintenance@master] Remove use of WikiPage::doEditContent

https://gerrit.wikimedia.org/r/590749

gerritbot added a comment.Apr 28 2020, 4:38 AM

Change 592807 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Translate@master] Remove uses of WikiPage::doEditContent

https://gerrit.wikimedia.org/r/592807

gerritbot added a comment.Apr 29 2020, 2:58 AM

Change 593090 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Make MessageCacheTest::makePage private, return RevisionRecord

https://gerrit.wikimedia.org/r/593090

gerritbot added a comment.May 4 2020, 8:30 AM

Change 592807 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Remove uses of WikiPage::doEditContent

https://gerrit.wikimedia.org/r/592807

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.31; 2020-05-05); removed MW-1.35-notes (1.35.0-wmf.30; 2020-04-28).May 4 2020, 9:01 AM
gerritbot added a comment.May 4 2020, 6:19 PM

Change 594258 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Babel@master] Remove use of WikiPage::doEditContent

https://gerrit.wikimedia.org/r/594258

gerritbot added a comment.May 4 2020, 6:23 PM

Change 594260 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CheckUser@master] Remove use of WikiPage::doEditContent

https://gerrit.wikimedia.org/r/594260

gerritbot added a comment.May 4 2020, 6:25 PM

Change 594262 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/FileImporter@master] Remove use of WikiPage::doEditContent

https://gerrit.wikimedia.org/r/594262

gerritbot added a comment.May 4 2020, 6:28 PM

Change 594263 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/NewUserMessage@master] Remove use of WikiPage::doEditContent

https://gerrit.wikimedia.org/r/594263

gerritbot added a comment.May 4 2020, 9:14 PM

Change 594312 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/SecurePoll@master] Remove use of WikiPage::doEditContent

https://gerrit.wikimedia.org/r/594312

gerritbot added a comment.May 4 2020, 9:36 PM

Change 594314 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/PageTriage@master] Remove use of WikiPage::doEditContent

https://gerrit.wikimedia.org/r/594314

gerritbot added a comment.May 4 2020, 9:41 PM

Change 594315 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/GWToolset@master] Remove use of WikiPage::doEditContent

https://gerrit.wikimedia.org/r/594315

gerritbot added a comment.May 5 2020, 2:40 AM

Change 594342 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CentralNotice@master] Remove use of WikiPage::doEditContent and the Revision object returned

https://gerrit.wikimedia.org/r/594342

gerritbot added a comment.May 5 2020, 2:51 AM

Change 594343 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Jade@master] TestStorageHelper: Replace createEntity with createNewEntity

https://gerrit.wikimedia.org/r/594343

gerritbot added a comment.May 5 2020, 12:42 PM

Change 594258 merged by jenkins-bot:
[mediawiki/extensions/Babel@master] Remove use of WikiPage::doEditContent

https://gerrit.wikimedia.org/r/594258

DannyS712 added a subtask: T252179: Edits saved via PageUpdater need autopatrol status set.May 7 2020, 11:53 PM
Krinkle subscribed.May 8 2020, 12:14 AM
@DannyS712 wrote at T252179:

When changing WikiPage::doEditContent to use page updaters, I missed the fact that the former automatically added autopatrol status, while the latter doesn't.

WikiPage.php
	 * @deprecated since 1.32, use PageUpdater::saveRevision instead. Note that the new method
	 * expects callers to take care of checking EDIT_MINOR against the minoredit right, and to
	 * apply the autopatrol right as appropriate.
	 *

This does not make sense to me. Callers like Babel, UploadWizard, Translate etc must never concern themselves with these internal details of core.

If this is the only non-deprecated method to save edits in this way, then it should be un-deprecated. Let's revert these for now (tracked via T252179), and think about this some more. Copying this logic everywhere is imho not an acceptable solution, not even temporarily.

Krinkle mentioned this in T252179: Edits saved via PageUpdater need autopatrol status set.May 8 2020, 12:15 AM
DannyS712 added a comment.May 8 2020, 1:05 AM
In T250638#6118056, @Krinkle wrote:
@DannyS712 wrote at T252179:

When changing WikiPage::doEditContent to use page updaters, I missed the fact that the former automatically added autopatrol status, while the latter doesn't.

WikiPage.php
	 * @deprecated since 1.32, use PageUpdater::saveRevision instead. Note that the new method
	 * expects callers to take care of checking EDIT_MINOR against the minoredit right, and to
	 * apply the autopatrol right as appropriate.
	 *

This does not make sense to me. Callers like Babel, UploadWizard, Translate etc must never concern themselves with these internal details of core.

If this is the only non-deprecated method to save edits in this way, then it should be un-deprecated. Let's revert these for now (tracked via T252179), and think about this some more. Copying this logic everywhere is imho not an acceptable solution, not even temporarily.

As far as I can tell, there is only 1 place that a PageUpdater is constructed, and it has no subclasses. Perhaps inject a PermissionManager as well?

Minor edit is determined by passing EDIT_MINOR as one of the flags to saveRevision(), but autopatrol is only done via setRcPatrolStatus. I suggest:

  • Inject a permission manager
  • Automatically handle setting autopatrol
  • Deprecate and then remove setRcPatrolStatus

This does not affect handling minor edit rights (yet)

Either at the same time or later:

  • If the flags contain EDIT_MINOR, check permissions; if the user lacks permission
    • Ignore the minor flag?
    • Error?
DannyS712 closed subtask T252179: Edits saved via PageUpdater need autopatrol status set as Resolved.May 11 2020, 4:57 PM
gerritbot added a comment.May 11 2020, 6:38 PM

Change 595609 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] PageUpdater: Inject a permission manager, automatically apply autopatrol

https://gerrit.wikimedia.org/r/595609

gerritbot added a comment.May 11 2020, 10:33 PM

Change 594343 merged by jenkins-bot:
[mediawiki/extensions/Jade@master] TestStorageHelper: Replace createEntity with createNewEntity

https://gerrit.wikimedia.org/r/594343

gerritbot added a comment.May 11 2020, 10:36 PM

Change 595667 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Jade@master] TestStorageHelper: Replace saveJudgment with updateJudgement

https://gerrit.wikimedia.org/r/595667

Krinkle added a subscriber: daniel.May 11 2020, 10:39 PM
In T250638#6126194, @gerritbot wrote:

Change 595609 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] PageUpdater: Inject a permission manager, automatically apply autopatrol

https://gerrit.wikimedia.org/r/595609

Has it been decided then to make PageUpdater responsible for everything? Is that something we want to support long-term?

I believe @daniel omitted it with the intent to keep PageUpdater more separate from the higher-level logic. The problem we surfaced here is that there needs to be a unified and central way to decide how edit meta-data is derived from the user and other context stuff.

We already have numerous of such abstractions in WikiPage and EditPage. Has it been considered to migrate toward one of those? And/or to undeprecate or rename doEditPage to be that better entrypoint? Or do we really want to move it all to PageUpdater?

I don't have a preference here, I just want to make sure we don't blindly follow my (unintended) suggestion for Danny to move it there.

gerritbot added a comment.May 11 2020, 10:53 PM

Change 595667 abandoned by DannyS712:
TestStorageHelper: Replace saveJudgment with updateJudgement

Reason:
Messed up, will redo when I have a chance

https://gerrit.wikimedia.org/r/595667

DannyS712 added a comment.EditedMay 11 2020, 11:01 PM
In T250638#6127322, @Krinkle wrote:
In T250638#6126194, @gerritbot wrote:

Change 595609 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] PageUpdater: Inject a permission manager, automatically apply autopatrol

https://gerrit.wikimedia.org/r/595609

Has it been decided then to make PageUpdater responsible for everything? Is that something we want to support long-term?

I believe @daniel omitted it with the intent to keep PageUpdater more separate from the higher-level logic. The problem we surfaced here is that there needs to be a unified and central way to decide how edit meta-data is derived from the user and other context stuff.

We already have numerous of such abstractions in WikiPage and EditPage. Has it been considered to migrate toward one of those? And/or to undeprecate or rename doEditPage to be that better entrypoint? Or do we really want to move it all to PageUpdater?

I don't have a preference here, I just want to make sure we don't blindly follow my (unintended) suggestion for Danny to move it there.

doEditContent returns information that includes a Revision object, and for that to be deprecated doEditContent likewise needs to be deprecated.

Also, the current interface for saving an edit via EditPage is horrible (hence T157658: Factor out a backend from EditPage) so trying to use that would be more problematic

gerritbot added a comment.May 22 2020, 6:13 PM

Change 593090 merged by jenkins-bot:
[mediawiki/core@master] Make MessageCacheTest::makePage private, return RevisionRecord

https://gerrit.wikimedia.org/r/593090

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.34; 2020-05-26); removed MW-1.35-notes (1.35.0-wmf.31; 2020-05-05).May 22 2020, 7:00 PM
DannyS712 mentioned this in T246284: Hard deprecate the Revision class.May 27 2020, 11:01 PM
daniel added a comment.May 28 2020, 3:00 PM

doEditContent returns information that includes a Revision object, and for that to be deprecated doEditContent likewise needs to be deprecated.

We could make the value in the Status object be an ArrayAccess instance that triggers a warning when something tries to access the "revision" key, rather than the "revision-record" key.

DannyS712 added a comment.May 29 2020, 9:56 PM
In T250638#6173016, @daniel wrote:

doEditContent returns information that includes a Revision object, and for that to be deprecated doEditContent likewise needs to be deprecated.

We could make the value in the Status object be an ArrayAccess instance that triggers a warning when something tries to access the "revision" key, rather than the "revision-record" key.

No idea how to do that

• Pchelolo claimed this task.Jun 3 2020, 3:23 AM
gerritbot added a comment.Jun 3 2020, 4:39 PM

Change 602115 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/core@master] WIP: Introduce DeprecatablePropertyArray and use it for PageUpdater

https://gerrit.wikimedia.org/r/602115

gerritbot added a comment.Jun 5 2020, 5:14 PM

Change 592392 merged by jenkins-bot:
[mediawiki/extensions/Thanks@master] Remove use of WikiPage::doEditContent

https://gerrit.wikimedia.org/r/592392

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.36; 2020-06-09); removed MW-1.35-notes (1.35.0-wmf.34; 2020-05-26).Jun 5 2020, 6:00 PM
gerritbot added a comment.Jun 9 2020, 4:13 PM

Change 602115 merged by jenkins-bot:
[mediawiki/core@master] Introduce DeprecatablePropertyArray and use it for PageUpdater

https://gerrit.wikimedia.org/r/602115

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.37; 2020-06-16); removed MW-1.35-notes (1.35.0-wmf.36; 2020-06-09).Jun 9 2020, 5:00 PM
DannyS712 added a comment.Jun 9 2020, 9:42 PM

@Pchelolo should this be declined in favor of removing uses of the returned Revision object?

• Pchelolo added a comment.Jun 9 2020, 9:46 PM

Yeah. I believe removing the 'revision' key in the status value overall would be easier then dropping the doEditContent completely.

DannyS712 closed this task as Declined.Jun 9 2020, 9:49 PM
gerritbot added a comment.Jun 9 2020, 11:09 PM

Change 594314 abandoned by DannyS712:
Replace use of WikiPage::doEditContent with PageUpdater

https://gerrit.wikimedia.org/r/594314

gerritbot added a comment.Jun 9 2020, 11:10 PM

Change 592762 abandoned by DannyS712:
Replace use of WikiPage::doEditContent with PageUpdater

https://gerrit.wikimedia.org/r/592762

gerritbot added a comment.Jun 9 2020, 11:10 PM

Change 594260 abandoned by DannyS712:
Replace use of WikiPage::doEditContent with PageUpdater

https://gerrit.wikimedia.org/r/594260

gerritbot added a comment.Jun 9 2020, 11:10 PM

Change 594315 abandoned by DannyS712:
Replace use of WikiPage::doEditContent with PageUpdater

https://gerrit.wikimedia.org/r/594315

gerritbot added a comment.Jun 9 2020, 11:10 PM

Change 594312 abandoned by DannyS712:
Replace use of WikiPage::doEditContent with PageUpdater

https://gerrit.wikimedia.org/r/594312

gerritbot added a comment.Jun 9 2020, 11:11 PM

Change 594263 abandoned by DannyS712:
Replace use of WikiPage::doEditContent with PageUpdater

https://gerrit.wikimedia.org/r/594263

gerritbot added a comment.Jun 9 2020, 11:11 PM

Change 594342 abandoned by DannyS712:
Remove use of WikiPage::doEditContent and the Revision object returned

https://gerrit.wikimedia.org/r/594342

DannyS712 mentioned this in T255177: Tests failing for the master branch of MassMessage.Jun 11 2020, 6:38 PM
DannyS712 mentioned this in T255507: WikiPage::doEditContent falls back to $wgUser.Jun 15 2020, 10:54 PM

Method is currently soft deprecated - should it be un-deprecated then?

DannyS712 removed projects: Patch-For-Review, patch-welcome.Jun 15 2020, 10:55 PM
gerritbot added a comment.Jun 15 2020, 10:56 PM

Change 605692 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Un-deprecate WikiPage::doEditContent

https://gerrit.wikimedia.org/r/605692

gerritbot added a project: Patch-For-Review.Jun 15 2020, 10:56 PM
DannyS712 mentioned this in T255614: PHP Notice: Object of class MediaWiki\Debug\DeprecatablePropertyArray could not be converted to int.Jun 16 2020, 9:26 PM
gerritbot added a comment.Jun 20 2020, 10:10 AM

Change 594262 abandoned by DannyS712:
Replace deprecated WikiPage::doEditContent() with a PageUpdater

Reason:
no longer needed

https://gerrit.wikimedia.org/r/594262

gerritbot added a comment.Jun 20 2020, 10:10 AM

Change 595609 abandoned by DannyS712:
PageUpdater: Inject a permission manager, automatically apply autopatrol

Reason:
no longer needed

https://gerrit.wikimedia.org/r/595609

gerritbot added a comment.Sep 15 2020, 12:48 AM

Change 605692 abandoned by DannyS712:
[mediawiki/core@master] Un-deprecate WikiPage::doEditContent

Reason:
per task

https://gerrit.wikimedia.org/r/605692

• Demian removed a project: Patch-For-Review.Nov 2 2020, 11:53 PM
• Demian subscribed.

All merged it seems to me.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL