Page MenuHomePhabricator

WikiEditor buttons should have IDs
Closed, DeclinedPublic

Description

On IRC, it was requested that the buttons in the enhanced toolbar have IDs so they can be manipulated in JS. We could use the keys in the configuration object to generate these IDs.


Version: unspecified
Severity: enhancement

Details

Reference
bz23065

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:09 PM
bzimport added a project: WikiEditor.
bzimport set Reference to bz23065.

I'd like sections and groups to have ids too, if it's not too much of a pain.

*Mass-change: Move WikiEditor bugs to component and remove blocker bug where*

I'm a little suspicious about this, because it's designed to help people do something they shouldn't be doing - modifying the toolbar without using the toolbar API. They should instead be adding features to the API if they need to do something they can't do yet.

I consider this equivalent to adding an API call to MediaWiki that let you remotely call any procedure you like. Not a good idea. (yes, the analogy isn't perfect, but hopefully it gets my point across)

On second thought, I agree.

Marking wontfix. Feel free to re-open with a rationale / use case.