Caused-by lines apparently picking up everything that is concatenated
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Daimona
	Apr 20 2020, 11:32 AM

Description

From T250630, see issue in SpecialMobileDiff: the bad call is listGroups(), but everything before that appears in the caused-by.

Details

	Subject	Repo	Branch	Lines +/-
	Track what taintedness is involved in all caused-by lines	mediawiki/tools/phan/SecurityCheckPlugin	master	+246 -126

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Bawolff	T203652 Fix caused-by lines in phan-taint-check
		Resolved		Daimona	T250679 Caused-by lines apparently picking up everything that is concatenated

Event Timeline

Daimona created this task.Apr 20 2020, 11:32 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 20 2020, 11:32 AM

Daimona claimed this task.Apr 20 2020, 3:09 PM

Change 592448 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/tools/phan/SecurityCheckPlugin@master] [WIP] Track what taintedness is involved in all caused-by lines

https://gerrit.wikimedia.org/r/592448

gerritbot added a project: Patch-For-Review.Apr 25 2020, 1:58 PM

Daimona added a parent task: T203652: Fix caused-by lines in phan-taint-check.Jul 7 2020, 5:37 PM

Daimona moved this task from Backlog to Plugin itself on the phan-taint-check-plugin board.Jul 9 2020, 4:00 PM

Daimona mentioned this in rMTPSa23e0b4bf9e0: Collect causedby properties in arrays, not string.Nov 20 2020, 6:53 AM

Change 592448 merged by jenkins-bot:
[mediawiki/tools/phan/SecurityCheckPlugin@master] Track what taintedness is involved in all caused-by lines

https://gerrit.wikimedia.org/r/592448

Daimona closed this task as Resolved.Nov 20 2020, 5:24 PM

Daimona removed a project: Patch-For-Review.

Daimona mentioned this in rMTPSb20dfc18c4a9: Track what taintedness is involved in all caused-by lines.Nov 20 2020, 5:27 PM