- Open "Empty" in standalone demo, or an empty page in MediaWiki VisualEditor
- Press Ctrl+B, type "foo<enter>bar"
- Observe that the "b" never appears, and by the time you type "r" there is an exception thrown
Description
Description
Details
Details
Related Objects
Related Objects
- Mentioned Here
- rGVEDe571a9e73cd4: Merge "rebaser: Enforce no-var"
Event Timeline
Comment Actions
Bisect blames this on the TreeModifier commit: https://gerrit.wikimedia.org/r/#/c/VisualEditor/VisualEditor/+/357171/
Comment Actions
Ah, i see ... with TreeModifier, pressing Enter at the end of a paragraph leaves that paragraph unchanged (whereas before TreeModifier, it was getting rebuilt entirely). Then it moves the focus into the new paragraph below. That means we're escaping the paragraph without cleaning up the unicorns, which the current code assumes to be impossible.
That's not a very safe assumption in any case: some IME probably has a different way of violating it.
Comment Actions
Change 592398 had a related patch set uploaded (by Divec; owner: Divec):
[VisualEditor/VisualEditor@master] Cleanup unicorns even in another content branch node
Comment Actions
Change 592398 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Cleanup unicorns even in another content branch node
Comment Actions
Change 592698 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (e571a9e73)
Comment Actions
Change 592698 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (e571a9e73)