Page MenuHomePhabricator

Call to undefined method MediaWiki\Revision\RevisionStoreRecord::getTitle()
Closed, ResolvedPublicPRODUCTION ERROR

Description

Error

MediaWiki version: 1.35.0-wmf.28

message
Call to undefined method MediaWiki\Revision\RevisionStoreRecord::getTitle()

Impact

Unable to edit old massmessage lists.

Notes

Caused by https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MassMessage/+/576532/

Details

Request ID
Xp3DUQpAMNIAAVIybhQAAADM
Request URL
https://en.wikipedia.org/w/index.php?title=Special:EditMassMessageList/Wikipedia:Scripts%2B%2B/Subscribe&oldid=949856825
Stack Trace
exception.trace
#0 /srv/mediawiki/php-1.35.0-wmf.28/includes/specialpage/FormSpecialPage.php(175): MediaWiki\MassMessage\SpecialEditMassMessageList->setParameter(string)
#1 /srv/mediawiki/php-1.35.0-wmf.28/extensions/MassMessage/includes/SpecialEditMassMessageList.php(54): FormSpecialPage->execute(string)
#2 /srv/mediawiki/php-1.35.0-wmf.28/includes/specialpage/SpecialPage.php(576): MediaWiki\MassMessage\SpecialEditMassMessageList->execute(string)
#3 /srv/mediawiki/php-1.35.0-wmf.28/includes/specialpage/SpecialPageFactory.php(618): SpecialPage->run(string)
#4 /srv/mediawiki/php-1.35.0-wmf.28/includes/MediaWiki.php(299): MediaWiki\SpecialPage\SpecialPageFactory->executePath(Title, RequestContext)
#5 /srv/mediawiki/php-1.35.0-wmf.28/includes/MediaWiki.php(973): MediaWiki->performRequest()
#6 /srv/mediawiki/php-1.35.0-wmf.28/includes/MediaWiki.php(535): MediaWiki->main()
#7 /srv/mediawiki/php-1.35.0-wmf.28/index.php(47): MediaWiki->run()
#8 /srv/mediawiki/w/index.php(3): require(string)
#9 {main}

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 591087 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/MassMessage@master] Follow up Ia13ace145174b307436fd8a15c74a883e5384885: Fix RevisionRecord checks

https://gerrit.wikimedia.org/r/591087

Can someone with logstash access please add the stacktrace to confirm? I suspect the underlying error is:
Error from line 86 of /srv/mediawiki/php-master/extensions/MassMessage/includes/SpecialEditMassMessageList.php: Call to undefined method MediaWiki\Revision\RevisionRecord::getTitle()

Urbanecm renamed this task from Unable to edit old versions of mass message lists to Call to undefined method MediaWiki\Revision\RevisionStoreRecord::getTitle().Apr 20 2020, 3:53 PM

Bug was in wmf.25, but there is no column for that in Wikimedia-production-error

Urbanecm moved this task from Untriaged to Apr 2020 on the Wikimedia-production-error board.

Change 591089 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/MassMessage@wmf/1.35.0-wmf.28] Follow up 95c772864: Fix RevisionRecord calls that differ from Revision

https://gerrit.wikimedia.org/r/591089

Change 591087 merged by jenkins-bot:
[mediawiki/extensions/MassMessage@master] Follow up 95c772864: Fix RevisionRecord calls that differ from Revision

https://gerrit.wikimedia.org/r/591087

Change 591089 merged by jenkins-bot:
[mediawiki/extensions/MassMessage@wmf/1.35.0-wmf.28] Follow up 95c772864: Fix RevisionRecord calls that differ from Revision

https://gerrit.wikimedia.org/r/591089

Mentioned in SAL (#wikimedia-operations) [2020-04-20T18:36:06Z] <jforrester@deploy1001> Synchronized php-1.35.0-wmf.28/extensions/MassMessage/includes/SpecialEditMassMessageList.php: T250710 Follow-up 95c772864: Fix RevisionRecord calls that differ from Revision (duration: 01m 02s)