Page MenuHomePhabricator

Improve app usability on Chrome OS
Closed, ResolvedPublic

Description

  • Table of contents is removed when app is resized
  • Unable to right click on text using trackpad/mouse
  • Unable to navigate to the search button using Tab/arrow keys
  • Cannot use keys to move through initial screen

Fulfil the feature request where the cursor changes on clickable areas if you quickly/easily can, but otherwise let it alone.

A Google doc with animated screenshots and precise reproduction steps of all these bugs lives here: https://docs.google.com/document/d/1M8zUaL-MvTr6-2nwHVu4h_JonxdTv4xbyz09RuMjyr4/edit#

Suggested documentation from Google:

Optimizing App for Input on Chrome OS Devices:
https://developer.android.com/topic/arc/input-compatibility

General Android apps on Chrome OS optimization Documentation:
https://developer.android.com/topic/arc/optimizing

Google Codelab on Window Management Optimization:
https://codelabs.developers.google.com/codelabs/chromeos-resizing/index.html?index=..%2F..index#0

Android App resizing
https://codelabs.developers.google.com/codelabs/chromeos-resizing/index.html?index=..%2F..index#0

Event Timeline

Hi @schoenbaechler, the bottomsheet is showing incorrectly on the small window mode of the Wikipedia app on the Chromebook.

The image below shows the "standard" vs "current" width of the bottomsheet component.

Screenshot 2020-05-26 at 4.23.55 PM.png (1×1 px, 759 KB)

Left: standard width
Right: 480dp width

Screenshot 2020-05-26 at 4.25.23 PM.png (1×2 px, 560 KB)

Keep 480dp on the large screen

Screenshot 2020-05-26 at 4.24.25 PM.png (1×2 px, 685 KB)

Standard width on the large screen


Question: since we already have the full-width bottomsheet in the suggested edits edit screen (SE -> add description -> bottomsheet), would it be better if we apply it to globally?

@cooltey

Question: since we already have the full-width bottomsheet in the suggested edits edit screen (SE -> add description -> bottomsheet), would it be better if we apply it to globally?

Yes let’s globally apply the stretch to full width. Thx for checking.

Table of contents is removed when app is resized

It is no longer reproducible, updated the ticket description.

@Charlotte and @schoenbaechler

Unable to right click on text using trackpad/mouse

The right-click event on the Webview is pretty tricky here and looks like it is not possible to show the standard floating toolbar when selecting text and right-clicking on the selected text, and the floating toolbar class is not public (https://android.googlesource.com/platform/frameworks/base/+/534a67c/core/java/android/webkit/SelectActionModeCallback.java).

I have a simple solution that would work for the issue on Webview, which is showing a PopupMenu with minimum support of actions (e.g. Copy, Define, Share...) and without other stuff like Translate.

Screenshot 2020-06-03 at 4.20.38 PM.png (1×1 px, 531 KB)

Screenshot 2020-06-03 at 4.21.14 PM.png (1×1 px, 484 KB)

@cooltey, using a PopupMenu for it is a good solution. For clarification, which exact options won’t be available in the popup? Is it → Select all and Translate ?

@schoenbaechler

@cooltey, using a PopupMenu for it is a good solution. For clarification, which exact options won’t be available in the popup? Is it → Select all and Translate ?

Yes, the Select all and Translate will not be available. In fact, if your device does not have the translate app installed, you will not see the Translate option.

thx for the clarification @cooltey — let’s go with your suggestion, then

Unable to navigate to the search button using Tab/arrow keys

This issue cannot be solved easily since the Toolbar component has its own rule of handling focus, and it is difficult to gain focus or lose focus from it. Looks like it is an issue that should be fixed by Google team.

Also, I downloaded the Youtube app and it has the same issue that cannot use the tab key to reach the search icon; even the Google play store app has the same issue.

@Charlotte + @schoenbaechler Would you might if we skip this?

Cannot use keys to move through initial screen

This can be ignored because the user can actually use the tab key to select the indicators to select the page to move through the initial screens; also, by using the tab key, the "next" button can be also selected to go through the initial screens.

Unable to navigate to the search button using Tab/arrow keys

This issue cannot be solved easily since the Toolbar component has its own rule of handling focus, and it is difficult to gain focus or lose focus from it. Looks like it is an issue that should be fixed by Google team.

Also, I downloaded the Youtube app and it has the same issue that cannot use the tab key to reach the search icon; even the Google play store app has the same issue.

@Charlotte + @schoenbaechler Would you might if we skip this?

Yes, that's fine. I'll write back to Google saying why we have not changed this.