Page MenuHomePhabricator
Create Task
Maniphest T250728

Wikibase Client data-bridge selenium test failure - wait for entity to be protected
Closed, ResolvedPublic
Actions

Description

Seen on a patch to Echo

https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Echo/+/590009/
https://integration.wikimedia.org/ci/job/wmf-quibble-selenium-php72-docker/33453/console

18:02:00 [chrome 73.0.3683.75 Linux #0-5] Spec: /workspace/src/extensions/Wikibase/client/data-bridge/tests/selenium/specs/permissionChecks.js
18:02:00 [chrome 73.0.3683.75 Linux #0-5] Running: chrome (v73.0.3683.75) on Linux
18:02:00 [chrome 73.0.3683.75 Linux #0-5] Session ID: 2b158c57e6688b372bff41247e9cac22
18:02:00 [chrome 73.0.3683.75 Linux #0-5]
18:02:00 [chrome 73.0.3683.75 Linux #0-5] permission checks
18:02:00 [chrome 73.0.3683.75 Linux #0-5]     if the client page is editable for the user
18:02:00 [chrome 73.0.3683.75 Linux #0-5]        ✓ show the editlink
18:02:00 [chrome 73.0.3683.75 Linux #0-5]
18:02:00 [chrome 73.0.3683.75 Linux #0-5]     if the client page is not editable for the user
18:02:00 [chrome 73.0.3683.75 Linux #0-5]        ✓ hide the editlink
18:02:00 [chrome 73.0.3683.75 Linux #0-5]
18:02:00 [chrome 73.0.3683.75 Linux #0-5]     if the item is protected on the repo
18:02:00 [chrome 73.0.3683.75 Linux #0-5]        ✖ show a permission error when opening bridge
18:02:00 [chrome 73.0.3683.75 Linux #0-5]
18:02:00 [chrome 73.0.3683.75 Linux #0-5]     if the user is blocked on the client
18:02:00 [chrome 73.0.3683.75 Linux #0-5]        ✓ show a permission error when opening bridge
18:02:00 [chrome 73.0.3683.75 Linux #0-5]
18:02:00 [chrome 73.0.3683.75 Linux #0-5] 3 passing (16.3s)
18:02:00 [chrome 73.0.3683.75 Linux #0-5] 1 failing
18:02:00 [chrome 73.0.3683.75 Linux #0-5]
18:02:00 [chrome 73.0.3683.75 Linux #0-5] 1) if the item is protected on the repo show a permission error when opening bridge
18:02:00 [chrome 73.0.3683.75 Linux #0-5] element (".oo-ui-dialog #data-bridge-app .wb-db-error") still not displayed after 5000ms
18:02:00 [chrome 73.0.3683.75 Linux #0-5] Error: element (".oo-ui-dialog #data-bridge-app .wb-db-error") still not displayed after 5000ms
18:02:00 [chrome 73.0.3683.75 Linux #0-5]     at Context.it (/workspace/src/extensions/Wikibase/client/data-bridge/tests/selenium/specs/permissionChecks.js:96:25)
18:02:00 
18:02:00 
18:02:00 Spec Files:	 5 passed, 1 failed, 6 total (100% completed) in 00:01:05

Details

SubjectRepoBranchLines +/-
bridge: selenium: permissionChecks: wait for entity to be protectedmediawiki/extensions/Wikibasemaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Reedy created this task.Apr 20 2020, 5:20 PM
Restricted Application added a project: Wikidata. · View Herald TranscriptApr 20 2020, 5:20 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Krinkle moved this task from Backlog to WMF-deployed Build Failure on the ci-test-error board.Apr 23 2020, 9:09 PM
Krinkle edited projects, added ci-test-error (WMF-deployed Build Failure); removed ci-test-error.
Addshore added a project: Wikidata-Bridge.May 6 2020, 3:46 PM
Addshore subscribed.

This just happened again on the gate job for https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/+/594532/

gerritbot added a comment.May 6 2020, 4:18 PM

Change 594745 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: selenium: permissionChecks: wait for entity to be protected

https://gerrit.wikimedia.org/r/594745

gerritbot added a project: Patch-For-Review.May 6 2020, 4:18 PM
• Pablo-WMDE claimed this task.May 6 2020, 4:31 PM
• Pablo-WMDE edited projects, added Wikidata-Bridge-Sprint-19; removed Wikidata-Bridge.
• Pablo-WMDE moved this task from To do to Peer Review on the Wikidata-Bridge-Sprint-19 board.
gerritbot added a comment.May 6 2020, 6:46 PM

Change 594745 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: selenium: permissionChecks: wait for entity to be protected

https://gerrit.wikimedia.org/r/594745

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.32; 2020-05-12).May 6 2020, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.May 6 2020, 7:10 PM
• Pablo-WMDE moved this task from Peer Review to Done on the Wikidata-Bridge-Sprint-19 board.May 7 2020, 9:03 AM
• Pablo-WMDE mentioned this in T251538: bridge selenium: 'back from a save' errorHandling times out.EditedMay 7 2020, 9:14 AM

We merged a patch for this which looks quite promising. Let's see if this solves it.

• Pablo-WMDE renamed this task from Wikibase Client data-bridge selenium test failure to Wikibase Client data-bridge selenium test failure - wait for entity to be protected.May 7 2020, 9:16 AM
• Pablo-WMDE closed this task as Resolved.May 11 2020, 11:48 AM

Closing as it did not reoccur. Feel free to reopen should it happen again.

Nikerabbit mentioned this in T264926: Wikibase Selenium tests are flaky.Feb 15 2021, 11:06 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL