Page MenuHomePhabricator
Create Task
Maniphest T250749

Keyboard focus not indicated on list items in the topic action menu (three dots), though focus is set
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to Reproduce:

  • Launch a wiki on a page
  • Navigate till Talk and hit enter
  • Add any topic with any name
  • Navigate till three dots of the created topic
  • Check if it's list item is accessible using keyboard

Actual Results:

  • No focus feedback to items on dropdown list
  • Keyboard only users will find it difficult to navigate through the page

Expected Results:

  • Focus goes to items on dropdown list, with visual feedback

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Add focus feedback to dropdown list of actionsBkudiess-msftmediawiki/extensions/Flowmaster+4 -0
Customize query in gerrit

Event Timeline

Bkudiess-msft created this task.Apr 20 2020, 8:46 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptApr 20 2020, 8:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Aklapper renamed this task from Keyboard focus doesn't go on list items of topic three dots to Keyboard focus not indicated on list items in the topic action menu (three dots), though focus is set.Apr 24 2020, 6:40 PM

@Bkudiess-msft: I tried to reproduce on https://www.mediawiki.org/wiki/Structured_Discussions/Sandbox in Firefox 75 and while there is indeed no visual indication of focus on list items, the target links for each focused item work when pressing the Enter key in Firefox 75, so I boldly edit the ticket summary.

Bkudiess-msft added a comment.Jun 23 2020, 9:15 PM

@Aklapper The following PR contains a fix for this issue. https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Flow/%2B/591176

gerritbot added a comment.Jun 24 2020, 1:23 AM

Change 591176 had a related patch set uploaded (by VolkerE; owner: Bkudiess-msft):
[mediawiki/extensions/Flow@master] Add focus feedback to dropdown list of actions

https://gerrit.wikimedia.org/r/591176

gerritbot added a project: Patch-For-Review.Jun 24 2020, 1:23 AM
gerritbot added a comment.Jun 24 2020, 6:22 AM

Change 591176 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Add focus feedback to dropdown list of actions

https://gerrit.wikimedia.org/r/591176

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.39; 2020-06-30).Jun 24 2020, 7:00 AM
Volker_E closed this task as Resolved.Jun 24 2020, 7:03 AM
Volker_E subscribed.

Thanks @Bkudiess-msft! :)

Maintenance_bot removed a project: Patch-For-Review.Jun 24 2020, 7:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits