Page MenuHomePhabricator
Create Task
Maniphest T250761

DifferenceEngine $mNewRev and $mOldRev are Revision objects
Closed, ResolvedPublic
Actions

Description

DifferenceEngine $mNewRev and $mOldRev are Revision objects (both protected variables) and the class is extended by lots of deployed extensions that access the variable

Uses in subclasses should be replaced with getOldRevision and getNewRevision, which return RevisionRecord

Extended by (in deployed extensions) - no uses remaining

  • FlowBoardContentDiffView - no uses
  • JCJsonDifferenceEngine - no uses
  • MassMessageListDiffEngine - no uses
  • NewsletterDiffEngine - no uses
  • EntityContentDiffView - no uses

Have remaining uses:

  • InlineDifferenceEngine

Non deployed extensions that access the variables:

  • SocialProfile
  • SpamDiffTool

Core update has merged, only thing remaining is to update Wikibase at https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/+/598858/

Details

SubjectRepoBranchLines +/-
EntityContentDiffView: update getParserOutput signaturemediawiki/extensions/Wikibasemaster+2 -8
Remove DifferenceEngine::$mNewRev and $mOldRevmediawiki/coremaster+163 -125
Remove use of DifferenceEngine::$mNewRev and $mOldRevmediawiki/extensions/SocialProfilemaster+41 -12
Remove use of DifferenceEngine::$mNewRev and $mOldRevmediawiki/extensions/SpamDiffToolmaster+5 -2
Remove use of InlineDifferenceEngine Revision variablesmediawiki/extensions/MobileFrontendmaster+11 -8
Customize query in gerrit

Related Objects
Search...

Event Timeline

DannyS712 created this task.Apr 20 2020, 10:16 PM
Restricted Application added projects: Growth-Team, Wikidata. · View Herald TranscriptApr 20 2020, 10:16 PM
DannyS712 triaged this task as Medium priority.Apr 20 2020, 10:17 PM
DannyS712 moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.
DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.
DannyS712 updated the task description. (Show Details)Apr 20 2020, 10:19 PM
gerritbot added a comment.Apr 20 2020, 10:20 PM

Change 591201 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/MobileFrontend@master] Remove use of InlineDifferenceEngine Revision variables

https://gerrit.wikimedia.org/r/591201

gerritbot added a project: Patch-For-Review.Apr 20 2020, 10:20 PM
DannyS712 removed projects: MediaWiki-extensions-WikibaseRepository, MediaWiki-extensions-Newsletter, MassMessage, JsonConfig, StructuredDiscussions, Wikidata, Growth-Team.Apr 20 2020, 10:25 PM
DannyS712 updated the task description. (Show Details)
gerritbot added a comment.Apr 29 2020, 4:38 PM

Change 593272 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate DifferenceEngine::$mNewRev and $mOldRev

https://gerrit.wikimedia.org/r/593272

gerritbot added a comment.Apr 30 2020, 10:22 PM

Change 591201 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Remove use of InlineDifferenceEngine Revision variables

https://gerrit.wikimedia.org/r/591201

DannyS712 updated the task description. (Show Details)Apr 30 2020, 10:26 PM
gerritbot added a comment.May 1 2020, 4:12 AM

Change 593662 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/SpamDiffTool@master] Remove use of DifferenceEngine::$mNewRev and $mOldRev

https://gerrit.wikimedia.org/r/593662

gerritbot added a comment.May 1 2020, 4:15 AM

Change 593663 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/SocialProfile@master] Remove use of DifferenceEngine::$mNewRev and $mOldRev

https://gerrit.wikimedia.org/r/593663

DannyS712 mentioned this in T250580: Hard deprecate Revision::isMinor.May 1 2020, 6:23 PM
DannyS712 updated the task description. (Show Details)May 1 2020, 8:58 PM
Jdlrobson added a project: Web-Team-Backlog (Tracking).May 4 2020, 11:42 PM
gerritbot added a comment.May 18 2020, 6:52 PM

Change 593662 merged by jenkins-bot:
[mediawiki/extensions/SpamDiffTool@master] Remove use of DifferenceEngine::$mNewRev and $mOldRev

https://gerrit.wikimedia.org/r/593662

DannyS712 updated the task description. (Show Details)May 18 2020, 7:04 PM
gerritbot added a comment.May 24 2020, 1:36 PM

Change 593663 merged by jenkins-bot:
[mediawiki/extensions/SocialProfile@master] Remove use of DifferenceEngine::$mNewRev and $mOldRev

https://gerrit.wikimedia.org/r/593663

DannyS712 mentioned this in rESPRad79bcd9da9b: Remove use of DifferenceEngine::$mNewRev and $mOldRev.May 24 2020, 2:13 PM
DannyS712 updated the task description. (Show Details)May 26 2020, 9:46 PM
gerritbot added a comment.May 26 2020, 9:48 PM

Change 598858 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Wikibase@master] EntityContentDiffView: update getParserOutput signature

https://gerrit.wikimedia.org/r/598858

gerritbot added a comment.May 26 2020, 9:58 PM

Change 593272 merged by jenkins-bot:
[mediawiki/core@master] Remove DifferenceEngine::$mNewRev and $mOldRev

https://gerrit.wikimedia.org/r/593272

DannyS712 updated the task description. (Show Details)May 26 2020, 10:00 PM
DannyS712 moved this task from In progress to Awaiting review and deployment on the User-DannyS712 board.
gerritbot added a comment.Jun 2 2020, 8:34 PM

Change 598858 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] EntityContentDiffView: update getParserOutput signature

https://gerrit.wikimedia.org/r/598858

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.36; 2020-06-09).Jun 2 2020, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 2 2020, 9:10 PM
DannyS712 closed this task as Resolved.Jun 2 2020, 10:35 PM
DannyS712 moved this task from Awaiting review and deployment to Resolved (deprecation) on the User-DannyS712 board.Jul 9 2020, 11:16 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL