Page MenuHomePhabricator
Create Task
Maniphest T250762

UsersMultiselectWidget not announcing status message
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to Reproduce:

  • Navigate to a place where the UsersMultiselectWidget can be found
  • Turn on screen reader
  • Add some text to element
  • Observe the announcements by screen reader

Actual Results:

  • While editing the text in edit box , there are some search results appeared on the screen but screen reader is not making any announcement regarding that .

Expected Results:

  • Screen reader should announce regarding search results appeared while editing text so it will easier to select the list item from search result to the user

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
mw.widgets.UsersMultiSelectWidget: Don't assume `suggestions` array element existsmediawiki/coremaster+6 -2
mw.widgets.UsersMultiSelectWidget: Don't assume `suggestions` array element existsmediawiki/coreREL1_35+6 -2
Make screen reader announce status message on UsersMultiselectWidgetmediawiki/coremaster+4 -1
Customize query in gerrit

Event Timeline

Bkudiess-msft created this task.Apr 20 2020, 10:32 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 20 2020, 10:32 PM
Volker_E subscribed.Apr 21 2020, 5:20 AM

@Bkudiess-msft What extension or other software is this concerning?

Aklapper added a project: MediaWiki-General.Apr 21 2020, 5:36 AM

Assuming this is about MediaWiki core as /resources/src/mediawiki.widgets/mw.widgets.UsersMultiselectWidget.js exists, hence adding MediaWiki-General in lack of a more specific code base tag. @Bkudiess-msft: Feel free to correct (and to explicitly mention the code repository in tickets). :)

Tam-edwin-microsoft subscribed.Apr 24 2020, 6:53 PM

Thanks! This is for the core project, we are using the widget in a private extension, but Barbara's change is for the accessibility of the widget in general

Bkudiess-msft added a comment.Jun 23 2020, 9:13 PM

@Volker_E @Aklapper The following PR contains a fix for this issue. https://gerrit.wikimedia.org/r/c/mediawiki/core/%2B/591211

gerritbot added a comment.Jun 24 2020, 3:42 AM

Change 591211 had a related patch set uploaded (by Aklapper; owner: Bkudiess-msft):
[mediawiki/core@master] Fixes screen reader not announcing status message on UsersMultiselectWidget

https://gerrit.wikimedia.org/r/591211

gerritbot added a project: Patch-For-Review.Jun 24 2020, 3:42 AM
Aklapper added a comment.Jun 24 2020, 3:42 AM

Thanks - please follow https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines when writing the commit message. :)

gerritbot added a comment.Jun 25 2020, 5:58 AM

Change 591211 merged by jenkins-bot:
[mediawiki/core@master] Make screen reader announce status message on UsersMultiselectWidget

https://gerrit.wikimedia.org/r/591211

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.39; 2020-06-30).Jun 25 2020, 6:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jun 25 2020, 6:10 AM
gerritbot added a comment.Jul 28 2020, 1:12 PM

Change 616764 had a related patch set uploaded (by Phuedx; owner: Phuedx):
[mediawiki/core@master] resources: Don't assume array element exists in mw.widgets.UsersMultiSelectWidget

https://gerrit.wikimedia.org/r/616764

gerritbot added a project: Patch-For-Review.Jul 28 2020, 1:12 PM
matmarex subscribed.Jul 28 2020, 8:05 PM
gerritbot added a comment.Jul 30 2020, 4:46 PM

Change 616764 merged by jenkins-bot:
[mediawiki/core@master] mw.widgets.UsersMultiSelectWidget: Don't assume suggestions array element exists

https://gerrit.wikimedia.org/r/616764

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.3; 2020-08-04).Jul 30 2020, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 30 2020, 5:10 PM
gerritbot added a comment.Jul 30 2020, 8:34 PM

Change 617433 had a related patch set uploaded (by Bartosz Dziewoński; owner: Phuedx):
[mediawiki/core@REL1_35] mw.widgets.UsersMultiSelectWidget: Don't assume suggestions array element exists

https://gerrit.wikimedia.org/r/617433

gerritbot added a project: Patch-For-Review.Jul 30 2020, 8:34 PM
matmarex closed this task as Resolved.Jul 30 2020, 8:41 PM

Presumably fixed

gerritbot added a comment.Jul 30 2020, 8:44 PM

Change 617433 merged by jenkins-bot:
[mediawiki/core@REL1_35] mw.widgets.UsersMultiSelectWidget: Don't assume suggestions array element exists

https://gerrit.wikimedia.org/r/617433

ReleaseTaggerBot edited projects, added MW-1.35-notes; removed MW-1.35-notes (1.35.0-wmf.39; 2020-06-30).Jul 30 2020, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 30 2020, 9:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits