Page MenuHomePhabricator

Hard deprecate support for Revisions from ContentHandler::getUndoContent
Closed, ResolvedPublic

Description

Outside of core, only Wikibase's EntityHandlerTestCase passes Revision objects (in deployed code)

Event Timeline

DannyS712 triaged this task as Medium priority.Apr 21 2020, 2:23 AM
DannyS712 created this task.
DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.

Change 591249 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Wikibase@master] EntityHandlerTestCase: Use Content for ContentHandler::getUndoContent

https://gerrit.wikimedia.org/r/591249

Change 591249 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] EntityHandlerTestCase: Use Content for ContentHandler::getUndoContent

https://gerrit.wikimedia.org/r/591249

So the only remaining uses are in WikiPage::getUndoContent, which itself is being deprecated entirely. Once https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/591056/ is merged (ping @Pchelolo) the only code patch to provide Revision objects will itself be deprecated, so we can just hard deprecate providing Revision objects with no other changes needed

DannyS712 renamed this task from Remove support for Revisions from ContentHandler::getUndoContent to Hard deprecate support for Revisions from ContentHandler::getUndoContent.Apr 23 2020, 8:10 PM

Change 592291 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate using Revision objects in ContentHandler::getUndoContent

https://gerrit.wikimedia.org/r/592291

Change 592291 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate using Revision objects in ContentHandler::getUndoContent

https://gerrit.wikimedia.org/r/592291

DannyS712 removed a project: Patch-For-Review.
DannyS712 updated the task description. (Show Details)