Hard deprecate support for Revisions from ContentHandler::getUndoContent
Closed, ResolvedPublic
Actions

Description

Outside of core, only Wikibase's EntityHandlerTestCase passes Revision objects (in deployed code)

Update EntityHandlerTestCase
~~Replace core uses~~ only use is hard deprecated in T250680: Hard deprecate WikiPage::getUndoContent
Hard deprecate

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Hard deprecate using Revision objects in ContentHandler::getUndoContent	mediawiki/core	master	+11 -3
	EntityHandlerTestCase: Use Content for ContentHandler::getUndoContent	mediawiki/extensions/Wikibase	master	+31 -58

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T11968 Reduce use of global and public variables
Open	None	T159283 Deprecate non-configuration globals
Open	DannyS712	T159299 Deprecate and remove $wgUser
Resolved	DannyS712	T267861 [GOAL] Emit deprecation warnings reading from $wgUser
Open	DannyS712	T243708 Mediawiki core needs uses of global $wgUser removed
Resolved	DannyS712	T246284 Hard deprecate the Revision class
Resolved	DannyS712	T249561 Deprecate methods accepting Revision objects as parameters
Resolved	DannyS712	T250773 Hard deprecate support for Revisions from ContentHandler::getUndoContent

Event Timeline

DannyS712 created this task.Apr 21 2020, 2:23 AM

DannyS712 triaged this task as Medium priority.

DannyS712 moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.

DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.

Change 591249 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Wikibase@master] EntityHandlerTestCase: Use Content for ContentHandler::getUndoContent

https://gerrit.wikimedia.org/r/591249

gerritbot added a project: Patch-For-Review.Apr 21 2020, 2:25 AM

Change 591249 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] EntityHandlerTestCase: Use Content for ContentHandler::getUndoContent

https://gerrit.wikimedia.org/r/591249

Maintenance_bot removed a project: Patch-For-Review.Apr 21 2020, 1:10 PM

DannyS712 updated the task description. (Show Details)Apr 21 2020, 1:31 PM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.30; 2020-04-28).Apr 21 2020, 5:00 PM

So the only remaining uses are in WikiPage::getUndoContent, which itself is being deprecated entirely. Once https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/591056/ is merged (ping @Pchelolo) the only code patch to provide Revision objects will itself be deprecated, so we can just hard deprecate providing Revision objects with no other changes needed

DannyS712 renamed this task from Remove support for Revisions from ContentHandler::getUndoContent to Hard deprecate support for Revisions from ContentHandler::getUndoContent.Apr 23 2020, 8:10 PM

DannyS712 updated the task description. (Show Details)Apr 23 2020, 8:19 PM

Change 592291 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate using Revision objects in ContentHandler::getUndoContent

https://gerrit.wikimedia.org/r/592291

gerritbot added a project: Patch-For-Review.Apr 23 2020, 8:20 PM

DannyS712 moved this task from In progress to Awaiting review and deployment on the User-DannyS712 board.Apr 23 2020, 8:23 PM

Change 592291 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate using Revision objects in ContentHandler::getUndoContent

https://gerrit.wikimedia.org/r/592291

DannyS712 closed this task as Resolved.Apr 27 2020, 9:17 PM

DannyS712 removed a project: Patch-For-Review.

DannyS712 updated the task description. (Show Details)

DannyS712 moved this task from Awaiting review and deployment to Resolved (deprecation) on the User-DannyS712 board.May 27 2020, 8:31 AM

Aklapper added a project: MediaWiki-extensions-Wikibase-Repo.May 16 2023, 1:24 PM

Aklapper removed a subscriber: MediaWiki-extensions-Wikibase-Repo.

Maintenance_bot added a project: Wikidata.May 16 2023, 1:29 PM