Page MenuHomePhabricator
Create Task
Maniphest T250802

APISite.fromDBName wiki recognition issues
Closed, ResolvedPublic
Actions

Description

Steps to reproduce

  1. Save all WMF wikis db names
  2. Remove private WMF wikis from the list
  3. Run APISite.fromDBName for each

Expected behavior
All should go well.

Current behavior
The following wikis produce an error:
['advisorywiki', 'donatewiki', 'etwikimedia', 'gewikimedia', 'grwikimedia', 'hiwikimedia', 'labtestwiki', 'loginwiki', 'ngwikimedia', 'nostalgiawiki', 'punjabiwikimedia', 'qualitywiki', 'romdwikimedia', 'strategywiki', 'testcommonswiki', 'usabilitywiki', 'votewiki']

I am not sure if everything can be fixed, but at least we should try to fix as much as possible.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Add testcommonswiki to PWBUrbanecmpywikibot/coremaster+1 -0
Add ngwikimedia to PWBUrbanecmpywikibot/coremaster+1 -1
Update wikimediachapter_familyUrbanecmpywikibot/coremaster+7 -4
Customize query in gerrit

Related Objects

Event Timeline

Dvorapa created this task.Apr 21 2020, 1:45 PM
Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptApr 21 2020, 1:45 PM
Dvorapa renamed this task from APISite.fromDBName issues to APISite.fromDBName wiki recognition issues.Apr 21 2020, 1:49 PM
Dvorapa added a comment.EditedApr 21 2020, 2:14 PM

Per https://lists.wikimedia.org/pipermail/newprojects/ at least gr, ng a ge chapter wikis are new.

gerritbot added a comment.Apr 21 2020, 4:22 PM

Change 591372 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[pywikibot/core@master] Update wikimediachapter_family

https://gerrit.wikimedia.org/r/591372

gerritbot added a project: Patch-For-Review.Apr 21 2020, 4:22 PM
Urbanecm subscribed.Apr 21 2020, 4:24 PM

donatewiki, loginwiki, nostalgiawiki are service wikis (memorial in case of nostalgiawiki) and aren't touched by humans, except highly specific cases.

labtestwiki is Wikitech test wiki, and again is highly special and doesn't need to be in Pywikibot.

testcommonswiki was created solely due to suggested edits thing - it may or may not stay in WMF prod.

etwikimedia is be-tarask #1323, the wiki has old dbname, but new URL etc. It's at ee.wikimedia.org.

votewiki is a single purpose wiki used for some major elections (enwiki arbcom and board of trustees at least). No need to edit, you just vote there :-).

Rest is closed/obscure working wikis, and they're not worth adding to PWB IMO.

Dvorapa added a comment.Apr 21 2020, 4:47 PM

labtestwiki is Wikitech test wiki, and again is highly special and doesn't need to be in Pywikibot.
testcommonswiki was created solely due to suggested edits thing - it may or may not stay in WMF prod.

We usually support test wikis as they server specifically for testing things (like Pywikibot).

gerritbot added a comment.Apr 21 2020, 4:51 PM

Change 591372 merged by jenkins-bot:
[pywikibot/core@master] Update wikimediachapter_family

https://gerrit.wikimedia.org/r/591372

gerritbot added a comment.Apr 21 2020, 4:53 PM

Change 591379 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[pywikibot/core@master] Add ngwikimedia to PWB

https://gerrit.wikimedia.org/r/591379

Urbanecm mentioned this in rPWBC72d44d4f8b82: Update wikimediachapter_family.Apr 21 2020, 4:54 PM
gerritbot added a comment.Apr 21 2020, 4:57 PM

Change 591380 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[pywikibot/core@master] Add testcommonswiki to PWB

https://gerrit.wikimedia.org/r/591380

gerritbot added a comment.Apr 21 2020, 5:06 PM

Change 591379 merged by jenkins-bot:
[pywikibot/core@master] Add ngwikimedia to PWB

https://gerrit.wikimedia.org/r/591379

Urbanecm mentioned this in rPWBC515644ebb912: Add ngwikimedia to PWB.Apr 21 2020, 5:07 PM
gerritbot added a comment.Apr 21 2020, 5:16 PM

Change 591380 merged by jenkins-bot:
[pywikibot/core@master] Add testcommonswiki to PWB

https://gerrit.wikimedia.org/r/591380

Urbanecm mentioned this in rPWBCfdbaa224d8bc: Add testcommonswiki to PWB.Apr 21 2020, 5:17 PM
Dvorapa closed this task as Resolved.Apr 21 2020, 5:20 PM
Dvorapa assigned this task to Urbanecm.
Dvorapa triaged this task as Medium priority.
Dvorapa removed a project: Patch-For-Review.
Restricted Application added a project: User-Urbanecm. · View Herald TranscriptApr 21 2020, 5:20 PM
Dvorapa added a comment.EditedApr 21 2020, 5:21 PM

Seems the important were added, other are closed or not appropriate for bot edits. Many thanks!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits